From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Matthias Meulien Newsgroups: gmane.emacs.devel Subject: Re: Patch to bookmark.el Date: Mon, 19 Dec 2011 22:14:57 +0100 Message-ID: <1324329297.5507.12.camel@localhost.localdomain> References: <87zkeqhod2.fsf@floss.red-bean.com> <87pqfmcupi.fsf@floss.red-bean.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1324332686 29865 80.91.229.12 (19 Dec 2011 22:11:26 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 19 Dec 2011 22:11:26 +0000 (UTC) Cc: emacs-devel@gnu.org To: Karl Fogel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 19 23:11:20 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RclQW-0000zv-Cd for ged-emacs-devel@m.gmane.org; Mon, 19 Dec 2011 23:11:20 +0100 Original-Received: from localhost ([::1]:54014 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RclQV-0004nW-SJ for ged-emacs-devel@m.gmane.org; Mon, 19 Dec 2011 17:11:19 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:60055) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RckPI-0000sU-4c for emacs-devel@gnu.org; Mon, 19 Dec 2011 16:06:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RckPG-0000zP-RX for emacs-devel@gnu.org; Mon, 19 Dec 2011 16:05:59 -0500 Original-Received: from mail-ee0-f41.google.com ([74.125.83.41]:61568) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RckPG-0000zL-Ii for emacs-devel@gnu.org; Mon, 19 Dec 2011 16:05:58 -0500 Original-Received: by eekc41 with SMTP id c41so5943389eek.0 for ; Mon, 19 Dec 2011 13:05:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:subject:from:to:cc:in-reply-to:references:content-type :date:mime-version:x-mailer:content-transfer-encoding; bh=oocc1HhcO8ZbBx33aMzTSARaci3PcCurhp+pt1B0MhY=; b=iVEFMr0Fs1YVhITgfk2IfJ+TpkZB7zh1U2zJDDHBX8S4qGP8W47VWFgbAhJ+iYXF43 drLtbg85poHNCIyA0gfu7jLKLRmnTJm9rBxSYKm7L8einMBmwtBk6XtoXaah7hyVkoNi bF3Yy134GXVReQgCJTg4iQ6Nu7Yd0XKW97bS4= Original-Received: by 10.14.123.20 with SMTP id u20mr4825535eeh.101.1324328757266; Mon, 19 Dec 2011 13:05:57 -0800 (PST) Original-Received: from [192.168.1.45] (jau31-3-82-239-20-84.fbx.proxad.net. [82.239.20.84]) by mx.google.com with ESMTPS id q28sm49322533eea.6.2011.12.19.13.05.54 (version=SSLv3 cipher=OTHER); Mon, 19 Dec 2011 13:05:55 -0800 (PST) In-Reply-To: <87pqfmcupi.fsf@floss.red-bean.com> X-Mailer: Evolution 3.2.2 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 74.125.83.41 X-Mailman-Approved-At: Mon, 19 Dec 2011 17:11:17 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:146852 Archived-At: Dear Karl, I just tested the patch you sent to emacs-devel@gnu.org and realized it is not based on the last version I sent to you: After applying your patch, I still have a (forward-line 2) in function `bookmark-bmenu-show-filenames'. With this patch, file names are not shown in the first two lines of the bookmark list (after calling `bookmark-bmenu-toggle-file-names'). It should be replaced by something like: (when bookmark-bmenu-use-header-line (bookmark-bmenu-set-header) (forward-line bookmark-bmenu-header-height)) By the way, I have also a version of bookmark.el which adds dedicated faces for buffer names and file paths like in the buffer list. If people are interested I can send the corresponding patch to emacs-devel... Thanks for reading, -- Matthias