From: Matthias Meulien <orontee@gmail.com>
To: Karl Fogel <kfogel@red-bean.com>
Cc: emacs-devel@gnu.org
Subject: Re: Patch to bookmark.el
Date: Mon, 19 Dec 2011 22:14:57 +0100 [thread overview]
Message-ID: <1324329297.5507.12.camel@localhost.localdomain> (raw)
In-Reply-To: <87pqfmcupi.fsf@floss.red-bean.com>
Dear Karl,
I just tested the patch you sent to emacs-devel@gnu.org and realized it
is not based on the last version I sent to you: After applying your
patch, I still have a
(forward-line 2)
in function `bookmark-bmenu-show-filenames'. With this patch, file names
are not shown in the first two lines of the bookmark list (after calling
`bookmark-bmenu-toggle-file-names').
It should be replaced by something like:
(when bookmark-bmenu-use-header-line
(bookmark-bmenu-set-header)
(forward-line bookmark-bmenu-header-height))
By the way, I have also a version of bookmark.el which adds dedicated
faces for buffer names and file paths like in the buffer list. If people
are interested I can send the corresponding patch to emacs-devel...
Thanks for reading,
--
Matthias
next prev parent reply other threads:[~2011-12-19 21:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAFEQCfBwuU54R4+dcDC4qHzX4gRrtA4yAhExDzot0iq9anvg1w@mail.gmail.com>
2011-12-17 21:36 ` Patch to bookmark.el Karl Fogel
2011-12-17 22:22 ` Stefan Monnier
2011-12-17 22:23 ` Karl Fogel
2011-12-19 19:30 ` Glenn Morris
2011-12-19 21:16 ` Matthias Meulien
2011-12-19 21:25 ` Glenn Morris
2011-12-18 5:30 ` Karl Fogel
2011-12-19 21:14 ` Matthias Meulien [this message]
2011-12-20 18:11 ` Karl Fogel
2011-12-20 23:03 ` Matthias Meulien
2011-12-20 23:29 ` Karl Fogel
2013-03-07 15:37 ` Matthias Meulien
2013-03-07 22:37 ` Karl Fogel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324329297.5507.12.camel@localhost.localdomain \
--to=orontee@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=kfogel@red-bean.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).