From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 db436e9: Don't call debug on failed cl-assert Date: Fri, 27 Jan 2017 22:30:46 -0500 Message-ID: <12a5baea-9bca-994f-ec92-5ddd36321c11@gmail.com> References: <20161105015720.6371.89806@vcs.savannah.gnu.org> <20161105015720.88A6322012D@vcs.savannah.gnu.org> <4f7ad1cf-7632-abea-e15e-a3fdfff795c6@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pHLbKOUeu458a7HFSVe6XqWX30fxRV9nq" X-Trace: blaine.gmane.org 1485579764 30695 195.159.176.226 (28 Jan 2017 05:02:44 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 28 Jan 2017 05:02:44 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 Cc: Stefan Monnier , Emacs developers To: Noam Postavsky Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 28 06:02:40 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXL9i-0006oA-EN for ged-emacs-devel@m.gmane.org; Sat, 28 Jan 2017 06:02:30 +0100 Original-Received: from localhost ([::1]:50004 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXL9n-0007Bp-Gt for ged-emacs-devel@m.gmane.org; Sat, 28 Jan 2017 00:02:35 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53117) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXJjS-0005Kl-8j for emacs-devel@gnu.org; Fri, 27 Jan 2017 22:31:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXJjP-0006Zk-1j for emacs-devel@gnu.org; Fri, 27 Jan 2017 22:31:18 -0500 Original-Received: from mout.kundenserver.de ([212.227.126.131]:51797) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cXJjO-0006Zc-Mj for emacs-devel@gnu.org; Fri, 27 Jan 2017 22:31:14 -0500 Original-Received: from [18.111.113.197] ([18.111.113.197]) by mrelayeu.kundenserver.de (mreue005 [212.227.15.168]) with ESMTPSA (Nemesis) id 0MAAfN-1ceEfW0yDJ-00BKR1; Sat, 28 Jan 2017 04:30:55 +0100 In-Reply-To: X-Provags-ID: V03:K0:AxF/cXHvjBQmBIaQKj9xJgIP116dgxCAyJRCDu1H1HE3n6J/6Nf HgDXqkZ9I6rgjdmjwFhBdUGebvSSUt9XQe1IVjeJwJLUvoDHNGiAVcimL22aVbyrhizv+/7 dWkOV9k1yqNrl4TTcyX6SCifNA8yxqt8LcoG6uI16F37Ni4guBO2MPny5nBkmwLOIqUfIaF GWtEQWSBDkqopvXY4T8UQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:GMSdFKPZ0uA=:Th5iF1rSqyip6tG69lPlRC Pwuulg1kYShLlpOnoROtq6Z5/oTQW05dj9m2FjweAtt0Hsz6rBfvFvFRLgPEcClC85SxFlizK DbGMTzfYg/WNyfYXdh0ZN23RnBpjUd1vGJKfrhPZxJX98jtJM0LmwRL9jFFvacG9npWU0GNiG K8H/Ke3iNl7vBpD0M+HmNsaEbe6aqdAs6u74pOMhp88lIKZVXZADKkcum6FIuhHqQ4SKbxa8H Zs+u18Lza0aLAlQhHoBTbyx3v1TwqWdxcSqOGyEGDIQdYb23b5mb98YjeZajcuOLA+6JYnALm bOep59BT6eamrqpFRcTloVgBe/d/qgPOzf43z/6Mpiq2sifpHVSIphQEw82xU01rDoOOJyHrw 9y5VVjT9Sz8e4lAeMvCTp1qd+a1dAPFPapNP96MFWswgDRvd8qYG/oaEl8hZLXA+gkfGZcUiA r9KsHbIXZsf8DheZuPJ1iRjfdb58crTG1LesuE8TstkgnQXGRXJG1iqIqb9V389ddlyDzh5H4 ohmy96ix7iDuJq+ILKFAFhMmm7pZzUddSCW2dPW7LGFyZ0AyjC6V6+i5K0Ycnsd2Up1hqWlYZ GsLmWf1glFWBC7DiO5UAq27gevH7KNXu2dwu9deGhptZhcEVSF8mSKgfgRkeNHRdDDikrUgub WHHPlJBD2Jdk777jaVLeBXpv6mLZ/y19czMkDyY3IDY3y9zCdj8BZWBk2yCHx+dXImiY= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.126.131 X-Mailman-Approved-At: Sat, 28 Jan 2017 00:02:24 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211671 Archived-At: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --pHLbKOUeu458a7HFSVe6XqWX30fxRV9nq Content-Type: multipart/mixed; boundary="QpW8RexgNDPwAx2NlsFMqBdVGHNSEGcux"; protected-headers="v1" From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= To: Noam Postavsky Cc: Stefan Monnier , Emacs developers Message-ID: <12a5baea-9bca-994f-ec92-5ddd36321c11@gmail.com> Subject: Re: [Emacs-diffs] emacs-25 db436e9: Don't call debug on failed cl-assert References: <20161105015720.6371.89806@vcs.savannah.gnu.org> <20161105015720.88A6322012D@vcs.savannah.gnu.org> <4f7ad1cf-7632-abea-e15e-a3fdfff795c6@gmail.com> In-Reply-To: --QpW8RexgNDPwAx2NlsFMqBdVGHNSEGcux Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2017-01-27 20:59, Noam Postavsky wrote: > I guess let-binding `debugger' to a function which performs the > logging should do the trick? I already do that, in fact, and I do re-throw the exception from there. = Looks like things didn't work because of the way `debugger' is called in = `cl--assertion-failed'. Is that call correct? The argument in (funcall = debugger `(cl-assertion-failed ,form ,string ,@sargs)) doesn't seem to ma= tch the docs: Documentation: Function to call to invoke debugger. If due to frame exit, args are =E2=80=98exit=E2=80=99 and the value b= eing returned; this function=E2=80=99s value will be returned instead of that. If due to error, args are =E2=80=98error=E2=80=99 and a list of the a= rgs to =E2=80=98signal=E2=80=99. If due to =E2=80=98apply=E2=80=99 or =E2=80=98funcall=E2=80=99 entry,= one arg, =E2=80=98lambda=E2=80=99. If due to =E2=80=98eval=E2=80=99 entry, one arg, t. Is the call just missing an 'error argument? Thanks, Cl=C3=A9ment. --QpW8RexgNDPwAx2NlsFMqBdVGHNSEGcux-- --pHLbKOUeu458a7HFSVe6XqWX30fxRV9nq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYjBBmAAoJEPqg+cTm90wjFzQP/jMyMsgmjo1cPMTeUY3vP9NW rPHMIvx3D/Qx99r+A5o/HJnMEfaodgMpJ2EyLIJu1kizM1p3f38ovVptg1fZBpue /rmhKZ/9DNel124bhx6PuvLKZgqSwP3yk2qVIgTTfpUZPp2748P1Ez94D/7BMmK3 1LLuOoZD//KGAAdsIGHfTN5SJNr3Sl45eM5vwonSht4m9Ii0zdlOlCn5dGdMINRv ni877vIHZ1xPwM6eg/OzMOv852prPBBEWX+NShvUdrBdiQaUqJfWrNGhS37vvl7r XBILukDtnqnU++Z4LWNikgzipvPfbGSfV9kcLislavLDpJgqCpksQ+IyCZ1mkrWI tmjtEl/sE6MVY3cS4gh7zR8UhMFBvXdU/X8Thoeatxvjz41zrWNJ+yNNhIbxWEuF zI/PiKsDzpsY57PDIIWFB/BbtG6A5F75yeMLJG5tsrrnkdUP8/Wx+1i9UAc7HqW9 qS7NNEC1QpMSze1Y7IQsozICs0GkeiawW4Sy+0gLRMdhV/w+l0xuKLYtVWkrHMl8 x8PbBcyASB+ufiUKutb6i0L2VW4jqbtVMQGkjK0Slpbe72i/W40IH/RDzP8cTQn2 89ybG9ro3UGlfKIQoYmNakk+LbCriT2nYiiSMMag38LuaMZK3FiK46/rQFS2XoMK tKqMqhGOKTYiDiIYNEqK =YSbF -----END PGP SIGNATURE----- --pHLbKOUeu458a7HFSVe6XqWX30fxRV9nq--