unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Eric M. Ludlam" <eric@siege-engine.com>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: emacs-devel@gnu.org
Subject: Re: Completions in Semantic
Date: Thu, 22 Oct 2009 21:28:23 -0400	[thread overview]
Message-ID: <1256261303.5333.15.camel@projectile.siege-engine.com> (raw)
In-Reply-To: <873a5aappa.fsf@stupidchicken.com>

On Thu, 2009-10-22 at 21:01 -0400, Chong Yidong wrote:
> "Eric M. Ludlam" <eric@siege-engine.com> writes:
> 
> >> has not gone away for me: `C-c , j window [TAB]' in xdisp.c still brings
> >> up "window" as the only completion.
> >
> > That is probably because the old tagging information is still being
> > used.  If you run
> >
> > M-x semantic-clear-toplevel-cache RET
> >
> > in that buffer, it will flush old parsing data, or you can go into your
> > ~/.semanticdb/ directory, and delete the cache file for emacs/src before
> > starting emacs, which might be better since multiple files  there could
> > be affected.
> 
> No, I have no semanticdb directory.  C-c,j[TAB] brings up "window" as
> the only completion.  Repeating [TAB] twice brings up the other
> completions.  But the expected behavior should be to show the other
> completions on the first [TAB].

Well, I know the behavior you are talking about, but I don't get that
specific example anymore after the lexical analyzer change you merged
recently, so my assumption is some sort of cached old parser data.

The below patch removes that specific behavior from that prompt.  I'm
assuming it is in there for some reason for one of the various
completion or display types.  I'll try to figure out what it is, and
perhaps it will be unique to some kind of completion display.

The patch is against my repository.  It's in
semantic-complete-do-completion, 3rd conditional.

Eric


*** semantic-complete.el.~1.63.~	2009-10-22 21:21:12.000000000 -0400
--- semantic-complete.el	2009-10-22 21:21:21.000000000 -0400
***************
*** 528,535 ****
  	(semantic-displayor-set-completions
  	 displayor
  	 (or
! 	  (and (not (eq na 'displayend))
! 	       (semantic-collector-current-exact-match collector))
  	  (semantic-collector-all-completions collector contents))
  	 contents)
  	;; Ask the displayor to display them.
--- 528,535 ----
  	(semantic-displayor-set-completions
  	 displayor
  	 (or
! 	  ;(and (not (eq na 'displayend))
! 	  ;     (semantic-collector-current-exact-match collector))
  	  (semantic-collector-all-completions collector contents))
  	 contents)
  	;; Ask the displayor to display them.





      reply	other threads:[~2009-10-23  1:28 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-18 23:00 Completions in Semantic Chong Yidong
2009-10-18 23:55 ` Miles Bader
2009-10-19  3:50 ` Eric M. Ludlam
2009-10-19 13:48   ` Stefan Monnier
2009-10-19 16:26     ` Eric M. Ludlam
2009-10-19 18:29       ` Stefan Monnier
2009-10-19 19:33         ` Eric M. Ludlam
2009-10-19 20:06           ` Stefan Monnier
2009-10-19 22:17             ` Eric M. Ludlam
2009-10-20  0:07               ` Lennart Borgman
2009-10-30 21:17                 ` Toby Cubitt
2009-10-30 21:37                   ` Lennart Borgman
2009-10-20  0:14               ` Stefan Monnier
2009-10-20 20:20                 ` Eric M. Ludlam
2009-10-21 10:58                   ` Lluis
2009-10-21 12:35                     ` Eric M. Ludlam
2009-10-21 13:28                       ` Lluis
2009-10-21 17:35                         ` Eric M. Ludlam
2009-10-22 20:12                     ` Stefan Monnier
2009-10-27 21:21                       ` Lluis
2009-10-28  0:56                         ` Stefan Monnier
2009-10-28  2:25                           ` Eric M. Ludlam
2009-10-28  3:23                             ` Stefan Monnier
2009-10-29 14:38                               ` Lluis
2009-10-31 20:18                                 ` Stefan Monnier
2009-11-01 16:01                                   ` Lluís
2009-11-02  6:12                                     ` Stefan Monnier
2009-11-02 12:13                                       ` Eric M. Ludlam
2009-10-22 20:00                   ` Stefan Monnier
2009-10-19 23:52   ` Eric M. Ludlam
2009-10-21 14:07     ` Chong Yidong
2009-10-21 16:10       ` Eric M. Ludlam
2009-10-23  1:01         ` Chong Yidong
2009-10-23  1:28           ` Eric M. Ludlam [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1256261303.5333.15.camel@projectile.siege-engine.com \
    --to=eric@siege-engine.com \
    --cc=cyd@stupidchicken.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).