From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Eric M. Ludlam" Newsgroups: gmane.emacs.devel Subject: Re: Completions in Semantic Date: Wed, 21 Oct 2009 12:10:30 -0400 Message-ID: <1256141430.6961.1142.camel@projectile.siege-engine.com> References: <87tyxwxq6t.fsf@stupidchicken.com> <1255924220.6961.1039.camel@projectile.siege-engine.com> <1255996360.6961.1086.camel@projectile.siege-engine.com> <87hbtsn8lo.fsf@stupidchicken.com> Reply-To: eric@siege-engine.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1256143450 28491 80.91.229.12 (21 Oct 2009 16:44:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 21 Oct 2009 16:44:10 +0000 (UTC) Cc: emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 21 18:43:59 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1N0eI2-000517-SP for ged-emacs-devel@m.gmane.org; Wed, 21 Oct 2009 18:43:59 +0200 Original-Received: from localhost ([127.0.0.1]:60187 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N0eI2-0001op-EG for ged-emacs-devel@m.gmane.org; Wed, 21 Oct 2009 12:43:58 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N0dkn-0005Tk-2E for emacs-devel@gnu.org; Wed, 21 Oct 2009 12:09:37 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N0dkk-0005Sh-Pq for emacs-devel@gnu.org; Wed, 21 Oct 2009 12:09:36 -0400 Original-Received: from [199.232.76.173] (port=54898 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N0dkk-0005Sc-KN for emacs-devel@gnu.org; Wed, 21 Oct 2009 12:09:34 -0400 Original-Received: from static-71-184-83-10.bstnma.fios.verizon.net ([71.184.83.10]:54904 helo=projectile.siege-engine.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N0dkj-0006VX-Ht for emacs-devel@gnu.org; Wed, 21 Oct 2009 12:09:34 -0400 Original-Received: from projectile.siege-engine.com (localhost [127.0.0.1]) by projectile.siege-engine.com (8.14.3/8.14.3/Debian-6) with ESMTP id n9LGAVCs020695; Wed, 21 Oct 2009 12:10:31 -0400 Original-Received: (from zappo@localhost) by projectile.siege-engine.com (8.14.3/8.14.3/Submit) id n9LGAUJe020694; Wed, 21 Oct 2009 12:10:30 -0400 X-Authentication-Warning: projectile.siege-engine.com: zappo set sender to eric@siege-engine.com using -f In-Reply-To: <87hbtsn8lo.fsf@stupidchicken.com> X-Mailer: Evolution 2.26.1 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:116293 Archived-At: On Wed, 2009-10-21 at 10:07 -0400, Chong Yidong wrote: > "Eric M. Ludlam" writes: > > > On Sun, 2009-10-18 at 23:50 -0400, Eric M. Ludlam wrote: > >> For your particular example in xdisp.c, it seems the contents of > >> xdisp.c fails to parse properly. It seems to be related to the P_ > >> macro, and one of the uses of it involving a line-end in the middle. > >> I've narrowed it down and will see if I can fix it. > > > > To reply to myself, I checked changes into the CEDET repository for the > > C preprocessor handling to fix the bug found here in xdisp. > > > > By way of side effect, the completion problem originally posed is also > > fixed, as there is no "window" symbol in the file anymore. > > I've merged your changes into the Emacs repository: > > * cedet/semantic/bovine/c.el (semantic-c-debug-mode-init) > (semantic-c-debug-mode-init-pch): New functions. > (semantic-c-debug-mode-init-last-mode): New var. > (semantic-c-parse-lexical-token): Use them. > > * cedet/semantic/lex-spp.el (semantic-lex-spp-anlyzer-do-replace): > When extracting the argument list, limit only by point-max. > > I assume it's the lex-spp change you're referring to. However, the bug Correct. The other is related to a different bug with a users c-mode-hook that might throw an error, and how to detect and tell them about it. > has not gone away for me: `C-c , j window [TAB]' in xdisp.c still brings > up "window" as the only completion. That is probably because the old tagging information is still being used. If you run M-x semantic-clear-toplevel-cache RET in that buffer, it will flush old parsing data, or you can go into your ~/.semanticdb/ directory, and delete the cache file for emacs/src before starting emacs, which might be better since multiple files there could be affected. Eric