From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Eric M. Ludlam" Newsgroups: gmane.emacs.devel Subject: Re: Problems with EDE Date: Tue, 13 Oct 2009 22:34:57 -0400 Message-ID: <1255487697.6961.535.camel@projectile.siege-engine.com> References: <87hbun9jbs.fsf@stupidchicken.com> <1254397096.16450.84.camel@projectile.siege-engine.com> <1254575261.6961.23.camel@projectile.siege-engine.com> <873a5wbed3.fsf@stupidchicken.com> <8763apttus.fsf@stupidchicken.com> Reply-To: eric@siege-engine.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1255487693 11059 80.91.229.12 (14 Oct 2009 02:34:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 14 Oct 2009 02:34:53 +0000 (UTC) Cc: Sascha Wilde , emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 14 04:34:42 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Mxth7-00036a-JA for ged-emacs-devel@m.gmane.org; Wed, 14 Oct 2009 04:34:30 +0200 Original-Received: from localhost ([127.0.0.1]:46301 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mxth6-0001yF-R3 for ged-emacs-devel@m.gmane.org; Tue, 13 Oct 2009 22:34:28 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mxth2-0001y1-Dc for emacs-devel@gnu.org; Tue, 13 Oct 2009 22:34:24 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mxth1-0001xn-IE for emacs-devel@gnu.org; Tue, 13 Oct 2009 22:34:23 -0400 Original-Received: from [199.232.76.173] (port=54789 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mxth1-0001xk-Dt for emacs-devel@gnu.org; Tue, 13 Oct 2009 22:34:23 -0400 Original-Received: from static-71-184-83-10.bstnma.fios.verizon.net ([71.184.83.10]:44057 helo=projectile.siege-engine.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mxth0-0001h0-Ui for emacs-devel@gnu.org; Tue, 13 Oct 2009 22:34:23 -0400 Original-Received: from projectile.siege-engine.com (localhost [127.0.0.1]) by projectile.siege-engine.com (8.14.3/8.14.3/Debian-6) with ESMTP id n9E2YwBU003353; Tue, 13 Oct 2009 22:34:58 -0400 Original-Received: (from zappo@localhost) by projectile.siege-engine.com (8.14.3/8.14.3/Submit) id n9E2Yvv5003352; Tue, 13 Oct 2009 22:34:57 -0400 X-Authentication-Warning: projectile.siege-engine.com: zappo set sender to eric@siege-engine.com using -f In-Reply-To: <8763apttus.fsf@stupidchicken.com> X-Mailer: Evolution 2.26.1 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:116127 Archived-At: Thanks for the patch. I have applied it to my repository. I've added cedet/cedet-ediff.el to my repository which lets me diff between the Emacs CVS repository and the CEDET repository more easilly, which allowed me to also get the spelling fix someone checked in. If you would like to just diff the Emacs repository, I'll be able to use my new tool to get your patch merged into my repository more easily now. Thanks Eric On Thu, 2009-10-08 at 18:15 -0400, Chong Yidong wrote: > Sascha Wilde writes: > > > Yet another one: > > ede-make-dist does not work for ede automake projects: > > > > -*- mode: compilation; default-directory: "/tmp/cedet-test1/" -*- > > Compilation started at Thu Oct 8 22:52:13 > > > > make -f /tmp/cedet-test1/Makefile.am dist > > make: *** No rule to make target `dist'. Stop. > > > > Compilation exited abnormally with code 2 at Thu Oct 8 22:52:13 > > > > Using the Makefile.am is obviously wrong. The actual Makefile contains > > an working dist target. > > This is a bug in project-make-dist (the filename comparison forgets that > ede-proj-dist-makefile returns a full filename). I've checked in a fix > into the trunk. > > Eric, here's a patch for your tree (it also includes a stylistic > correction, to use expand-file-name instead of concat to generate full > filenames). > > > * cedet/ede/ede-proj.el (project-make-dist, project-compile-project): > Fix filename test. > (ede-proj-dist-makefile): Use expand-file-name instead of concat > to expand file names. > > *** cedet/ede/ede-proj.el.~1.62.~ 2009-08-18 19:56:57.000000000 -0400 > --- cedet/ede/ede-proj.el 2009-10-08 18:12:20.000000000 -0400 > *************** > *** 453,459 **** > (not (y-or-n-p "Dist file already exists.