From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Eric M. Ludlam" Newsgroups: gmane.emacs.devel Subject: Re: CEDET merge Date: Wed, 07 Oct 2009 12:20:38 -0400 Message-ID: <1254932438.6961.292.camel@projectile.siege-engine.com> References: <87hbun9jbs.fsf@stupidchicken.com> <87my43yil2.fsf@hagelb.org> <8763ar7oiz.fsf@stupidchicken.com> Reply-To: eric@siege-engine.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1254932738 9386 80.91.229.12 (7 Oct 2009 16:25:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 7 Oct 2009 16:25:38 +0000 (UTC) Cc: Phil Hagelberg , emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 07 18:25:28 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MvZKO-0005Br-JE for ged-emacs-devel@m.gmane.org; Wed, 07 Oct 2009 18:25:24 +0200 Original-Received: from localhost ([127.0.0.1]:37872 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MvZKO-0003q1-0O for ged-emacs-devel@m.gmane.org; Wed, 07 Oct 2009 12:25:24 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MvZFd-00024m-2x for emacs-devel@gnu.org; Wed, 07 Oct 2009 12:20:29 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MvZFb-00023r-6A for emacs-devel@gnu.org; Wed, 07 Oct 2009 12:20:28 -0400 Original-Received: from [199.232.76.173] (port=53196 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MvZFa-00023V-Qe for emacs-devel@gnu.org; Wed, 07 Oct 2009 12:20:26 -0400 Original-Received: from static-71-184-83-10.bstnma.fios.verizon.net ([71.184.83.10]:35320 helo=projectile.siege-engine.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MvZFa-0001IV-GR for emacs-devel@gnu.org; Wed, 07 Oct 2009 12:20:26 -0400 Original-Received: from projectile.siege-engine.com (localhost [127.0.0.1]) by projectile.siege-engine.com (8.14.3/8.14.3/Debian-6) with ESMTP id n97GKdPE021766; Wed, 7 Oct 2009 12:20:39 -0400 Original-Received: (from zappo@localhost) by projectile.siege-engine.com (8.14.3/8.14.3/Submit) id n97GKdju021765; Wed, 7 Oct 2009 12:20:39 -0400 X-Authentication-Warning: projectile.siege-engine.com: zappo set sender to eric@siege-engine.com using -f In-Reply-To: <8763ar7oiz.fsf@stupidchicken.com> X-Mailer: Evolution 2.26.1 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:115959 Archived-At: On Wed, 2009-10-07 at 01:37 -0400, Chong Yidong wrote: > > The doc header at the top of pulse.el mentions the function > > pulse-enable-integration-advice, which has been removed presumably to > > conform to Emacs "no advice in core" standard. But the comment has not > > been updated. > > > > The patch below fixes this. > > Thanks, applied. > While the feature specified which allows fcns such as goto-line to do a pulse after the line has been gone to is certainly superfluous (I don't use them), what would be he recommended way to make it possible to make such changes w/out using advice? I recognize that `beginning-of-defun' and friends discussed earlier would be the model, but I can't imagine adding such replacement features into every user facing command just in case. For the pulse case, is there an interest in snazzing up the original function list with pulsing, or is it too gratuitous to even contemplate? Eric