From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thomas Lord Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] lisp/files.el and lisp/buf-menu.el Date: Fri, 17 Jul 2009 10:56:43 -0700 Message-ID: <1247853403.6287.66.camel@dell-desktop.example.com> References: <1247777220.6302.56.camel@dell-desktop.example.com> <1247806613.6302.169.camel@dell-desktop.example.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1247853463 24944 80.91.229.12 (17 Jul 2009 17:57:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 17 Jul 2009 17:57:43 +0000 (UTC) Cc: emacs-devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 17 19:57:36 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MRrga-0003xd-C2 for ged-emacs-devel@m.gmane.org; Fri, 17 Jul 2009 19:57:32 +0200 Original-Received: from localhost ([127.0.0.1]:52216 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MRrgZ-0000FX-VS for ged-emacs-devel@m.gmane.org; Fri, 17 Jul 2009 13:57:32 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MRrfw-0007kN-R6 for emacs-devel@gnu.org; Fri, 17 Jul 2009 13:56:52 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MRrfr-0007cj-Uq for emacs-devel@gnu.org; Fri, 17 Jul 2009 13:56:52 -0400 Original-Received: from [199.232.76.173] (port=42224 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MRrfr-0007cC-N5 for emacs-devel@gnu.org; Fri, 17 Jul 2009 13:56:47 -0400 Original-Received: from smtp151.iad.emailsrvr.com ([207.97.245.151]:46214) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MRrfr-0006On-Az for emacs-devel@gnu.org; Fri, 17 Jul 2009 13:56:47 -0400 Original-Received: from relay5.relay.iad.emailsrvr.com (localhost [127.0.0.1]) by relay5.relay.iad.emailsrvr.com (SMTP Server) with ESMTP id 9687D5C02BB; Fri, 17 Jul 2009 13:56:44 -0400 (EDT) Original-Received: by relay5.relay.iad.emailsrvr.com (Authenticated sender: lord-AT-emf.net) with ESMTPSA id 036365C0328; Fri, 17 Jul 2009 13:56:43 -0400 (EDT) In-Reply-To: X-Mailer: Evolution 2.22.3.1 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:112628 Archived-At: Stefan, Thanks. For buff-menu.el how would you feel about a patch that: Declares LIST-FILES-DIRECTORY obsolete. Declares LIST-FILES-DIRECTORY to be an alias for LIST-FILES-DESCRIPTION. Otherwise renames LIST-FILES-DIRECTORY in lisp/*.el lisp/*/*.el The other one, files.el and the case of BUFFER-FILE-MODE vs. SET-AUTO-MODE: could we discuss that a little further? I get that PCL-CVS gets away with a let-binding for BUFFER-FILE-MODE but that strikes me as a kludge and a kludge with the potential to break things. I think that third party code should be free to assume that if BUFFER-FILE-MODE is not nil then it is, as the name implies, the name of a (potentially remote) file. I'm thinking about, for example, what someone might put in a mode hook in their ~/.emacs At the same time, I'm apparently not the first person that wants a mechanism to tweak what SET-AUTO-MODE does by providing an override string to use against the auto-mode alist. So, I'm still kind of fond of the files.el patch although, ultimately, of course, I defer to the maintainers. Finally, > > I'm not clear on what you suggest I do about > > coding systems. > I'm just pointing out you may want to reuse more of the code used to > open files, so it also obeys things like the -*- coding -*- tags as well > as file-coding-system-alist. I'll look into it. -t