From: Thomas Lord <lord@emf.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Karl Fogel <kfogel@red-bean.com>,
cyd@stupidchicken.com, emacs-devel@gnu.org
Subject: Re: Reviewing changes
Date: Wed, 19 Nov 2008 14:26:29 -0800 [thread overview]
Message-ID: <1227133589.5743.5.camel@dell-desktop.example.com> (raw)
In-Reply-To: <ubpwbl614.fsf@gnu.org>
One advantage of a formal review process
is that (if designed well) it creates a
record of the review -- there is accountability.
In Karl's system, if someone asks "were all
of the changes in this release reviewed?" karl
can say "Well, all the diffs were posted to a
mailing list."
In a formal system, one can say, "yes, here
is a list of who signed off on each change" and
perhaps even "here is the checklist they filled
in and the comments they gave in answer to more
general questions that are part of a review".
Would such accountability and such discipline of
practice improve quality? It would seem to
depend on the nature of the particular review
process, and of the people in the project,
wouldn't it?
-t
On Thu, 2008-11-20 at 00:12 +0200, Eli Zaretskii wrote:
> > From: Karl Fogel <kfogel@red-bean.com>
> > Cc: cyd@stupidchicken.com, emacs-devel@gnu.org
> > Date: Wed, 19 Nov 2008 17:06:07 -0500
> >
> > We don't need to have a fully-specified, formal review system to benefit
> > from more frequent informal reviews. Many projects get by on just
> > having the diff+log appear in the same email -- then the review "system"
> > is simply people reading their email. It works quite well.
>
> If there's no agreement to have a review process, I can simply ignore
> your review.
>
>
next prev parent reply other threads:[~2008-11-19 22:26 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1KvFgL-00034A-Gp@cvs.savannah.gnu.org>
2008-11-19 7:50 ` [Emacs-diffs] Changes to emacs/lisp/bookmark.el,v Karl Fogel
2008-11-19 19:17 ` Reviewing changes (was: [Emacs-diffs] Changes to emacs/lisp/bookmark.el, v) Eli Zaretskii
2008-11-19 22:06 ` Reviewing changes Karl Fogel
2008-11-19 22:12 ` Eli Zaretskii
2008-11-19 22:26 ` Thomas Lord [this message]
2008-11-20 5:21 ` Karl Fogel
2008-11-20 0:43 ` Stephen J. Turnbull
2008-11-20 6:37 ` Karl Fogel
2008-11-20 8:31 ` Stephen J. Turnbull
2008-11-20 2:13 ` Stefan Monnier
2008-11-20 4:17 ` Eli Zaretskii
2008-11-20 6:22 ` Karl Fogel
2008-11-20 14:30 ` Stefan Monnier
2008-11-20 20:19 ` Eli Zaretskii
2008-11-21 4:01 ` Stefan Monnier
2008-11-21 4:08 ` mail
2008-11-21 11:28 ` Eli Zaretskii
2008-11-21 14:32 ` Stefan Monnier
2008-11-21 15:14 ` Eli Zaretskii
2008-11-21 19:14 ` Stefan Monnier
2008-11-20 10:25 ` Yavor Doganov
2008-11-21 4:05 ` Stefan Monnier
2008-11-20 5:39 ` [Emacs-diffs] Changes to emacs/lisp/bookmark.el,v Miles Bader
2008-11-20 9:37 ` Andreas Schwab
2008-11-20 10:09 ` Miles Bader
2008-11-20 20:22 ` Eli Zaretskii
2008-11-20 20:32 ` Juanma Barranquero
2008-11-20 20:44 ` Eli Zaretskii
2008-11-21 5:38 ` Karl Fogel
2008-11-21 11:43 ` Eli Zaretskii
2008-11-23 19:11 ` martin rudalics
2008-11-24 20:20 ` Eli Zaretskii
2008-11-25 15:23 ` Karl Fogel
2008-11-25 16:25 ` martin rudalics
2008-11-25 16:25 ` martin rudalics
2008-11-25 21:07 ` Eli Zaretskii
2008-11-26 2:17 ` Stephen J. Turnbull
2008-11-27 13:41 ` martin rudalics
2008-11-27 16:35 ` Stefan Monnier
2008-11-25 21:44 ` Stefan Monnier
2008-11-21 19:29 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227133589.5743.5.camel@dell-desktop.example.com \
--to=lord@emf.net \
--cc=cyd@stupidchicken.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=kfogel@red-bean.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).