unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Benjamin Hawkes-Lewis <bhawkeslewis@googlemail.com>
Cc: Paul Pogonyshev <pogonyshev@gmx.net>, emacs-devel@gnu.org
Subject: Re: SVG support in Emacs: what happened?
Date: Fri, 19 Jan 2007 23:48:19 +0000	[thread overview]
Message-ID: <1169250499.5404.21.camel@galahad> (raw)
In-Reply-To: <E1H8289-0008Nu-WF@fencepost.gnu.org>

Richard Stallman wrote:
> It sounds like you're saying this code is not well written.
> Is that what you mean?

Ah. No. I'm very sorry if that sounded like my personal judgement on the
code, especially as I wouldn't even claim the expertise to make such a
judgement. 

My use of the adjective "hacky" was just an attempt to summarize how the
original author (Paul Pogonyshev) described the code: "Here is the first
shot.  It is extremely non-portable, hackish and ugly, but it works!"

At the time, you wrote "I don't have time to read the code":

http://lists.gnu.org/archive/html/emacs-devel/2004-09/msg00903.html

So I didn't have anything else to go on other than Paul's own verdict.

Many apologies to Paul if he likewise assumed I was taking it upon
myself to criticize his code.

> 2. If it is well written, we could add it (after the release), if we
> get legal papers from the authors.

I asked if there was "some fundamental roadblock against patching
current Emacs CVS with something like this code". Paul just said he sees
no obstacle. Back in 2004, Paul said: "I may be willing to have a try
[at creating a patch], provided that 'librsvg' usage is acceptable." As
far as I can tell from your comments in the original thread, librsvg
usage /is/ acceptable.

If that's so, the remaining questions are:

1. What does the code need to make it "portable"?

2. What makes it "ugly", other than non-portability?

3. Is Paul (or anyone else) (in 2007) "willing to have a try" at turning
it from a "first shot" into a final patch?

--
Benjamin Hawkes-Lewis

  reply	other threads:[~2007-01-19 23:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-19 10:00 SVG support in Emacs: what happened? Benjamin Hawkes-Lewis
2007-01-19 19:43 ` Paul Pogonyshev
2007-01-19 22:22 ` Richard Stallman
2007-01-19 23:48   ` Benjamin Hawkes-Lewis [this message]
2007-01-20  0:10     ` Paul Pogonyshev
2007-01-20 13:36       ` Eli Zaretskii
2007-01-20 19:48         ` Paul Pogonyshev
2007-01-20 22:38           ` Jason Rumney
2007-01-21  6:49         ` Richard Stallman
2007-01-20  7:49     ` Richard Stallman
2007-01-20 19:45       ` Paul Pogonyshev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1169250499.5404.21.camel@galahad \
    --to=bhawkeslewis@googlemail.com \
    --cc=emacs-devel@gnu.org \
    --cc=pogonyshev@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).