[sa2c@sa2c.net: pp-eval-last-sexp() does not eval last sexp]

* [sa2c@sa2c.net: pp-eval-last-sexp() does not eval last sexp]
@ 2006-11-02 21:46 Richard Stallman
  2006-11-03 14:21 ` Ramprasad
  0 siblings, 1 reply; 6+ messages in thread
From: Richard Stallman @ 2006-11-02 21:46 UTC (permalink / raw)

Would someone please install this, then ack?

------- Start of forwarded message -------
To: emacs-pretest-bug@gnu.org
From: NIIMI Satoshi <sa2c@sa2c.net>
Date: Wed, 01 Nov 2006 22:30:15 +0900
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: pp-eval-last-sexp() does not eval last sexp
X-Spam-Status: No, score=0.0 required=5.0 tests=RCVD_BY_IP autolearn=failed 
	version=3.0.4

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

pp-eval-expression() was changed to use (interactive "X") and not to
pass its argument to eval(), but pp-eval-last-sexp() is not changed.

Because of that, target sexp is not evaluted.

Here is a patch to fix the problem.

*** pp.el	19 10 2006 19:33:06 +0900	1.29
- --- pp.el	01 11 2006 22:13:37 +0900	
***************
*** 161,167 ****
      (set-syntax-table stab)
      (if arg
  	(insert (pp-to-string (eval exp)))
!       (pp-eval-expression exp))))

  ;;; Test cases for quote
  ;; (pp-eval-expression ''(quote quote))
- --- 161,167 ----
      (set-syntax-table stab)
      (if arg
  	(insert (pp-to-string (eval exp)))
!       (pp-eval-expression (eval exp)))))

  ;;; Test cases for quote
  ;; (pp-eval-expression ''(quote quote))

If emacs crashed, and you have the emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/home/sa2c/opt/emacs22/share/emacs/22.0.90/etc/DEBUG for instructions.

In GNU Emacs 22.0.90.2 (i386-unknown-freebsd6.1, GTK+ Version 2.10.6)
 of 2006-11-01 on berkeley.l.sa2c.net
X server distributor `The XFree86 Project, Inc', version 11.0.40300000
configured using `configure '--prefix=/home/sa2c/opt/emacs22' '--with-gtk''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ja_JP.UTF-8
  locale-coding-system: utf-8
  default-enable-multibyte-characters: t

Major mode: Emacs-Lisp

Minor modes in effect:
  eldoc-mode: t
  show-paren-mode: t
  which-function-mode: t
  shell-dirtrack-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  line-number-mode: t

Recent input:
o <tab> e m <tab> l i s <tab> <tab> <tab> / <tab> e 
m <tab> a <tab> i <tab> <tab> SPC <backspace> <tab> 
p p <tab> <return> C-s p p - e v a l - l a C-a C-M-n 
C-a M-x s e t - v a <tab> <return> d i f f - M-p <tab> 
s <tab> <return> " - c " <return> C-x v = C-n C-n C-n 
C-n C-n C-n C-x 0 M-x e m a <tab> <tab> C-a C-k s e 
n <tab> <tab> <M-backspace> r e p o <tab> r <tab> <tab> 
<return>

Recent messages:
20
Making completion list... [3 times]
Loading vc-cvs...done
Mark saved where search started
next-history-element: Beginning of history; no preceding item
Making completion list...
Loading diff...done
Loading vc...done
Making completion list... [3 times]
Loading emacsbug...done

- -- 
NIIMI Satoshi

_______________________________________________
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
------- End of forwarded message -------

^ permalink raw reply	[flat|nested] 6+ messages in thread