From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Using the GNU GMP Library for Bignums in Emacs Date: Fri, 6 Jul 2018 21:53:15 -0700 Organization: UCLA Computer Science Department Message-ID: <1150776f-a8fe-86a1-680b-3d1a5d582c6a@cs.ucla.edu> References: <29f933ac-a6bf-8742-66a7-0a9d6d3e5a88@disroot.org> <83bmecy6fx.fsf@gnu.org> <0d3175d8-d996-651e-b221-71978bde3a65@cs.ucla.edu> <87tvpdnzgy.fsf@tromey.com> <4c2a814f-c254-29e5-39cf-11b5f2e5c9c8@cs.ucla.edu> <87pnzzoeky.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1530939119 32739 195.159.176.226 (7 Jul 2018 04:51:59 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 7 Jul 2018 04:51:59 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 Cc: Stefan Monnier , emacs-devel@gnu.org To: Tom Tromey Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 07 06:51:55 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbfCM-0008Oj-Tn for ged-emacs-devel@m.gmane.org; Sat, 07 Jul 2018 06:51:55 +0200 Original-Received: from localhost ([::1]:60569 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fbfEU-0008T7-2x for ged-emacs-devel@m.gmane.org; Sat, 07 Jul 2018 00:54:06 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54273) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fbfDl-0008T1-HB for emacs-devel@gnu.org; Sat, 07 Jul 2018 00:53:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fbfDi-0007G5-Gj for emacs-devel@gnu.org; Sat, 07 Jul 2018 00:53:21 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:43262) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fbfDi-0007Ft-76 for emacs-devel@gnu.org; Sat, 07 Jul 2018 00:53:18 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id EC8CA1605B0; Fri, 6 Jul 2018 21:53:16 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id RR4bTr3Fa6l2; Fri, 6 Jul 2018 21:53:16 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 21B4116060E; Fri, 6 Jul 2018 21:53:16 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id SzpSavwcZr9i; Fri, 6 Jul 2018 21:53:16 -0700 (PDT) Original-Received: from [192.168.1.9] (unknown [47.154.30.119]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id BC93D1605B0; Fri, 6 Jul 2018 21:53:15 -0700 (PDT) Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECH In-Reply-To: <87pnzzoeky.fsf@tromey.com> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227029 Archived-At: Tom Tromey wrote: > I was not sure what to do with calls like: >=20 > #define lisp_h_CHECK_FIXNUM(x) CHECK_TYPE (FIXNUMP (x), Qintegerp, x) That last line should use Qfixnump, surely. > I ran this and got a big patch: >=20 > sed -i 's/INTEGERP/FIXNUMP/g' *.[ch] I doubt whether this is the best option. Often, the code should actually = be=20 checking for integers, not for fixnums. So the existing code needs to be=20 examined more carefully, with only some INTEGERP instances changed to FIX= NUMP.=20 (Code should prefer INTEGERP to FIXNUMP, for generality, but in some case= s=20 FIXNUMP will have to do.) > sed -i 's/make_number/make_fixnum/g' *.[ch] This should be OK, at least for now. At some point we may want to have=20 make_fixnum do proper overflow checking. > sed -i 's/CHECK_NUMBER/CHECK_FIXNUM/g' *.[ch] CHECK_NUMBER has always been a misnomer of course, since it excludes floa= ts. But=20 these uses need to be fixed by hand; some changed to CHECK_INTEGER, and o= thers=20 to CHECK_FIXNUM, depending on what check is wanted. In that sense this i= s like=20 the INTEGERP/FIXNUMP issue. > I wasn't sure if I should try to rename NUMBERP or NATNUMP. > On the one hand they are really checking only for fixnums. > On the other hand, the logical names seem like they'd be unwieldy. NUMBERP and NATNUMP should not exclude bignums, since their Lisp counterp= arts=20 don't. If there is a need for "fixnum or float" (not that likely) or for=20 "nonnegative fixnum" (more likely), I suggest the names FIXNUM_OR_FLOATP = and=20 FIXNATP.