From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Paul W. Rankin" via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: src/nsterm.m: fix window tabbing on macOS Date: Sun, 6 Jun 2021 14:09:53 +1000 Message-ID: <114E217D-4B4F-45B4-964F-6C3F953971B7@bydasein.com> References: <39fa782b82e274d3e9c40e934df89d68@purelymail.com> <4cf0b73bcefc7d159881d368b3a4b7f5@purelymail.com> <14A97A03-E9F8-4B6D-8E58-D29CEFA7931C@bydasein.com> <5a9c34f8-fcc2-fb5d-f726-e1ce47621ed7@gmx.at> Reply-To: "Paul W. Rankin" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29327"; mail-complaints-to="usenet@ciao.gmane.io" Cc: martin rudalics , Andrii Kolomoiets , emacs-devel@gnu.org To: Alan Third Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 06 06:11:30 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lpk8I-0007RT-CA for ged-emacs-devel@m.gmane-mx.org; Sun, 06 Jun 2021 06:11:30 +0200 Original-Received: from localhost ([::1]:47880 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lpk8G-0002fQ-R8 for ged-emacs-devel@m.gmane-mx.org; Sun, 06 Jun 2021 00:11:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59362) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpk7B-0001th-Ua for emacs-devel@gnu.org; Sun, 06 Jun 2021 00:10:21 -0400 Original-Received: from sendmail.purelymail.com ([34.202.193.197]:40810) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpk78-00089I-75 for emacs-devel@gnu.org; Sun, 06 Jun 2021 00:10:21 -0400 DKIM-Signature: a=rsa-sha256; b=hC7h9Z9EAsv/J4kiQThAXElC+0O/o2V1yxQQSRQBbiYoywCSDEPIJws2FbspKR8vEyBSuSCK6UkWXQ5/S/Yf6S0dVID5zWD8/w06dCIP31LxOhGF57UaXiiBE5jQucb0k3pFxq+uPuLMGWf3ShK4ZnJT57Uzg6bMzn7bPseBSqPsabHty1adDUmIYMtkB+nyxIT6j6ew1IA4v0e+wyrJ7JqD3icvtXfGt0IMtvW0bV+/kag4X5B3Gwj9fbewiXELwPuwKaUcvjHNciXazskQ/ghmHJYb6LM+6z2ckmFTdtsiFcK7q3UWqT0lqIJ4Cb1EqN+hddNTcF6QBsgL5dvIGA==; s=purelymail3; d=bydasein.com; v=1; bh=XVlNFHwcKbhi9n7HaUx0w81oInBnR30ZX6SfYZnFN7Y=; h=Received:From:To; DKIM-Signature: a=rsa-sha256; b=ztChDFD85A6ZB/2nbin7sdQnn2cr7WvT+nvd19l/5wVgLE6RtGKv2x/HBMhjH1vziSAXt/sjAJ4201GJLnns1lf85fMzc/6cLJPU+ffvqTMrNsd6OJH//fBsmEtqzJJjlqoiiHNlyJREQDLktnimz7YCr6VR9MYeQIfL2r/IxUdisA9xfmit31eaWtLlVnLELUNYgZl4qOd2bAuqPTeoeatEKFVzqB5Ia6DdWRdzJO85uV0di0LMOdzgfmN0GvKR1wDBRHvegSddjYSdgFSwTfDrTNM2ABZquUzU3iXdV5uzBKtCgYVl0USSAskssOGRQTTaEaio5OFldw9HEUfv2w==; s=purelymail3; d=purelymail.com; v=1; bh=XVlNFHwcKbhi9n7HaUx0w81oInBnR30ZX6SfYZnFN7Y=; h=Feedback-ID:Received:From:To; Feedback-ID: 791:353:null:purelymail X-Pm-Original-To: emacs-devel@gnu.org Original-Received: by ip-172-30-0-164.ec2.internal (JAMES SMTP Server ) with ESMTPA ID -759230212; Sun, 06 Jun 2021 04:10:01 +0000 (UTC) In-Reply-To: X-Mailer: Apple Mail (2.3654.100.0.2.22) Received-SPF: pass client-ip=34.202.193.197; envelope-from=pwr@bydasein.com; helo=sendmail.purelymail.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270458 Archived-At: > On 28 May 2021, at 6:54 pm, Alan Third wrote: >=20 > On Fri, May 28, 2021 at 10:36:07AM +0200, martin rudalics wrote: >>>> What do s-n and s-w do (which emacs function do they ultimately = call)? >>>>=20 >>>>> Repeat steps 3 and 4 few times, note how the frame height is = increased. >>>=20 >>> s-n (make-frame) >>> s-w (delete-frame) >>=20 >> Hmm... Then "the frame height" refers to the height of different >> frames? Does it always increase by the same amount? Does it ever = stop >> to do that? >=20 > Without having looked at it at all I'd imagine the problem is that the > tab-bar is an extra toolbar below the Emacs toolbar which we will need > to take into account when calculating the size of the various > components. >=20 > For example, IIRC, the height of the Emacs toolbar is calculated as > the height of the OS window minus the height of the Emacs view and the > titlebar. This is clearly not going to be right when we have an extra > widget in there. Fwiw, most native macOS app windows can show/hide their toolbar, and = when they do this, the window itself maintains overall size. However in = Emacs when toggling tool-bar-mode the window grows/shrinks in overall = size (i.e. maintains window lines). So I guess one of the questions here is whether to do these height = calculation to maintain overall window size (and thus consistency with = the OS) or to maintain visible window lines. Sorry I would like to provide more insights here but I'm still at the = very early stages of learning C.=