From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andre Spiegel Newsgroups: gmane.emacs.devel Subject: Re: Fix vc-svn.el 1.27 when using with GNU Emacs 21.4 Date: Tue, 04 Apr 2006 19:49:26 +0200 Message-ID: <1144172966.19086.33.camel@localhost> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1144172993 24233 80.91.229.2 (4 Apr 2006 17:49:53 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 4 Apr 2006 17:49:53 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 04 19:49:50 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FQpf3-0004ip-6V for ged-emacs-devel@m.gmane.org; Tue, 04 Apr 2006 19:49:49 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FQpf2-0004e8-Ok for ged-emacs-devel@m.gmane.org; Tue, 04 Apr 2006 13:49:48 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FQpeq-0004du-5C for emacs-devel@gnu.org; Tue, 04 Apr 2006 13:49:36 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FQpen-0004bc-N2 for emacs-devel@gnu.org; Tue, 04 Apr 2006 13:49:35 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FQpen-0004bZ-Ha for emacs-devel@gnu.org; Tue, 04 Apr 2006 13:49:33 -0400 Original-Received: from [193.113.160.41] (helo=mail.o2.co.uk) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FQpi7-0002sv-PQ for emacs-devel@gnu.org; Tue, 04 Apr 2006 13:53:00 -0400 Original-Received: from [89.57.150.1] (89.57.150.1) by mail.o2.co.uk (7.0.045) id 4429BF6300103F1B; Tue, 4 Apr 2006 18:49:27 +0100 Original-To: hps@intermeta.de In-Reply-To: 1143897048.6765.31.camel@forge.intermeta.de X-Mailer: Evolution 2.4.2.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:52398 Archived-At: On Sat, 2006-04-01 at 15:09 +0200, Henning Schmiedehausen wrote: > Please apply the attached patch. Its function is obvious. As > vc-do-command only returns 'nil' or 'error', the status is never 0. As a > result, vc-svn.el has been broken for a while when using with emacs > 21.4. No, vc-do-command is supposed to return the execution status, and does indeed do it, even in Emacs 21.4. I think you may be having another problem, and because vc-svn.el 1.27 ignores all errors in the call to vc-svn-command, you may not be able to see what's actually happening. In vc-svn-registered, where it says: (let ((status (condition-case nil ;; Ignore all errors. (vc-svn-command t t file "status" "-v") ;; Some problem happened. E.g. We can't find an `svn' ;; executable. We used to only catch `file-error' but when ;; the process is run on a remote host via Tramp, the error ;; is only reported via the exit status which is turned into ;; an `error' by vc-do-command. (error nil)))) (when (eq 0 status) (vc-svn-parse-status t) (eq 'SVN (vc-file-getprop file 'vc-backend))))))) try replacing (error nil) with (file-error nil) and see what kind of error message you get.