From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andre Spiegel Newsgroups: gmane.emacs.devel Subject: Re: Rewrite of vc-user-login-name Date: Wed, 25 Jan 2006 19:42:22 +0100 Message-ID: <1138214542.6634.3.camel@localhost> References: <1137946789.5032.149.camel@localhost> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1138216612 17030 80.91.229.2 (25 Jan 2006 19:16:52 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 25 Jan 2006 19:16:52 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 25 20:16:50 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1F1q8G-00011Y-42 for ged-emacs-devel@m.gmane.org; Wed, 25 Jan 2006 20:16:40 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F1qB0-0003kD-Tf for ged-emacs-devel@m.gmane.org; Wed, 25 Jan 2006 14:19:30 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1F1peY-0004Fy-9a for emacs-devel@gnu.org; Wed, 25 Jan 2006 13:45:58 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1F1peU-000464-0x for emacs-devel@gnu.org; Wed, 25 Jan 2006 13:45:57 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F1peS-00044Y-VR for emacs-devel@gnu.org; Wed, 25 Jan 2006 13:45:53 -0500 Original-Received: from [193.113.160.14] (helo=mail.o2.co.uk) by monty-python.gnu.org with esmtp (Exim 4.52) id 1F1pbI-0008QO-Cw; Wed, 25 Jan 2006 13:42:36 -0500 Original-Received: from [80.185.167.133] (80.185.167.133) by mail.o2.co.uk (7.0.045) id 438649D0007DAA14; Wed, 25 Jan 2006 18:42:23 +0000 Original-To: rms@gnu.org In-Reply-To: X-Mailer: Evolution 2.2.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:49535 Archived-At: On Tue, 2006-01-24 at 11:47 -0500, Richard M. Stallman wrote: > Here's a patch that closes a long standing issue, removing the need for > Tramp to advise vc-user-login-name. I'm not quite sure how to install > it, though: should I just remove the advice in tramp-vc.el? > > What is the cause of your doubts? > In general, updating the source is all one needs to do > for a change in the Lisp code. Occasionally one needs > to update loaddefs.el, but that's not relevant here. I wasn't sure how the advice mechanism actually works, and I thought that maybe my change could have forced people to recompile Emacs to make it work. Also, I'm not the maintainer of tramp-vc.el, so I thought I'd better ask. I will install the changes now and comment out the defadvice in tramp-vc.el. Michael Albinus can then have a closer look.