From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Roland Winkler" Newsgroups: gmane.emacs.devel Subject: Re: master 45a1653: ; Fix last change to bibtex.el Date: Wed, 18 Nov 2020 08:13:15 -0600 Message-ID: <11259.90054.698979.24501@gargle.gargle.HOWL> References: <20201116233108.21940.22514@vcs0.savannah.gnu.org> <20201116233110.4E83E209DE@vcs0.savannah.gnu.org> <87k0ujthyb.fsf@gnu.org> <875z6226fg.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36643"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Glenn Morris , Francesco =?utf-8?Q?Potort=C3?==AC , emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 18 15:14:08 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kfODm-0009OD-Lz for ged-emacs-devel@m.gmane-mx.org; Wed, 18 Nov 2020 15:14:06 +0100 Original-Received: from localhost ([::1]:46474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfODl-0008Ee-OA for ged-emacs-devel@m.gmane-mx.org; Wed, 18 Nov 2020 09:14:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46056) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfOD3-0007nI-KG for emacs-devel@gnu.org; Wed, 18 Nov 2020 09:13:21 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53787) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfOD1-0000Hf-UB; Wed, 18 Nov 2020 09:13:19 -0500 Original-Received: from [2602:30a:2e52:d720:65b7:1416:12e7:8bfb] (port=50454 helo=regnitz) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1kfOCz-0000Q8-4W; Wed, 18 Nov 2020 09:13:17 -0500 In-Reply-To: <875z6226fg.fsf@tcd.ie> X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259343 Archived-At: On Wed Nov 18 2020 Basil L. Contovounesios wrote: > > Why local at all by default? All other BibTeX customizations by > > default apply to all BibTeX buffers. > > Good point. I've now reverted it. Thinking once more about this I am not sure this is the best approach in the first place. The way bibtex-unify-case-convert is defined now as a function, it should get a :rsiky tag, it should not be used as a file-local variable. On the other hand, the most common scenario I can think of for situations, where one wants to have buffer-local values for bibtex-unify-case-convert is via file-local settings. So I think it makes more sense that bibtex-unify-case-convert should be one of the symbols identity, downcase, capitalize or upcase. And these symbols are allowed as buffer-local variables. (I cannot think of a useful scenario beyond this that would justify a user-defined function. Am I missing something?) >From a different perspective, if bibtex-unify-case-convert was a variable holding a function name, the variable name should be something like bibtex-unify-case-convert-function.