Re: encoding and content-length for url-http.el

["Mark A. Hershberger" <mah@everybody.org>]

[-- Attachment #1.1.1: Type: text/plain, Size: 880 bytes --]

On Fri, 2005-06-10 at 11:46 -0400, Mark A. Hershberger wrote:
> Could I get input on the following patch before I apply it?  The first
> part (using string-bytes instead of length) seems like a no-brainer.
> The second part, I'm less sure about.

Full patch included this time.

And a fuller explanation.

I've come across circumstances where it appears that url-http.el isn't
doing the right thing.  For instance, I'm using xml-rpc to post weblog
entries that contain unicode quotes.  I need these changes to get it to
do the right thing.  For (a little) more information, see
<http://elisp.info/archive/80614312>.

-- 
http://mah.everybody.org/weblog/
GPG Fingerprint: 7E15 362D A32C DFAB E4D2  B37A 735E F10A 2DFC BFF5
More people are killed every year by pigs than by sharks, which shows
you how good we are at evaluating risk. -- Bruce Schneier






[-- Attachment #1.1.2: tmp.diff --]
[-- Type: text/x-patch, Size: 1618 bytes --]

Index: lisp/url/url-http.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/url/url-http.el,v
retrieving revision 1.14
diff -u -r1.14 url-http.el
--- lisp/url/url-http.el	4 Jun 2005 18:37:16 -0000	1.14
+++ lisp/url/url-http.el	10 Jun 2005 18:45:05 -0000
@@ -259,7 +259,7 @@
 	   (if url-request-data
 	       (concat
 		"Content-length: " (number-to-string
-				    (length url-request-data))
+				    (string-bytes url-request-data))
 		"\r\n"))
 	   ;; End request
 	   "\r\n"
@@ -1066,6 +1066,9 @@
 	(set-process-buffer connection buffer)
 	(set-process-sentinel connection 'url-http-end-of-document-sentinel)
 	(set-process-filter connection 'url-http-generic-filter)
+	(set-process-coding-system connection
+				   (detect-coding-string url-request-data t)
+				   url-request-coding-system)
 	(process-send-string connection (url-http-create-request url))))
     buffer))
 
Index: lisp/url/url-vars.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/url/url-vars.el,v
retrieving revision 1.9
diff -u -r1.9 url-vars.el
--- lisp/url/url-vars.el	9 Feb 2005 15:50:36 -0000	1.9
+++ lisp/url/url-vars.el	10 Jun 2005 18:45:05 -0000
@@ -218,6 +218,8 @@
 
 (defvar url-request-data nil "Any data to send with the next request.")
 
+(defvar url-request-coding-system 'binary "The coding system to use for the request.")
+
 (defvar url-request-extra-headers nil
   "A list of extra headers to send with the next request.
 Should be an assoc list of headers/contents.")

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel