* __GNUC__ == "mingw" in w32.c
@ 2005-06-08 16:05 Juanma Barranquero
2005-06-08 16:46 ` jasonr
2005-06-08 18:04 ` Eli Zaretskii
0 siblings, 2 replies; 3+ messages in thread
From: Juanma Barranquero @ 2005-06-08 16:05 UTC (permalink / raw)
>From w32.c:
#ifdef _MSC_VER
#define COMPILER_NAME "msvc"
#else
#ifdef __GNUC__
#define COMPILER_NAME "mingw"
#else
#define COMPILER_NAME "unknown"
#endif
#endif
Is there any reason to consider any _GNUC_ compiler as "mingw"?
Wouldn't be more sensible to use
#ifdef _MSC_VER
#define COMPILER_NAME "msvc"
#else
#ifdef __MINGW32__
#define COMPILER_NAME "mingw"
#else
#ifdef __GNUC__
#define COMPILER_NAME "gcc"
#else
#define COMPILER_NAME "unknown"
#endif
#endif
#endif
or some such?
--
/L/e/k/t/u
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: __GNUC__ == "mingw" in w32.c
2005-06-08 16:05 __GNUC__ == "mingw" in w32.c Juanma Barranquero
@ 2005-06-08 16:46 ` jasonr
2005-06-08 18:04 ` Eli Zaretskii
1 sibling, 0 replies; 3+ messages in thread
From: jasonr @ 2005-06-08 16:46 UTC (permalink / raw)
Cc: emacs-devel
Quoting Juanma Barranquero <lekktu@gmail.com>:
> >From w32.c:
>
> #ifdef _MSC_VER
> #define COMPILER_NAME "msvc"
> #else
> #ifdef __GNUC__
> #define COMPILER_NAME "mingw"
> #else
> #define COMPILER_NAME "unknown"
> #endif
> #endif
>
> Is there any reason to consider any _GNUC_ compiler as "mingw"?
It is the only version of GCC supported by the w32 build.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: __GNUC__ == "mingw" in w32.c
2005-06-08 16:05 __GNUC__ == "mingw" in w32.c Juanma Barranquero
2005-06-08 16:46 ` jasonr
@ 2005-06-08 18:04 ` Eli Zaretskii
1 sibling, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2005-06-08 18:04 UTC (permalink / raw)
Cc: emacs-devel
> Date: Wed, 8 Jun 2005 18:05:19 +0200
> From: Juanma Barranquero <lekktu@gmail.com>
>
> >From w32.c:
>
> #ifdef _MSC_VER
> #define COMPILER_NAME "msvc"
> #else
> #ifdef __GNUC__
> #define COMPILER_NAME "mingw"
> #else
> #define COMPILER_NAME "unknown"
> #endif
> #endif
>
> Is there any reason to consider any _GNUC_ compiler as "mingw"?
As Jason points out, this is the only GCC port supported by the w32
build.
> Wouldn't be more sensible to use
>
> #ifdef _MSC_VER
> #define COMPILER_NAME "msvc"
> #else
> #ifdef __MINGW32__
> #define COMPILER_NAME "mingw"
> #else
> #ifdef __GNUC__
> #define COMPILER_NAME "gcc"
> #else
> #define COMPILER_NAME "unknown"
> #endif
> #endif
> #endif
>
> or some such?
While this shouldn't hurt, I don't think it's necessary.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-06-08 18:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-06-08 16:05 __GNUC__ == "mingw" in w32.c Juanma Barranquero
2005-06-08 16:46 ` jasonr
2005-06-08 18:04 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).