From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Andre Spiegel Newsgroups: gmane.emacs.devel Subject: Re: patch for documentation about version control Date: Thu, 11 Nov 2004 12:55:17 +0100 Message-ID: <1100174117.3428.194.camel@localhost> References: <87vfce289d.fsf@floss.red-bean.com> <1100078556.3428.151.camel@localhost> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1100174162 1284 80.91.229.6 (11 Nov 2004 11:56:02 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 11 Nov 2004 11:56:02 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 11 12:55:52 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CSDYM-0005a9-00 for ; Thu, 11 Nov 2004 12:55:52 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CSDgp-00057M-JE for ged-emacs-devel@m.gmane.org; Thu, 11 Nov 2004 07:04:35 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CSDge-00056x-JS for emacs-devel@gnu.org; Thu, 11 Nov 2004 07:04:24 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CSDgd-00056S-JR for emacs-devel@gnu.org; Thu, 11 Nov 2004 07:04:23 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CSDgd-00056P-E7 for emacs-devel@gnu.org; Thu, 11 Nov 2004 07:04:23 -0500 Original-Received: from [193.113.160.16] (helo=mail.o2.co.uk) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CSDXh-0005Lo-Ox for emacs-devel@gnu.org; Thu, 11 Nov 2004 06:55:10 -0500 Original-Received: from [217.231.175.76] (217.231.175.76) by mail.o2.co.uk (7.0.028) (authenticated as andre.spiegel@o2online.de) id 4171E5880052E5F4; Thu, 11 Nov 2004 11:55:08 +0000 Original-To: Thien-Thi Nguyen In-Reply-To: X-Mailer: Evolution 2.0.2 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:29738 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:29738 On Wed, 2004-11-10 at 11:43 -0500, Thien-Thi Nguyen wrote: > as you can see, the patch does not actually change anything currently > defined in vc-rcs.el; it is purely additive. btw, ORIG => 1.41. if > there is a better way to get a file's per-line version info w/o parsing > the masterfile, please let me know in the next few days. It is fine to read information directly from the RCS master file, VC has been doing that all along. What about the efficiency of your parser, though? How long does it take to construct this full parse tree for a large RCS master with many revisions? Since we do need the line-by-line information, I guess there's not much else we can do except to go for this full parse tree. The code needs to be better commented. It needs to explain in readable English what you are doing at least in each major step. "korg / grok / decorate" is not enough. This comment: ;; cvs envy (for now -- usurpers enjoy the dish best served cold) is also not particularly helpful. Finally, some of your variable names need to be improved. A name like "p-act-ract" or "r/d/a" is worse than a single-letter identifier because the reader is left wondering what at all you are talking about. Please give meaningful names at least to these two variables/properties. Please send me an updated version of your patch. There is no need to do this via emacs-devel, we can sort this out in personal mail. Thanks for working on this; having vc-annotate work with RCS will be a very worthwhile improvement.