From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mariano Montone Newsgroups: gmane.emacs.devel Subject: Re: Integrate my package into Emacs Date: Thu, 26 May 2022 09:47:45 -0300 Message-ID: <10aecb7a-8822-9ca6-80d8-7dd78251db12@gmail.com> References: <3a9397d6-7d11-f9f7-bcf6-03ccfa83e67f@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32971"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 26 14:49:10 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nuCvO-0008Nh-Di for ged-emacs-devel@m.gmane-mx.org; Thu, 26 May 2022 14:49:10 +0200 Original-Received: from localhost ([::1]:44560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nuCvN-0006IW-7y for ged-emacs-devel@m.gmane-mx.org; Thu, 26 May 2022 08:49:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52980) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuCu8-0004ky-B8 for emacs-devel@gnu.org; Thu, 26 May 2022 08:47:52 -0400 Original-Received: from mail-oi1-x232.google.com ([2607:f8b0:4864:20::232]:42617) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nuCu6-00088u-7r for emacs-devel@gnu.org; Thu, 26 May 2022 08:47:51 -0400 Original-Received: by mail-oi1-x232.google.com with SMTP id q10so1948126oia.9 for ; Thu, 26 May 2022 05:47:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=OC5m2OhgOqEVlNnG/nUfsDhiZI3YqjKYMEFSSq5beWE=; b=S8skTlaZt6zU2PI90s2itAnNG0aA4+KN+31+vv45EyufzbdJpMUHLVM6zBesChYHLK ufl499ABCTC486ncyj7VpnwwcqDy7Er8wxnwWv8SmhfOeSmyZEbF1h6r1AedIAq6XdEC S2i6+XLQfmkL/EU1vT9iMtbHXRRI7y2wjYLRDjZYzESB23/4IZ/uvhbBWs7JXIVbC5Xj AbMYQI2Cz+nXglqtf5aQBY7Pn575hrbHUJqBFIHl98QT8jbXnDAhYIec7fwstbS3TGzg 1FYSSS77L6jAqNvjw3POWJeOWbIJ3YnZbu2ip5FE1roJBr1fJycWzCQQ2ERaFx9aqcKk jpBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=OC5m2OhgOqEVlNnG/nUfsDhiZI3YqjKYMEFSSq5beWE=; b=f0rtWcjEqf2uMWMsr6UINUwjG+CxDSJvk8oEB4fQpWB7FYIw79ZYCUIZZSkOyh26oZ bJt/oRh4M7iMJkzerjIB/I5NUgJmLzv9K/kR2ueaagAfeRIP5bdSzuXCvMYIaxpNcYOT fhA1qbJW/K827Tgz4SjLee4YA7H3sPkCOfOEtt/DSf0AcTH41p7jIWBCoAqbK8KzPSQr a86JYoRXzcblJ3Uw3m3XgP1pk7IoSs8DhHYKILew3wHuIJ8ZkqYfBcVLQ0eVjZUr9Obp E5ab2C2zsCEDXC7rBo7R+X3ip8/IIGQOucX7K/pdk3b1YBs5g4uEEcX/pqheASodtQ9X hm4g== X-Gm-Message-State: AOAM530+UL/l39Opl+GsQDt2wgEq1zNdrgyIVldcVveS4Gv4aoifD2lB VOg3K0g14o86dzAOTZXj1BoWBb0pHSHGNg== X-Google-Smtp-Source: ABdhPJxwycEaio8BU3qfFmH5S9PhDdq6PDyuK2+RvpxlDMVUMJYYQP+3u6AqstXQkbkmh7wXH8mFrw== X-Received: by 2002:a05:6808:dc3:b0:2ef:86e7:a0b with SMTP id g3-20020a0568080dc300b002ef86e70a0bmr994411oic.48.1653569268565; Thu, 26 May 2022 05:47:48 -0700 (PDT) Original-Received: from [192.168.0.11] ([190.17.4.55]) by smtp.googlemail.com with ESMTPSA id k10-20020a05687015ca00b000e686d1386fsm593092oad.9.2022.05.26.05.47.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 May 2022 05:47:47 -0700 (PDT) Content-Language: es-CO In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::232; envelope-from=marianomontone@gmail.com; helo=mail-oi1-x232.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290269 Archived-At: Hi Stefan, I've applied your changes: https://github.com/mmontone/emacs-inspector/commit/d7c5e7cb292eb23e66de78ae12ede15323bd0531 Do you think it is acceptable now? About the inspect-last-sexp function, I changed the comment, but where you thinking about some more explicit name for the function? Like: eval-last-sexp-and-inspect , or something like that ... Let me know if you think there's anything else that needs changing. Mariano El 24/5/22 a las 19:59, Stefan Monnier escribió: > Mariano Montone [2022-05-24 16:22:37] wrote: >> I've signed the papers and applied your changes. > Yay! > >> What would be the next step? Can you have a look again at my package let >> me know? > I just pushed it to `elpa.git`. It won't appear on GNU ELPA yet, tho > because your copyright line still has your name. You'll have to change > it to the FSF (and after that (or at the same time) change the > `Version:` to make a "new" release from that). > > See patch below which includes the copyright change along with various > FIXME comments (meant to be read rather than applied. If you have any > questions/answers about those FIXMEs, feel free to send them right here). > > > Stefan > > > diff --git a/README.md b/README.md > index 06a6d142be..743dfcd604 100644 > --- a/README.md > +++ b/README.md > @@ -6,6 +6,11 @@ Inspector tool for Emacs Lisp objects. > > Similar to inspectors available for Smalltalk and Common Lisp, but for Emacs Lisp. > > + > DEMO VIDEO: https://drive.google.com/file/d/1808JlDM0q-aW4woZQBscatxp6omIR2j8/view > > ![emacs-inspector.png](emacs-inspector.png "Emacs Inspector") > diff --git a/inspector.el b/inspector.el > index f32416198d..d011bc6ce0 100644 > --- a/inspector.el > +++ b/inspector.el > @@ -1,6 +1,6 @@ > ;;; inspector.el --- Tool for inspection of Emacs Lisp objects. -*- lexical-binding: t -*- > > -;; Copyright (C) 2021 Mariano Montone > +;; Copyright (C) 2021-2022 Free Software Foundation, Inc. > > ;; Author: Mariano Montone > ;; URL: https://github.com/mmontone/emacs-inspector > @@ -616,6 +616,8 @@ When PRESERVE-HISTORY is T, inspector history is not cleared." > > ;;;###autoload > (defun inspect-last-sexp () > + ;; FIXME: According to the code, this doesn't inspect the "sexp before point" > + ;; but the value returned by the evaluation of that sexp. > "Evaluate and inspect sexp before point." > (interactive) > (let ((result (eval (eval-sexp-add-defvars (elisp--preceding-sexp)) lexical-binding))) > @@ -623,6 +625,9 @@ When PRESERVE-HISTORY is T, inspector history is not cleared." > > ;;-- Inspection from Emacs debugger > > +;; FIXME: Please use the "inspect-" namespace instead of stepping onto > +;; the debugger's namespace, e.g. `inspect-debugger-locals'. > + > ;;;###autoload > (defun debugger-inspect-locals () > "Inspect local variables of the frame at point in debugger backtrace." > @@ -683,13 +688,9 @@ When PRESERVE-HISTORY is T, inspector history is not cleared." > :vert-only t) > map)) > > -(add-hook 'inspector-mode-hook > - (lambda () > - (setq-local tool-bar-map inspector-tool-bar-map))) > - > -;; Better define and use a major mode?: > -(define-derived-mode inspector-mode fundamental-mode > - "Inspector mode") > +(define-derived-mode inspector-mode fundamental-mode "Inspector" > + "Major mode for the Emacs Lisp Inspector." > + (setq-local tool-bar-map inspector-tool-bar-map)) > > (provide 'inspector) > >