From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Alfred M. Szmidt" Newsgroups: gmane.emacs.devel Subject: Re: [rmail-mbox-branch]: inital problems Date: Sat, 18 Sep 2004 02:09:54 +0200 Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: <1095466194.208044.30690.nullmailer@Update.UU.SE> References: <1095204498.515091.23142.nullmailer@Update.UU.SE> <87fz5irvyv.fsf@oak.pohoyda.family> <1095354800.926412.7139.nullmailer@Update.UU.SE> NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1095466242 30668 80.91.229.6 (18 Sep 2004 00:10:42 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 18 Sep 2004 00:10:42 +0000 (UTC) Cc: alexander.pohoyda@gmx.net, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 18 02:10:30 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1C8So9-0005e4-00 for ; Sat, 18 Sep 2004 02:10:30 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1C8Stu-0004ov-5p for ged-emacs-devel@m.gmane.org; Fri, 17 Sep 2004 20:16:26 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1C8Stn-0004oq-Lm for emacs-devel@gnu.org; Fri, 17 Sep 2004 20:16:19 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1C8Stl-0004oe-Tw for emacs-devel@gnu.org; Fri, 17 Sep 2004 20:16:19 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1C8Stl-0004ob-Rt for emacs-devel@gnu.org; Fri, 17 Sep 2004 20:16:17 -0400 Original-Received: from [130.238.4.153] (helo=pernis.its.uu.se) by monty-python.gnu.org with esmtp (Exim 4.34) id 1C8Snk-0005k7-07; Fri, 17 Sep 2004 20:10:04 -0400 Original-Received: by pernis.its.uu.se (Postfix, from userid 205) id 0CA4A846; Sat, 18 Sep 2004 02:10:02 +0200 (MSZ) Original-Received: from pernis.its.uu.se(127.0.0.1) by pernis.its.uu.se via virus-scan id s472; Sat, 18 Sep 04 02:09:56 +0200 Original-Received: from Psilocybe.Update.UU.SE (Psilocybe.Update.UU.SE [130.238.19.25]) by pernis.its.uu.se (Postfix) with ESMTP id 5C23D16B; Sat, 18 Sep 2004 02:09:55 +0200 (MSZ) Original-Received: from localhost (localhost [127.0.0.1]) by Psilocybe.Update.UU.SE (Postfix) with ESMTP id 390FC38012; Sat, 18 Sep 2004 02:09:55 +0200 (CEST) Original-Received: from Psilocybe.Update.UU.SE ([127.0.0.1]) by localhost (Psilocybe [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 07139-07; Sat, 18 Sep 2004 02:09:54 +0200 (CEST) Original-Received: from Update.UU.SE (Lem.Update.UU.SE [130.238.19.73]) by Psilocybe.Update.UU.SE (Postfix) with SMTP; Sat, 18 Sep 2004 02:09:54 +0200 (CEST) Original-Received: (nullmailer pid 30691 invoked by uid 30270); Sat, 18 Sep 2004 00:09:54 -0000 Original-To: rms@gnu.org In-reply-to: (message from Richard Stallman on Fri, 17 Sep 2004 19:22:57 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:27213 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:27213 It would be nice if the new rmail would report an error if it is trying to open a old mailbox. Right now it just assumes that it knows what it is doing, and will barf with a babyl formated mailbox. How about this? I don't like it, it does the check far far to late. It should do it before switching to any modes. I was thinking something more along the lines of: --- rmail.el 23 Feb 2003 00:33:25 -0000 1.368.2.5 +++ rmail.el 18 Sep 2004 00:08:34 -0000 @@ -684,16 +685,16 @@ If `rmail-display-summary' is non-nil, m (find-file-noselect file-name)))) (if (eq major-mode 'rmail-edit-mode) (error "Exit Rmail Edit mode before getting new mail")) + ;; If file starts like a Babyl file, reject it. + (if (looking-at "BABYL OPTIONS:") + (error "This is a BABYL file; use M-x unrmail to convert it")) (if (and existed (> (buffer-size) 0)) ;; Buffer not new and not empty; ensure in proper mode, but that's all. (or (eq major-mode 'rmail-mode) (progn (rmail-mode-2) (setq run-mail-hook t))) (setq run-mail-hook t) - (rmail-mode-2) - ;; Convert all or part to Babyl file if possible. -;;; (rmail-convert-file) - (goto-char (point-max))) + (rmail-mode-2)) ;; As we have read a file by raw-text, the buffer is set to ;; unibyte. We must make it multibyte if necessary. (if (and rmail-enable-multibyte