From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Dhruva Krishnamurthy" Newsgroups: gmane.emacs.devel Subject: Re: addpm.c: DdeConnect() without timeout Date: Mon, 03 May 2004 17:05:27 +0530 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <1083584127.9663.185530980@webmail.messagingengine.com> References: <1083564435.20498.185520391@webmail.messagingengine.com> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1083585494 29887 80.91.224.253 (3 May 2004 11:58:14 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 3 May 2004 11:58:14 +0000 (UTC) Cc: Emacs Devel Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Mon May 03 13:58:06 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BKc5G-0003yn-00 for ; Mon, 03 May 2004 13:58:06 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BKc5G-0006eq-00 for ; Mon, 03 May 2004 13:58:06 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BKc2N-0005C3-Tb for emacs-devel@quimby.gnus.org; Mon, 03 May 2004 07:55:07 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1BKbuH-00022A-QI for emacs-devel@gnu.org; Mon, 03 May 2004 07:46:45 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1BKbm4-0008B1-5A for emacs-devel@gnu.org; Mon, 03 May 2004 07:38:48 -0400 Original-Received: from [66.111.4.26] (helo=out2.smtp.messagingengine.com) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BKbjM-0007lU-V3; Mon, 03 May 2004 07:35:29 -0400 Original-Received: from server2.messagingengine.com (server2.internal [10.202.2.133]) by mail.messagingengine.com (Postfix) with ESMTP id BFD66AE5239; Mon, 3 May 2004 07:35:27 -0400 (EDT) Original-Received: by server2.messagingengine.com (Postfix, from userid 99) id EDC96846EA; Mon, 3 May 2004 07:35:27 -0400 (EDT) Content-Disposition: inline X-Mailer: MIME::Lite 1.3 (F2.71; T1.001; A1.51; B2.12; Q2.03) Original-To: "Jason Rumney" X-Sasl-Enc: U4mRto0FGbJLQw1Jup6hmw 1083584127 In-Reply-To: X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:22609 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:22609 On Mon, 03 May 2004 06:45:15 +0000, "Jason Rumney" said: > "Dhruva Krishnamurthy" writes: > > face the same problem of addpm.exe getting > > stuck duing "nmake (gmake) install". > > I found that it is getting stuck in DdeConnect(). I am not aware of DDE > > mechanism but feel we should have a time out. Since "addpm.exe" is trivia > > and does not affect the working of GNU Emacs, the install should progress > > even if "addpm.exe" fails. > If you can find where in the addpm code it is failing, we can catch > whatever problem it is and do something appropriate. > > Could it be due to access rights to the Start Menu or registry? I think it was due to some registry corruption, I am not sure of what though. I ran a registry cleaning utility. I am now able to run "addpm.exe" and it works as it used to earlier. So, there is no problem. However, this is the second time I am facing this problem and I feel we should have a time out mechanism if supported by DdeConnect(). There is 1 call to DdeConnect() in addpm.c at line:184. It gets stuck there when I faced the problem. Calls to DdeInitialize() returns a successfull code. It might be a good idea to check that too to make it a little more robust. Ex: if(DMLERR_NO_ERROR!=DdeInitialize()) return(1); // Some non zero error value -dhruva ________________________________________ Dhruva Krishnamurthy Proud FSF member: #1935 http://schemer.fateback.com/