From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: Andre Spiegel <spiegel@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: vc-diff vs cvs-mode-diff
Date: Fri, 12 Mar 2004 20:53:06 +0100
Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org
Message-ID: <1079121186.5425.239.camel@localhost>
References: <u8yi79zoa.fsf@gnu.org>
	<jwvad2m89me.fsf-monnier+emacs@asado.iro.umontreal.ca>
	<uy8q6exv2.fsf@gnu.org>
NNTP-Posting-Host: deer.gmane.org
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
X-Trace: sea.gmane.org 1079135516 22686 80.91.224.253 (12 Mar 2004 23:51:56 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Fri, 12 Mar 2004 23:51:56 +0000 (UTC)
Cc: emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Sat Mar 13 00:51:45 2004
Return-path: <emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org>
Original-Received: from quimby.gnus.org ([80.91.224.244])
	by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 1B1wRN-0006wC-00
	for <emacs-devel@deer.gmane.org>; Sat, 13 Mar 2004 00:51:45 +0100
Original-Received: from monty-python.gnu.org ([199.232.76.173])
	by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian))
	id 1B1wRM-0007MU-01
	for <emacs-devel@quimby.gnus.org>; Sat, 13 Mar 2004 00:51:45 +0100
Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.30)
	id 1B1vz5-0000rv-T2
	for emacs-devel@quimby.gnus.org; Fri, 12 Mar 2004 18:22:31 -0500
Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1B1vxv-0000hb-LK
	for emacs-devel@gnu.org; Fri, 12 Mar 2004 18:21:19 -0500
Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1B1tOl-0004pD-P6
	for emacs-devel@gnu.org; Fri, 12 Mar 2004 15:37:24 -0500
Original-Received: from [193.113.160.15] (helo=mail.o2.co.uk)
	by monty-python.gnu.org with esmtp (Exim 4.30)
	id 1B1siW-00071x-12; Fri, 12 Mar 2004 14:53:12 -0500
Original-Received: from [217.81.121.15] (217.81.121.15) by mail.o2.co.uk (7.0.020)
	(authenticated as 01792247376@o2online.de)
	id 4045BD2F0036D37F; Fri, 12 Mar 2004 19:53:34 +0000
Original-To: sds@gnu.org
In-Reply-To: <uy8q6exv2.fsf@gnu.org>
X-Mailer: Ximian Evolution 1.4.5 
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org
Xref: main.gmane.org gmane.emacs.devel:20363
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:20363

On Fri, 2004-03-12 at 19:14, Sam Steingold wrote:

> how about moving vc-version-backup-file to vc-common.el and loading it
> into both pcvs and vc?

The code that handles version backups (file.~ver~) is already in
vc-hooks.el, which is always loaded.  The code to actually use this in a
diff operation is almost trivial, and is currently in vc-diff-internal
(vc.el).

I think it would be much easier to simply duplicate this part in pcvs. 
Or else, just move vc-diff-internal into vc-hooks.el and use that from
pcvs.

But how to actually do it is Stefan's call.  I just don't think it
warrants a new .el file.