From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: Treesit Regression In ec4d29c4494f32acf0ff7c5632a1d951d957f084 Date: Sat, 9 Sep 2023 22:26:47 -0700 Message-ID: <107166BF-6EC2-4D13-9BA4-A6C0DE1CA565@gmail.com> References: <87r0n7dt34.fsf@dfreeman.email> <68CFCC60-F71F-41E3-AF2A-E78E00EB3FD2@gmail.com> <8734zm4qin.fsf@dfreeman.email> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13600"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: Danny Freeman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 10 07:27:53 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qfCzB-0003M2-85 for ged-emacs-devel@m.gmane-mx.org; Sun, 10 Sep 2023 07:27:53 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfCyO-0006Oq-JS; Sun, 10 Sep 2023 01:27:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfCyM-0006Oc-Pr for emacs-devel@gnu.org; Sun, 10 Sep 2023 01:27:02 -0400 Original-Received: from mail-oo1-xc30.google.com ([2607:f8b0:4864:20::c30]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qfCyK-0002Qu-8d for emacs-devel@gnu.org; Sun, 10 Sep 2023 01:27:02 -0400 Original-Received: by mail-oo1-xc30.google.com with SMTP id 006d021491bc7-5734b893a11so2227109eaf.1 for ; Sat, 09 Sep 2023 22:26:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694323619; x=1694928419; darn=gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=iXBTDJtPEso2rR3gDwhLZSPFI2MOnZv1YeFf9Ti5mNQ=; b=niAKNiKQUhdi343Lm8NFYHONcBnsckzLGxMGxVSyiseXFQmw8n2ZxRy8hyz5K9k71Q +DQpyoDkXuQPYwd23s9T2kMKf2VVQASdaa2IR1L7Qyz4eHMPZR9mEnTmqda7IsFS+ryO Z1kpb+GmCjnrAkIZ42pjVpthS+NNG+3XEUtKDhKFXeDDMioouElEsjB07CFk9/HcIPGf XtYcEdPpD5bnYnhJRW7WuVcj9AW465JPF8R2Lye3cmie+0m5qRGieFRixEwCn/WBVE41 hXh8OzbXzgp6O09r2zA4NzxfTqvqtY+wy50AK+qrcaCTFURt/Bv6NV30bpiDDWBFQwTN RAxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694323619; x=1694928419; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iXBTDJtPEso2rR3gDwhLZSPFI2MOnZv1YeFf9Ti5mNQ=; b=o84W4CSiHegXcddKtNR0m6XGojeyuGbMYOPTuYorCpF9G7glGwiMQCLUMeUNHmAIXO aT67soeSEOo5tqt6mPZpdu2t1/8J7bLfI04vkdKUOMjfiYHxzef0MK7dztWwk9mSlCbY gSrYKQBj+PsvQqYWV319W7V9zVNoKMA6XVBwKpiqk0sobNHH/wW8sBtQlTRpjNe1DVq0 ag1iaaJkeOTAxB1FNzwOu+Dg1o/cWjYkrK5ZCWzv5wGbDgw3dlVMFkyluzfkE7wqHWw9 5PYtaKFTwhpBSkTVX7KxM5eeT9rGhLRXWgYlc/byqlDXA5SRAYROK8Ub3wcsvWUGJur7 PHpw== X-Gm-Message-State: AOJu0YwbtXXDyZKFHlMHMsW6tUwvn9SR03uqBfPQY/CaiBFN3BA4nJov 9mnlDeVl1O4GIuSpHMVQMRAhhS5L5nI= X-Google-Smtp-Source: AGHT+IEM20ET/FPYV5oD/pnyNwdqrJ76OlvMNBrsq5eNKTXvhwBtwVwq0OzFMtCvgY0+uzCttjd48g== X-Received: by 2002:a05:6871:528b:b0:1d5:b4a0:dd3e with SMTP id hu11-20020a056871528b00b001d5b4a0dd3emr209298oac.31.1694323618732; Sat, 09 Sep 2023 22:26:58 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id m21-20020a638c15000000b005697e8cc5f3sm3313927pgd.22.2023.09.09.22.26.58 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 09 Sep 2023 22:26:58 -0700 (PDT) In-Reply-To: <8734zm4qin.fsf@dfreeman.email> X-Mailer: Apple Mail (2.3731.700.6) Received-SPF: pass client-ip=2607:f8b0:4864:20::c30; envelope-from=casouri@gmail.com; helo=mail-oo1-xc30.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310433 Archived-At: > On Sep 9, 2023, at 9:00 PM, Danny Freeman = wrote: >=20 >=20 > Yuan Fu writes: >>=20 >> Hmmm, I can=E2=80=99t reproduce this. I=E2=80=99m getting >>=20 >> Matched rule: ((parent-is "source") parent-bol 0) >> Matched rule: (clojure-ts--match-expression-in-body parent 2) >>=20 >> The commit you pointed to does change treesit-node-parent, so it does = match with parent-is matcher not working. >>=20 >> Might be because I recently upgraded to a newer tree-sitter library. = If you compile with the newest tree-sitter build (from their repo), do = you still see this problem? >=20 > Before I was just using whatever tree-sitter version my distro = packages. > Apparently v0.20.8 (built from the git tag of the same name) >=20 > I tried compiling with this version > = https://github.com/tree-sitter/tree-sitter/commit/524bf7e2c664d4a5dbd0c20d= 4d10f1e58f99e8ce >=20 > which at the time of writing is the latest, and still experience the > same problem. I also made sure to re-compile my grammars. >=20 > I may have done something wrong though when building. I'm > going to try to build using a more traditional process rather than = with > nix and see if that helps. >=20 > Thank you, > --=20 > Danny Freeman I take that back. It is indeed caused by that commit. I just had a wrong = Emacs build when testing. In that commit, = ts_tree_cursor_goto_first_child_for_byte seem to be the problem. Yuan=