From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Chong Yidong" Newsgroups: gmane.emacs.devel Subject: Change in fill-nobreak-predicate Date: Fri, 4 Feb 2005 19:43:55 -0500 (EST) Message-ID: <1066.219.74.2.152.1107564235.squirrel@219.74.2.152> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: sea.gmane.org 1107564329 26282 80.91.229.2 (5 Feb 2005 00:45:29 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 5 Feb 2005 00:45:29 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 05 01:45:29 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1CxE4j-0006AF-3h for ged-emacs-devel@m.gmane.org; Sat, 05 Feb 2005 01:45:25 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1CxEIL-00062K-QN for ged-emacs-devel@m.gmane.org; Fri, 04 Feb 2005 19:59:29 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1CxEIC-000623-J8 for emacs-devel@gnu.org; Fri, 04 Feb 2005 19:59:20 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1CxEIB-00061X-0B for emacs-devel@gnu.org; Fri, 04 Feb 2005 19:59:20 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1CxEIA-00061L-Ra for emacs-devel@gnu.org; Fri, 04 Feb 2005 19:59:18 -0500 Original-Received: from [64.21.80.18] (helo=shark.dnsvelocity.com) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.34) id 1CxE3U-00022C-Gb for emacs-devel@gnu.org; Fri, 04 Feb 2005 19:44:08 -0500 Original-Received: from stupidch by shark.dnsvelocity.com with local (Exim 4.43) id 1CxE3H-0008G9-AJ for emacs-devel@gnu.org; Fri, 04 Feb 2005 19:43:55 -0500 Original-Received: from 219.74.2.152 ([219.74.2.152]) (SquirrelMail authenticated user cyd@stupidchicken.com); by www.stupidchicken.com with HTTP; Fri, 4 Feb 2005 19:43:55 -0500 (EST) Original-To: emacs-devel@gnu.org User-Agent: SquirrelMail/1.4.3a X-Mailer: SquirrelMail/1.4.3a X-Priority: 3 (Normal) Importance: Normal X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - shark.dnsvelocity.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [32675 33085] / [47 12] X-AntiAbuse: Sender Address Domain - shark.dnsvelocity.com X-Source: /usr/local/cpanel/3rdparty/bin/php X-Source-Args: /usr/local/cpanel/3rdparty/bin/php /usr/local/cpanel/base/3rdparty/squirrelmail/src/compose.php X-Source-Dir: stupidchicken.com:/base/3rdparty/squirrelmail/src X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-MailScanner-To: ged-emacs-devel@m.gmane.org Xref: main.gmane.org gmane.emacs.devel:32891 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:32891 In 21.3, the variable fill-nobreak-predicate stored a function symbol. This was changed in CVS, long ago, into a hook: 2001-10-30 Stefan Monnier * textmodes/fill.el (sentence-end-double-space) (sentence-end-without-period): Move to paragraphs.el. (fill-indent-according-to-mode): Change default to t. (fill-context-prefix): Simplify control-flow and use a more sophisticated merge that unifies both previous checks. (fill-single-word-nobreak-p, fill-french-nobreak-p): New funs. (fill-nobreak-predicate): Make it into a defcustom'd hook. This breaks third-party code that relies on fill-nobreak-predicate (such as longlines.el), but never mind; the problem is that the NEWS entry does not give any indication of this: ** You can now customize fill-nobreak-predicate to control where filling can break lines. We provide two sample predicates, fill-single-word-nobreak-p and fill-french-nobreak-p. +++ This makes it sound like the only change was to make it customizable, when in fact its data type has changed. The entry in lispref/text.texi should also be corrected: @defvar fill-nobreak-predicate This variable gives major modes a way to specify not to break a line at certain places. Its value should be a function. This function is called during filling, with no arguments and with point located at the place where a break is being considered. If the function returns non-@code{nil}, then the line won't be broken there. @end defvar