From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Bruno Haible Newsgroups: gmane.comp.lib.gnulib.bugs,gmane.emacs.devel Subject: Re: [master b3cf281] Unbreak the MinGW build Date: Fri, 16 Dec 2016 19:11:31 +0100 Message-ID: <10588713.4sEyyCWImg@linuix.haible.de> References: <83eg1887q4.fsf@gnu.org> <6f53d9d5-c352-2bb7-1312-d7e465b63c61@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit X-Trace: blaine.gmane.org 1481911938 902 195.159.176.226 (16 Dec 2016 18:12:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 16 Dec 2016 18:12:18 +0000 (UTC) User-Agent: KMail/4.8.5 (Linux/3.8.0-44-generic; KDE/4.8.5; x86_64; ; ) Cc: Paul Eggert , bug-gnulib@gnu.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane.org@gnu.org Fri Dec 16 19:12:15 2016 Return-path: Envelope-to: gnu-bug-gnulib@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cHwzO-0007e7-9T for gnu-bug-gnulib@m.gmane.org; Fri, 16 Dec 2016 19:12:14 +0100 Original-Received: from localhost ([::1]:33637 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cHwzS-0007rG-CT for gnu-bug-gnulib@m.gmane.org; Fri, 16 Dec 2016 13:12:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cHwz6-0007pu-L5 for bug-gnulib@gnu.org; Fri, 16 Dec 2016 13:11:59 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cHwz5-0004rm-JY for bug-gnulib@gnu.org; Fri, 16 Dec 2016 13:11:56 -0500 Original-Received: from mo6-p00-ob.smtp.rzone.de ([2a01:238:20a:202:5300::7]:25291) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cHwz1-0004os-RI; Fri, 16 Dec 2016 13:11:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1481911909; l=1698; s=domk; d=clisp.org; h=Content-Type:Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Date:Subject:Cc:To:From; bh=vectQci1JjgJ+Lssjwx81EFk88VrO0KlL4z5qFUSI0c=; b=kwXBx2CS1BAK0h6nq+CvpCJY6uGfh79X9eUyOYHZoEsQueLFY6DrIl87yQ2neapY71 bQWwDzZNWATE8otK0Fs1ww2JRE9xLEOAsfDqrK9WERLU1qB20gAA8WJaHGzTieBFDKOf dGv4SGB2lf88iYF8yB9JqBRxIkbUr1+AZtroY= X-RZG-AUTH: :Ln4Re0+Ic/6oZXR1YgKryK8brksyK8dozXDwHXjf9hj/zDNRavU46kji X-RZG-CLASS-ID: mo00 Original-Received: from bruno.haible.de (dslb-088-068-033-080.088.068.pools.vodafone-ip.de [88.68.33.80]) by smtp.strato.de (RZmta 39.11 DYNA|AUTH) with ESMTPSA id z05ac5sBGIBeheZ (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Fri, 16 Dec 2016 19:11:40 +0100 (CET) In-Reply-To: <6f53d9d5-c352-2bb7-1312-d7e465b63c61@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 2a01:238:20a:202:5300::7 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane.org@gnu.org Original-Sender: "bug-gnulib" Xref: news.gmane.org gmane.comp.lib.gnulib.bugs:36533 gmane.emacs.devel:210532 Archived-At: Eli Zaretskii wrote: > > I needed this commit to prevent temacs from crashing during dumping. > > Don't ask me how including errno.h (both the one from Gnulib and the > > MinGW one) could cause this, especially as the preprocessed __fpending > > doesn't seem to change a bit as result of that, and it doesn't seem to > > even be called during dumping. The facts are stubborn: if I leave > > that inclusion in place, I get a crash, removing it fixes the crash. Paul Eggert replied: > I propagated this fix back to gnulib by installing the attached patch to Gnulib. > I'll CC: this to Bruno Haible, who made the recent change to fpending. I don't > use MinGW myself. On mingw, the fpending.o generated by this code, with or without this #include , is identical (even with debugging information [-g]). I wouldn't have applied this patch, as the cause of the crash is obviously somewhere else. We have all seen Heisenbugs in complex pieces of code. The suspicious complex piece of code in this case, for me, is the temacs dumping code. Eli: - How often have you tried to temacs+dump with and without the change? Once each? Twice each? 10 times each? If it's a small number, you may be seeing a random result and not realize it was random. - Did you run temacs in the same directory in both cases, or in different directories? Different directories could lead to a different memory layout in temacs, due to different filename lengths. - After determining that disabling the include would fix the crash, did you test whether reenable the include would reenable the crash? If not, some leftover file on the file system could make the difference. Bruno