From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Andre Spiegel Newsgroups: gmane.emacs.devel Subject: Re: 4 minor suggestions for files.el Date: 06 May 2003 12:56:55 +0200 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <1052218614.509.109.camel@localhost> References: <200304142022.h3EKMHRu026814@rum.cs.yale.edu> <200304172139.h3HLdBvK009948@rum.cs.yale.edu> <200304292107.h3TL7Kl9007427@rum.cs.yale.edu> <1052146332.510.27.camel@localhost> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Trace: main.gmane.org 1052220479 17058 80.91.224.249 (6 May 2003 11:27:59 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Tue, 6 May 2003 11:27:59 +0000 (UTC) Cc: monnier+gnu/emacs@rum.cs.yale.edu Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Tue May 06 13:27:52 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19D0bw-0004QV-00 for ; Tue, 06 May 2003 13:27:52 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 19D0fO-0005hX-00 for ; Tue, 06 May 2003 13:31:27 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 19D0Tn-0002Cd-03 for emacs-devel@quimby.gnus.org; Tue, 06 May 2003 07:19:27 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 19D0Hq-00017K-00 for emacs-devel@gnu.org; Tue, 06 May 2003 07:07:06 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 19D084-0007bL-00 for emacs-devel@gnu.org; Tue, 06 May 2003 06:57:00 -0400 Original-Received: from [194.73.242.5] (helo=wmpmta03-app.mail-store.com) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 19D082-0007X4-00; Tue, 06 May 2003 06:56:58 -0400 Original-Received: from [10.0.1.2] ([217.224.227.171]) by wmpmta03-app.mail-store.com with ESMTP <20030506105656.UNEZ26268.wmpmta03-app.mail-store.com@[10.0.1.2]>; Tue, 6 May 2003 11:56:56 +0100 Original-To: rms@gnu.org In-Reply-To: X-Mailer: Ximian Evolution 1.2.4 Original-cc: emacs-devel@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:13715 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:13715 On Tue, 2003-05-06 at 12:14, Richard Stallman wrote: > For vc-merge, since that is an explicit command to apply a patch to > the buffer, I think it would be right for the patch to be undoable. > Is it undoable now? Could it be made so? Would that require a change > somewhat like the one Stephan proposed? You can always use the symmetric operation, of course. You can take out the changes from 1.2 to 1.4 using vc-merge, and then you can reapply them by simply reversing the arguments again. I don't think it's wise to make this available through the general undo mechanism. For example, vc-merge may also detect conflicts with your own changes, and you need to resolve them before the merge operation is actually finished. How would you undo that? This is getting very complicated, and I think it's wiser just to provide the user with symmetric operations.