From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Joe Kelsey Newsgroups: gmane.emacs.devel Subject: Re: skeleton.el _ versus @, a new patch Date: 20 Apr 2003 15:50:52 -0700 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <1050879051.74664.17.camel@zircon> References: <200303242005.h2OK57gr013285@rum.cs.yale.edu> <1048554010.20622.66.camel@zircon> <200303311740.h2VHeZNG017518@rum.cs.yale.edu> <1049242082.66437.15.camel@zircon> <200304020020.h320K4de023432@rum.cs.yale.edu> <1049245381.66437.33.camel@zircon> <20030403084549.2a5aca76.occitan@esperanto.org> <200304091626.h39GQlwc000430@rum.cs.yale.edu> <1050020736.419.11.camel@zircon> <200304112359.h3BNxpw5012335@rum.cs.yale.edu> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Trace: main.gmane.org 1050879245 20468 80.91.224.249 (20 Apr 2003 22:54:05 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sun, 20 Apr 2003 22:54:05 +0000 (UTC) Cc: Stefan Monnier Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Mon Apr 21 00:53:59 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 197Nh9-0005JJ-00 for ; Mon, 21 Apr 2003 00:53:59 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 197Nld-0008LK-00 for ; Mon, 21 Apr 2003 00:58:38 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 197Nfz-00046N-07 for emacs-devel@quimby.gnus.org; Sun, 20 Apr 2003 18:52:47 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 197Nev-0003Ai-00 for emacs-devel@gnu.org; Sun, 20 Apr 2003 18:51:41 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 197NeQ-0002cg-00 for emacs-devel@gnu.org; Sun, 20 Apr 2003 18:51:11 -0400 Original-Received: from dsl231-043-165.sea1.dsl.speakeasy.net ([216.231.43.165] helo=zircon.seattle.wa.us) by monty-python.gnu.org with smtp (Exim 4.10.13) id 197NeA-0002Zm-00 for emacs-devel@gnu.org; Sun, 20 Apr 2003 18:50:54 -0400 Original-Received: (qmail 80413 invoked from network); 20 Apr 2003 22:50:52 -0000 Original-Received: from localhost (HELO ?127.0.0.1?) (127.0.0.1) by localhost with SMTP; 20 Apr 2003 22:50:52 -0000 Original-To: rms@gnu.org In-Reply-To: X-Mailer: Ximian Evolution 1.2.4 Original-cc: dapfy@t-online.de Original-cc: emacs-devel@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:13303 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:13303 On Sun, 2003-04-13 at 04:23, Richard Stallman wrote: > Before my patch, the behavior was that after insertion of > a skeleton, point would be placed at "the first occurrence of _ > or at the end of the skeleton". > > What my patch changed is that point after insertion of a skeleton > is now placed at "the first occurrence of _ or @ > or at the end of the skeleton". > > Couldn't you get the same result with the old code > by writing @ _? Here is a patch to add - as an alternate skeleton character. - operates exactly as _ in setting skeleton-point, but does not interact with the region wrapping effects. This means that @ is completely unaffected and remains as just the method of setting the skeleton-positions. --- skeleton.el.orig Sat Jul 14 04:21:08 2001 +++ skeleton.el Sun Apr 20 15:44:44 2003 @@ -453,7 +453,8 @@ ((eq element '|) (unless skeleton-modified (pop skeleton))) ((eq element '@) - (push (point) skeleton-positions) + (push (point) skeleton-positions)) + ((eq element '-) (unless skeleton-point (setq skeleton-point (point)))) ((eq 'quote (car-safe element)) (eval (nth 1 element))) This allows Stefan to have a character to use for marking skeleton-point without wrapping the skeleton around the point. It also allows mmm-mode to continue to use both @ and _ in their skeletons without suffering under the undesired semantics of the modified meaning of @ introduced by Stefan's patch. I hope that this solves the issue for everyone. /Joe