From: Bill Wohler <wohler@newt.com>
Subject: Re: mh-e/mh-acros.el advices `require' incorrectly
Date: Fri, 13 Jan 2006 17:39:59 -0800 [thread overview]
Message-ID: <10231.1137202799@olgas.newt.com> (raw)
In-Reply-To: Satyaki Das's message of Fri, 13 Jan 2006 15:36:51 PST. <dce9e6890601131536w70fb8997nfae64c115bd1f241@mail.gmail.com>
Satyaki Das <satyakid@gmail.com> wrote:
> On 1/13/06, Bill Wohler <wohler@newt.com> wrote:
> > Drew Adams <drew.adams@oracle.com> wrote:
> >
> > > > The origianl `require' returns FEATURE even if it is already
> > > > provided, but the adviced `require' returns nil in such a
> > > > case. So, once mh-acros.el is loaded, a code depending on
> > > > the return value of `require' stops working.
> > > >
> > > > How about this change?
> > >
> > > What do you (and others) think about this?
> > >
> > > Besides the fact that we shouldn't use defadvice in vanilla Emacs code, I
> > > don't think we should change the return value of `require' at all. It has
> > > acted this way for a very long time, and there is undoubtedly code that
> > > depends on this behavior (at least some external libraries). Besides, we
> > > certainly should not make such a change just before a release.
> >
> > Unless you load MH-E, require does not change.
>
> Even if you load MH-E, require isn't adviced since mh-acros.el is
> never loaded at run time unless you load it yourself.
>
> > If I understand
> > correctly, Kanichi's patch addresses your concern (about the return
> > value of require changing). Here's the ChangeLog for that change:
>
> Kenichi's patch won't cause any problems for MH-E.
This means you can check in your patch, Kenichi ;-).
Thanks very much for the explanation, Satyaki.
--
Bill Wohler <wohler@newt.com> http://www.newt.com/wohler/ GnuPG ID:610BD9AD
Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian!
If you're passed on the right, you're in the wrong lane.
next prev parent reply other threads:[~2006-01-14 1:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87oe2gez38.fsf@olgas.newt.com>
2006-01-13 21:04 ` mh-e/mh-acros.el advices `require' incorrectly Drew Adams
2006-01-13 22:11 ` Bill Wohler
2006-01-13 23:36 ` Satyaki Das
2006-01-14 1:39 ` Bill Wohler [this message]
2006-01-14 0:29 ` Kenichi Handa
2006-01-14 16:14 ` Richard M. Stallman
2006-01-14 23:00 ` Bill Wohler
2006-01-14 23:16 ` Andreas Schwab
2006-01-15 0:26 ` Bill Wohler
2006-01-15 2:22 ` Stefan Monnier
2006-01-15 23:07 ` Richard M. Stallman
2006-01-16 1:29 ` Bill Wohler
2006-01-17 3:24 ` Richard M. Stallman
2006-01-17 4:20 ` Bill Wohler
2006-01-17 9:18 ` David Kastrup
2006-01-17 17:19 ` Bill Wohler
2006-01-29 19:22 ` MH-E reorg (was: mh-e/mh-acros.el advices `require' incorrectly) Bill Wohler
2006-01-29 21:10 ` MH-E reorg Bill Wohler
2006-01-30 18:45 ` MH-E reorg (was: mh-e/mh-acros.el advices `require' incorrectly) Richard M. Stallman
2006-01-30 19:24 ` Bill Wohler
2006-01-13 7:49 mh-e/mh-acros.el advices `require' incorrectly Kenichi Handa
2006-01-13 18:56 ` Bill Wohler
2006-01-13 21:45 ` Stefan Monnier
2006-01-14 2:52 ` Bill Wohler
2006-01-14 16:14 ` Richard M. Stallman
2006-01-14 17:47 ` Stefan Monnier
2006-01-14 5:49 ` Richard M. Stallman
2006-01-14 8:25 ` Bill Wohler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10231.1137202799@olgas.newt.com \
--to=wohler@newt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).