unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: Richard Stallman <rms@gnu.org>
Cc: Stephen.Berman@gmx.net, emacs-devel@gnu.org
Subject: Re: minibuffer and current-local-map
Date: Sun, 06 Jan 2008 14:36:32 -0500	[thread overview]
Message-ID: <0yodby3fwf.fsf@fencepost.gnu.org> (raw)


I no longer have the original message to reply to. I'm replying to:

http://lists.gnu.org/archive/html/emacs-devel/2007-11/msg00602.html

  From:   Richard Stallman
  Subject:        Re: minibuffer and current-local-map
  Date:           Fri, 09 Nov 2007 17:00:03 -0500

The issue is:

emacs -Q
M-x
C-mouse-3 in the minibuffer brings up a menu with two "Minibuff" entries.

rms said:

  The solution, I think, is to fix the menu code to avoid showing
  duplicates in such a case.


Here is a simple patch that just takes the first of any duplicate
(same name) menus.


*** mouse.el.~1.315.2.4.~	2007-12-06 20:27:17.000000000 -0800
--- mouse.el	2008-01-06 11:11:51.000000000 -0800
***************
*** 173,183 ****
  	 ;; default to the edit menu.
  	 (newmap (if ancestor
  		     (make-sparse-keymap (concat mode-name " Mode"))
! 		   menu-bar-edit-menu)))
      (if ancestor
  	;; Make our menu inherit from the desired keymap which we want
  	;; to display as the menu now.
! 	(set-keymap-parent newmap ancestor))
      (popup-menu newmap event prefix)))
  
  
--- 173,190 ----
  	 ;; default to the edit menu.
  	 (newmap (if ancestor
  		     (make-sparse-keymap (concat mode-name " Mode"))
! 		   menu-bar-edit-menu))
!          uniq)
      (if ancestor
  	;; Make our menu inherit from the desired keymap which we want
  	;; to display as the menu now.
! 	(set-keymap-parent newmap
!                            (progn
!                              (dolist (e ancestor)
!                                (unless (and (listp e)
!                                             (assoc (car e) uniq))
!                                  (setq uniq (append uniq (list e)))))
!                              uniq)))
      (popup-menu newmap event prefix)))

             reply	other threads:[~2008-01-06 19:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-06 19:36 Glenn Morris [this message]
2008-01-07 11:31 ` minibuffer and current-local-map Richard Stallman
2008-01-07 12:43   ` Stephen Berman
  -- strict thread matches above, loose matches on Subject: below --
2007-11-07 16:30 Stephen Berman
2007-11-08  4:42 ` Richard Stallman
2007-11-08  7:20   ` Stephen Berman
2007-11-08 23:37     ` Richard Stallman
2007-11-09 22:00       ` Richard Stallman
2007-11-30 16:42         ` Jason Rumney
2007-11-30 23:36           ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0yodby3fwf.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=Stephen.Berman@gmx.net \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).