From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: libnettle/libhogweed WIP Date: Thu, 3 Aug 2017 01:02:13 -0700 Organization: UCLA Computer Science Department Message-ID: <0fd679e7-1258-8e8a-edc6-6071d171c6b0@cs.ucla.edu> References: <87r30nq9el.fsf@lifelogs.com> <83inlyc1k2.fsf@gnu.org> <87inlyrfni.fsf@lifelogs.com> <837f2eb845.fsf@gnu.org> <87ziedpyy1.fsf@lifelogs.com> <83d1b75u8a.fsf@gnu.org> <87r2znntaq.fsf@lifelogs.com> <87o9u8q4a5.fsf@lifelogs.com> <83tw3xbklg.fsf@gnu.org> <87zictm415.fsf@lifelogs.com> <83podoqchd.fsf@gnu.org> <87podnnbi2.fsf@lifelogs.com> <8760ewi3rw.fsf@lifelogs.com> <87r2xjgilq.fsf@lifelogs.com> <83iniug7ql.fsf@gnu.org> <87fudyhkhy.fsf@lifelogs.com> <8360euf4d3.fsf@gnu.org> <87r2xhfsre.fsf@lifelogs.com> <83o9slecp0.fsf@gnu.org> <83zibw96r9.fsf@gnu.org> <84297b99-4d46-0c4d-5c31-51678f8d738a@cs.ucla.edu> <831sp2621s.fsf@gnu.org> <3b789b95-33a7-9756-98f5-accf5d25c3f4@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------D0AD9EFCA44E874BD8AACA1B" X-Trace: blaine.gmane.org 1501747392 11233 195.159.176.226 (3 Aug 2017 08:03:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 3 Aug 2017 08:03:12 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 To: Emacs Development Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 03 10:03:06 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddB5z-0002Q3-KC for ged-emacs-devel@m.gmane.org; Thu, 03 Aug 2017 10:03:03 +0200 Original-Received: from localhost ([::1]:44473 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddB64-0006xf-0x for ged-emacs-devel@m.gmane.org; Thu, 03 Aug 2017 04:03:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37838) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddB5K-0006x3-BN for Emacs-devel@gnu.org; Thu, 03 Aug 2017 04:02:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ddB5G-000619-Dz for Emacs-devel@gnu.org; Thu, 03 Aug 2017 04:02:22 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:35268) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ddB5G-0005zc-4L for Emacs-devel@gnu.org; Thu, 03 Aug 2017 04:02:18 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 1E65416073B for ; Thu, 3 Aug 2017 01:02:16 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id UCJWBqArR2ol for ; Thu, 3 Aug 2017 01:02:14 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 2CC01160736 for ; Thu, 3 Aug 2017 01:02:14 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 1tDmkYHSYNlf for ; Thu, 3 Aug 2017 01:02:14 -0700 (PDT) Original-Received: from [192.168.1.9] (unknown [47.153.184.153]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 0EC6F160217 for ; Thu, 3 Aug 2017 01:02:14 -0700 (PDT) In-Reply-To: <3b789b95-33a7-9756-98f5-accf5d25c3f4@cs.ucla.edu> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217254 Archived-At: This is a multi-part message in MIME format. --------------D0AD9EFCA44E874BD8AACA1B Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Paul Eggert wrote: > it would take some time for me to come up to speed on GnuTLS. Although I'm still not up to speed at all, I think I tracked the problem = down. I=20 installed the attached patch which fixes things for me on Ubuntu 16.04.2 = LTS, by=20 having Emacs use AEAD only on GnuTLS 3.5.1 and later. --------------D0AD9EFCA44E874BD8AACA1B Content-Type: text/x-patch; name="0001-Port-GnuTLS-usage-to-Ubuntu-16.04.2-LTS.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-Port-GnuTLS-usage-to-Ubuntu-16.04.2-LTS.patch" =46rom fcd7c6b8605dbfb0c38da39a50d5ac882c2c0ba3 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Thu, 3 Aug 2017 01:00:10 -0700 Subject: [PATCH] Port GnuTLS usage to Ubuntu 16.04.2 LTS * src/gnutls.h (HAVE_GNUTLS3_AEAD): Define only if GnuTLS 3.5.1 or later, as opposed to the old 3.4.0 or later. --- src/gnutls.h | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/gnutls.h b/src/gnutls.h index 19c1686..8fe4ac3 100644 --- a/src/gnutls.h +++ b/src/gnutls.h @@ -29,12 +29,21 @@ along with GNU Emacs. If not, see . */ #endif =20 #if 0x030400 <=3D GNUTLS_VERSION_NUMBER -# define HAVE_GNUTLS3_AEAD # define HAVE_GNUTLS3_CIPHER # define HAVE_GNUTLS3_DIGEST # define HAVE_GNUTLS3_HMAC #endif =20 +/* Although AEAD support started in GnuTLS 3.4.0 and works in 3.5.14, + it was broken through at least GnuTLS 3.4.10; see: + https://lists.gnu.org/archive/html/emacs-devel/2017-07/msg00992.html + The relevant fix seems to have been made in GnuTLS 3.5.1; see: + https://gitlab.com/gnutls/gnutls/commit/568935848dd6b82b9315d8b6c529d= 00e2605e03d + So use 3.5.1 for now. */ +#if 0x030501 <=3D GNUTLS_VERSION_NUMBER +# define HAVE_GNUTLS3_AEAD +#endif + #include "lisp.h" =20 /* This limits the attempts to handshake per process (connection). It --=20 2.7.4 --------------D0AD9EFCA44E874BD8AACA1B--