From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.devel Subject: Re: "Can't find Hunspell dictionary" error (was Re: Emacs pretest 28.0.91 is out) Date: Fri, 14 Jan 2022 14:05:56 +1300 Message-ID: <0f304fcc8959fd365e95ce36e42b4794@webmail.orcon.net.nz> References: <5c74e0fb4c651733c0d8072f7cd40d06@webmail.orcon.net.nz> <878rvk3tw8.fsf@gmail.com> <87zgo02azu.fsf@gmail.com> <83tue73on6.fsf@gnu.org> <1cf6dd192736ae555734abb12bd17e9b@webmail.orcon.net.nz> <83mtjz3j44.fsf@gnu.org> <87lezj3f5d.fsf@gmail.com> <83ee5b3de7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37229"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Orcon Webmail Cc: Robert Pluim , stefan@marxist.se, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 14 02:07:29 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8B3x-0009ZC-1y for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Jan 2022 02:07:29 +0100 Original-Received: from localhost ([::1]:55146 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8B3v-0005vX-UR for ged-emacs-devel@m.gmane-mx.org; Thu, 13 Jan 2022 20:07:27 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35482) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8B2i-00044o-IM for emacs-devel@gnu.org; Thu, 13 Jan 2022 20:06:13 -0500 Original-Received: from smtp-3.orcon.net.nz ([60.234.4.44]:58889) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8B2g-0002Dp-7J; Thu, 13 Jan 2022 20:06:12 -0500 Original-Received: from [10.253.37.70] (port=53904 helo=webmail.orcon.net.nz) by smtp-3.orcon.net.nz with esmtpa (Exim 4.90_1) (envelope-from ) id 1n8B2T-0001hK-1r; Fri, 14 Jan 2022 14:05:57 +1300 Original-Received: from ip-139-180-65-103.kinect.net.nz ([139.180.65.103]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Fri, 14 Jan 2022 14:05:56 +1300 In-Reply-To: <83ee5b3de7.fsf@gnu.org> X-Sender: psainty@orcon.net.nz X-GeoIP: -- Received-SPF: pass client-ip=60.234.4.44; envelope-from=psainty@orcon.net.nz; helo=smtp-3.orcon.net.nz X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284725 Archived-At: On 2022-01-14 03:42, Eli Zaretskii wrote: >> >> Using `with-demoted-errors' would achieve both goals, I think? >> >> Eli> Using that where? in the test suite? >> >> Yes, for this one specific test. Although Iʼd prefer `ignore-errors', > > Fine with me. I agree with `ignore-errors' for the test suite. My `with-⁠demoted-⁠errors' suggestion was actually regarding `ispell-⁠valid-⁠dictionary-⁠list' or `ispell-⁠set-⁠spellchecker-⁠params' as I wouldn't expect an absence of dictionaries to cause those functions (or at least the former) to fail. I haven't looked at them in detail, but my gut feeling was that `ispell-⁠valid-⁠dictionary-⁠list' should be returning an empty list in that scenario. I thought that if a warning message was logged along the way to point out that no dictionaries were installed, that would seem fine (and preferable to an error). Maybe not a change for 28.1, but potentially for master? -Phil