From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Jim Porter <jporterbugs@gmail.com>
Newsgroups: gmane.emacs.devel
Subject: Re: master 9ccaa09a635: ; .dir-locals.el (log-edit-mode)
 <fill-column>: Set to 64.
Date: Wed, 7 Feb 2024 19:10:14 -0800
Message-ID: <0e8b1009-1491-2fb7-9efc-c415ed66d334@gmail.com>
References: <170727415485.32408.11264518274307262467@vcs2.savannah.gnu.org>
 <20240207024915.38686C0EFEC@vcs2.savannah.gnu.org>
 <CADwFkmmK+r6Q_GdTa++PaZRm3ngQ_ueXR2yfzN8RaS607dUiOg@mail.gmail.com>
 <87plx74u0i.fsf@yahoo.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="16764"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org, eliz@gnu.org
To: Po Lu <luangruo@yahoo.com>, Stefan Kangas <stefankangas@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 08 04:12:36 2024
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1rXuq3-0004FO-Nn
	for ged-emacs-devel@m.gmane-mx.org; Thu, 08 Feb 2024 04:12:35 +0100
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces@gnu.org>)
	id 1rXuo3-0002CD-6B; Wed, 07 Feb 2024 22:10:31 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <jporterbugs@gmail.com>)
 id 1rXuo2-00029t-3s
 for emacs-devel@gnu.org; Wed, 07 Feb 2024 22:10:30 -0500
Original-Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <jporterbugs@gmail.com>)
 id 1rXuno-0004vf-SV; Wed, 07 Feb 2024 22:10:29 -0500
Original-Received: by mail-pj1-x1030.google.com with SMTP id
 98e67ed59e1d1-295c8b795e2so996812a91.0; 
 Wed, 07 Feb 2024 19:10:15 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1707361815; x=1707966615; darn=gnu.org;
 h=content-transfer-encoding:in-reply-to:from:references:cc:to
 :content-language:subject:mime-version:date:message-id:from:to:cc
 :subject:date:message-id:reply-to;
 bh=uAzIIWmo79DHf4A1PJ8KY0cF9auwq729CoN30ZDiFt8=;
 b=NV/ccpfGOG1CR+5lT/8wcv46Bi6OjdL8lzDIPoTbbYpquB0I8AoaVkMa3pfLX3MJOJ
 ArhHCiMiV6uX2NbLh8QyQcekDNXOIAoh0EGyxz1+Dcc75Iots4KNXpC7RGDkVms1Z7LO
 4CxyeOR/cS4wZchwS10qUvbh31JAykrPtxoGd18uzoESffDcyLGPmn8qYc8Mwb1Dn54u
 71sW59VxH+1FKvecEPLq3n1+F6c62q+8smYYL+OnNzy32eeSwWN/o3/NrdxHCKayvKvl
 O6lie1+XOu03s99kZvM02UnIvWeT7v1s9EVFee+a15Z1ARbIRXQqk+S0BVo8KIiBUfyz
 alEA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1707361815; x=1707966615;
 h=content-transfer-encoding:in-reply-to:from:references:cc:to
 :content-language:subject:mime-version:date:message-id
 :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=uAzIIWmo79DHf4A1PJ8KY0cF9auwq729CoN30ZDiFt8=;
 b=UkOIeY7VeOqFoKLuPTt9KBwTrLE7Hk3RTJbI0WkW+NeRP9UOANuL3Fz05n3g0OP2WP
 12Nhm0iOsL8HAUHWFyiQ0ucHbDLflh92HuvuMWFebsqwX+rAv7nZ6nGiPCS3RyxRSMKo
 4727JbyigeZIHAiLoChOLbr5coFewGsyBJpjIBClw6dXuyOgdyJsk2rx66jHDHUFWBmk
 zsxFhZb1xjmICjKFrkMVdzrfREk0pmcbTfqZB9h9MwoiMEtBVewjyaRQnztURr2d9NWl
 KY+ZEvCLIRtAOYJnEoz5ITUs1FBudfVJ/3p1Aya29wWmlPqAMjhxQBbIjmVbMh0Cxax4
 3Kdw==
X-Forwarded-Encrypted: i=1;
 AJvYcCVwVPMrZFXJRaY0B+svFYjlvbnetQCK/cgjGw87PH6hRBp2FGMKBFF3FoJ/oypvzWsBqM54IRNaVQKgtKk=
X-Gm-Message-State: AOJu0YynzswRtfZqFPk1+H/+egoweD88/FQHp62OalgtjZqaPKqp7QbA
 A7yBNPntU2E1eeaVRnOer5zh5wpj17QMw9aBy4fVMsoCDiRs649l
X-Google-Smtp-Source: AGHT+IF3gw4TuitbP5203HayfqKEWJaqYJSXypuedrFgqkRLt6g8MMmO+9rtd2v7luo+vlbqdKfmZA==
X-Received: by 2002:a17:90a:fb56:b0:290:6e71:7ce4 with SMTP id
 iq22-20020a17090afb5600b002906e717ce4mr4056161pjb.24.1707361814880; 
 Wed, 07 Feb 2024 19:10:14 -0800 (PST)
X-Forwarded-Encrypted: i=1;
 AJvYcCVdgMbCYpoyMar+ZRZ8cmdDN4HKhjy1XBz8OD3hVau1rRLG6uC9CxGqPpM3/f0hGDZya5FVT6vVUAFS96fqsCPiEcePlQaZBV0YOXX/gvQGwoADG8s=
Original-Received: from [192.168.1.2] (076-168-148-233.res.spectrum.com.
 [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id
 e13-20020a170902cf4d00b001d8f393f3cfsm2203315plg.248.2024.02.07.19.10.14
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 07 Feb 2024 19:10:14 -0800 (PST)
Content-Language: en-US
In-Reply-To: <87plx74u0i.fsf@yahoo.com>
Received-SPF: pass client-ip=2607:f8b0:4864:20::1030;
 envelope-from=jporterbugs@gmail.com; helo=mail-pj1-x1030.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.devel:316008
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/316008>

On 2/7/2024 5:36 PM, Po Lu wrote:
> Stefan Kangas <stefankangas@gmail.com> writes:
> 
>> This change breaks with our conventions and historical practice, and
>> makes both commit messages and ChangeLogs take up much more vertical
>> space for no practical benefit.
> 
> ??? Our historical and current practice is to fill ChangeLogs to 74
> columns, which setting the fill-column in log messages to 64
> accomplishes.

Aren't the entries in ChangeLogs indented by one tab (so 8 characters by 
default), which would mean that if we want to fill the ChangeLog to 74 
columns, we actually want log-edit-mode to fill to 74 - 8 = 66 columns?

>  See CONTRIBUTE:
> 
> - Lines in ChangeLog entries should preferably be not longer than 63
>    characters, and must not exceed 78 characters, unless they consist
>    of a single word of at most 140 characters; this 78/140 limit is
>    enforced by a commit hook.

That passage was last changed by Eli (CCed) in 2022 (commit 
161cb6034cec). Previously, it said this:

> - Limit lines in commit messages to 78 characters, unless they consist
>   of a single word of at most 140 characters; this is enforced by a
>   commit hook.

(There was a sentence after that recommending the first line be <=50 
columns moved elsewhere in 2021, but otherwise, that passage has been 
that way from 2015 until Eli's change.)

In any case, if the intent is really to limit *ChangeLog entries* to 
78/140 columns instead of *commit messages*, then the commit hook that 
CONTRIBUTE mentions is wrong; it checks for exceeding 78/140 columns in 
the commit message.

I don't have a terribly strong opinion here of what number to use, but 
we should at least resolve the inconsistencies in CONTRIBUTE, 
.dir-locals.el, and build-aux/git-hooks/commit-msg.