From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Emacs build fails [MSYS2/MINGW64]
Date: Tue, 30 Apr 2019 09:49:29 -0700 [thread overview]
Message-ID: <0d0bce34-b083-8810-2cc7-749d32f6f2b8@cs.ucla.edu> (raw)
In-Reply-To: <837ebbsdio.fsf@gnu.org>
On 4/30/19 8:45 AM, Eli Zaretskii wrote:
>> From: Paul Eggert <eggert@cs.ucla.edu>
>> Date: Mon, 29 Apr 2019 12:38:02 -0700
>> Cc: angelo.g0@libero.it, emacs-devel@gnu.org
>>
>> -#if __has_attribute (cold)
>> +/* Avoid __attribute__ ((cold)) on MinGW; see thread starting at
>> + <https://lists.gnu.org/r/emacs-devel/2019-04/msg01152.html>. */
>> +#if __has_attribute (cold) && !defined __MINGW32__
> We defined __has_attribute_cold, so no need to use __has_attribute
> here, right?
conf_post.h defines __has_attribute_cold only on older compilers that
lack support for __has_attribute. So we still need to use
__has_attribute here, for newer compilers (GCC 5 and later, for example).
next prev parent reply other threads:[~2019-04-30 16:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-28 15:37 Emacs build fails [MSYS2/MINGW64] Angelo Graziosi
2019-04-28 16:10 ` Paul Eggert
2019-04-28 16:43 ` Angelo Graziosi
2019-04-29 11:53 ` Angelo Graziosi
2019-04-29 12:49 ` martin rudalics
2019-04-29 14:53 ` Eli Zaretskii
2019-04-29 19:38 ` Paul Eggert
2019-04-30 15:45 ` Eli Zaretskii
2019-04-30 16:49 ` Paul Eggert [this message]
2019-04-30 16:53 ` Eli Zaretskii
2019-05-01 8:28 ` martin rudalics
2019-04-28 16:21 ` Eli Zaretskii
2019-04-28 16:41 ` Angelo Graziosi
2019-04-28 17:30 ` Eli Zaretskii
2019-04-28 21:22 ` Angelo Graziosi
2019-04-28 21:24 ` Angelo Graziosi
2019-04-29 2:29 ` Eli Zaretskii
2019-04-29 14:54 ` Eli Zaretskii
2019-04-28 17:46 ` Stephen Leake
2019-04-29 14:56 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d0bce34-b083-8810-2cc7-749d32f6f2b8@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).