unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: emacs-25 10597c9: Don't use 'find-program'
Date: Mon, 18 Apr 2016 12:10:50 -0400	[thread overview]
Message-ID: <0c8u0asxrp.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <83poto9lu0.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 17 Apr 2016 20:39:03 +0300")

Eli Zaretskii wrote:

> Why are you assuming that any 'find' job would necessarily use -exec?

I'm not, I'm giving it as an example. You've said that find-dired and
grep have different needs, and both may (or may not) use -exec. I found
it really hard to understand what point you were getting at.

Also eg check-declare-directory simply hard-codes -exec, and you changed
that one.

> Did you ever need to customize this variable, on any system? 

No. find-program was never marked as customizable/user-settable till
very recently, so I suspect very few others did.

Please also note that the Emacs build process simply uses "find"
(which is part of POSIX), with both -exec and -print.

But that changes the issue. You are saying it may not only need to be
customizable (which I don't have an issue with), but that there may need
to be two different versions.

> Basically, imagine a system with several different ports of 'find',
> each port with its own advantages and bugs.

I think a system where you have to think which version of find to invoke
depending on what you want to do is a mis-configured system.
I'd just install GNU find and get on with life.

Please give the eventual two variables informative names and docstrings.
It's going to be hard for people on normal systems to figure out
which to use.

This has nothing to with grep, so I would suggest they not live in the
grep namespace.

(Also, grep-xargs-program should just be called xargs-program again.
Hopefully you don't need two versions. :))



  parent reply	other threads:[~2016-04-18 16:10 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160411164301.22548.38008@vcs.savannah.gnu.org>
     [not found] ` <E1apevV-0005sL-3G@vcs.savannah.gnu.org>
2016-04-11 21:56   ` emacs-25 10597c9: Don't use 'find-program' Glenn Morris
2016-04-11 22:00     ` Drew Adams
2016-04-12  2:29       ` Eli Zaretskii
2016-04-16 11:57     ` Eli Zaretskii
2016-04-16 17:40       ` Glenn Morris
2016-04-16 18:57         ` Eli Zaretskii
2016-04-17 17:15           ` Glenn Morris
2016-04-17 17:39             ` Eli Zaretskii
2016-04-18  4:39               ` Paul Eggert
2016-04-18 18:25                 ` Eli Zaretskii
2016-04-18 16:10               ` Glenn Morris [this message]
2016-04-18 16:16                 ` Glenn Morris
2016-04-18 18:47                   ` Eli Zaretskii
2016-04-18 16:50                 ` Glenn Morris
2016-04-18 18:50                   ` Eli Zaretskii
2016-04-20 19:07                     ` Glenn Morris
2016-04-20 19:24                       ` Eli Zaretskii
2016-04-20 19:30                         ` Stefan Monnier
2016-04-20 19:40                           ` Eli Zaretskii
2016-04-20 20:08                             ` Stefan Monnier
2016-04-20 22:54                               ` John Wiegley
2016-04-18 18:45                 ` Eli Zaretskii
2016-04-20 19:27               ` Dmitry Gutov
2016-04-20 19:37                 ` Eli Zaretskii
2016-04-20 19:59                   ` Stefan Monnier
2016-04-20 20:06                   ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c8u0asxrp.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).