From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel,gmane.comp.lib.gnulib.bugs Subject: Re: Emacs build fails on Windows mingw64 Date: Sat, 23 Oct 2021 23:45:04 -0400 Message-ID: <0b467abe-dd50-6a0a-7d1f-37eb990900be@cs.ucla.edu> References: <86v91nfp6e.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------633137A7C4BB7D39813F32C8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28764"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 Cc: bug-gnulib@gnu.org, emacs-devel@gnu.org To: Andy Moreton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Oct 24 05:46:54 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1meUTG-0007I2-FD for ged-emacs-devel@m.gmane-mx.org; Sun, 24 Oct 2021 05:46:54 +0200 Original-Received: from localhost ([::1]:33028 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1meUTE-0004WE-JI for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Oct 2021 23:46:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44420) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1meURu-00038D-HS; Sat, 23 Oct 2021 23:45:31 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:34920) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1meURr-0007fa-0j; Sat, 23 Oct 2021 23:45:29 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E3AAE1600FD; Sat, 23 Oct 2021 20:45:22 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id w6oXhF8uBqzj; Sat, 23 Oct 2021 20:45:21 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id A0EEA160100; Sat, 23 Oct 2021 20:45:21 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id qOTkhUSBTdnG; Sat, 23 Oct 2021 20:45:21 -0700 (PDT) Original-Received: from [172.24.197.33] (aca-104109.nat.emory.edu [170.140.104.109]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 394C21600FD; Sat, 23 Oct 2021 20:45:21 -0700 (PDT) In-Reply-To: <86v91nfp6e.fsf@gmail.com> Content-Language: en-US Received-SPF: pass client-ip=131.179.128.68; envelope-from=eggert@cs.ucla.edu; helo=zimbra.cs.ucla.edu X-Spam_score_int: -59 X-Spam_score: -6.0 X-Spam_bar: ------ X-Spam_report: (-6.0 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-1.781, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277640 gmane.comp.lib.gnulib.bugs:45173 Archived-At: This is a multi-part message in MIME format. --------------633137A7C4BB7D39813F32C8 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 10/23/21 4:42 PM, Andy Moreton wrote: > Can this issue be addressed in gnulib so the emacs bug can be fixed ? This appears to be an issue in Emacs not Gnulib, as a few of Emacs's MS-Windows-specific files don't include first, which is a documented requirement for Gnulib-using apps. Proposed Emacs patch attached. I haven't tested or installed this, as I don't use MingW. --------------633137A7C4BB7D39813F32C8 Content-Type: text/x-patch; charset=UTF-8; name="0001-Include-config.h-first-in-MS-Windows-source.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Include-config.h-first-in-MS-Windows-source.patch" >From 7bb574b48c7c8be0eb1e941c6da048cfb509cdff Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sat, 23 Oct 2021 20:35:18 -0700 Subject: [PATCH] Include first in MS-Windows source --- lib-src/ntlib.c | 2 ++ nt/addpm.c | 3 +++ nt/cmdproxy.c | 2 ++ nt/ddeclient.c | 2 ++ nt/preprep.c | 2 ++ nt/runemacs.c | 2 ++ 6 files changed, 13 insertions(+) diff --git a/lib-src/ntlib.c b/lib-src/ntlib.c index bcbc006431..e011de5b91 100644 --- a/lib-src/ntlib.c +++ b/lib-src/ntlib.c @@ -20,6 +20,8 @@ Copyright (C) 1994, 2001-2021 Free Software Foundation, Inc. You should have received a copy of the GNU General Public License along with GNU Emacs. If not, see . */ +#include + #include #include #include diff --git a/nt/addpm.c b/nt/addpm.c index f54a6ea9f7..4ec372ccfe 100644 --- a/nt/addpm.c +++ b/nt/addpm.c @@ -34,6 +34,9 @@ installed, then the DDE fallback for creating icons the Windows 3.1 progman way will be used instead, but that is prone to lockups caused by other applications not servicing their message queues. */ + +#include + #include #include #include diff --git a/nt/cmdproxy.c b/nt/cmdproxy.c index 224f68b1e8..505855318d 100644 --- a/nt/cmdproxy.c +++ b/nt/cmdproxy.c @@ -27,6 +27,8 @@ You should have received a copy of the GNU General Public License along with GNU Emacs. If not, see . */ +#include + #include #include /* va_args */ diff --git a/nt/ddeclient.c b/nt/ddeclient.c index c577bfcfa9..1390c334b7 100644 --- a/nt/ddeclient.c +++ b/nt/ddeclient.c @@ -16,6 +16,8 @@ You should have received a copy of the GNU General Public License along with GNU Emacs. If not, see . */ +#include + #include #include #include diff --git a/nt/preprep.c b/nt/preprep.c index 78ed1c3238..b73d3bb9fa 100644 --- a/nt/preprep.c +++ b/nt/preprep.c @@ -21,6 +21,8 @@ based on code from addsection.c */ +#include + #include #include #include diff --git a/nt/runemacs.c b/nt/runemacs.c index 308e856be2..f8f60b0665 100644 --- a/nt/runemacs.c +++ b/nt/runemacs.c @@ -40,6 +40,8 @@ Copyright (C) 2001-2021 Free Software Foundation, Inc. /* #define CHOOSE_NEWEST_EXE */ +#include + #include #include #include -- 2.31.1 --------------633137A7C4BB7D39813F32C8--