unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Mattias Engdegård" <mattias.engdegard@gmail.com>
To: Jens Schmidt <jschmidt4gnu@vodafonemail.de>
Cc: emacs-devel@gnu.org
Subject: Re: bytecomp-tests still failing after Mattias' commit a3db503351e9
Date: Sat, 4 Nov 2023 10:32:46 +0100	[thread overview]
Message-ID: <0F725180-50D7-4A81-91FA-30AAE0D638B8@gmail.com> (raw)
In-Reply-To: <e2a387b9-dcda-428f-b3d2-57fa96cceb1a@vodafonemail.de>

3 nov. 2023 kl. 21.25 skrev Jens Schmidt <jschmidt4gnu@vodafonemail.de>:

> Changing subject (which I forgot last time) to catch Mattias' attention.

Eh, wha? I missed the ending again? Did she survive this time?

> If you'd like to reproduce, you probably need to install package
> bubblewrap or whatever provides "bwrap" on your distribution.  Provided
> you use GNU/Linux ...

So very sorry, my fruit machine always skips that test.

Anyway, your proposed

>> -        (write-region "" nil input-file nil nil nil 'excl)
>> +        (write-region ";;; -*-lexical-binding:t-*-\n"
>> +                      nil input-file nil nil nil 'excl)

fix is entirely reasonable and is now on master. Thank you!




      reply	other threads:[~2023-11-04  9:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-27 19:10 Native compilation unit tests failing since last weekend or so Jens Schmidt
2023-10-27 21:29 ` Alan Mackenzie
2023-10-30 20:24 ` Jens Schmidt
2023-11-01  8:21   ` Andrea Corallo
2023-11-03 20:25   ` bytecomp-tests still failing after Mattias' commit a3db503351e9 Jens Schmidt
2023-11-04  9:32     ` Mattias Engdegård [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0F725180-50D7-4A81-91FA-30AAE0D638B8@gmail.com \
    --to=mattias.engdegard@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=jschmidt4gnu@vodafonemail.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).