From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: master 68ae6fa: Improved light/dark colour predicate (bug#41544) Date: Thu, 18 Jun 2020 22:04:30 +0200 Message-ID: <0F5723EE-113E-4D3B-9BD8-D5327B3E87A1@acm.org> References: <20200610181238.9796.44750@vcs0.savannah.gnu.org> <20200610181239.947C4204DF@vcs0.savannah.gnu.org> <93F81C41-E774-4C02-9E9D-5B2CD1F66445@acm.org> <86v9jwksod.fsf@stephe-leake.org> <5A6B8DE2-EADF-4D74-A0EA-DE5303F828D4@acm.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="52147"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel , tomas@tuxteam.de, Stephen Leake , Yuri Khan To: Drew Adams Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 18 22:05:32 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jm0mx-000DSb-Nz for ged-emacs-devel@m.gmane-mx.org; Thu, 18 Jun 2020 22:05:31 +0200 Original-Received: from localhost ([::1]:54950 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jm0mw-0000dM-Nn for ged-emacs-devel@m.gmane-mx.org; Thu, 18 Jun 2020 16:05:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50342) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jm0mB-00005r-1P for emacs-devel@gnu.org; Thu, 18 Jun 2020 16:04:43 -0400 Original-Received: from mail1455c50.megamailservers.eu ([91.136.14.55]:43858 helo=mail266c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jm0m8-0008VJ-NQ for emacs-devel@gnu.org; Thu, 18 Jun 2020 16:04:42 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1592510674; bh=xiOoCLM4KV1aQFa66GR8K2Qw6fWgRZq+yNB6Zlfjutg=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=R09E3//q3Q4Pi7x7pecPLjKJoMLgr9ODJDmglzxK3wHafcf/a7o9+Klu7QOFbP1Sc /h9WUMcx6DEdWWxUsL6a95mVgmwZyJ53UDbeUQC4TpQXN4vcEA+8qXLCz1w1FSt2gG 7Ui3xHVDNXlgWfKsLuJ6d9K+HMDjEbNvoW7LVuQo= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail266c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 05IK4V7L030993; Thu, 18 Jun 2020 20:04:33 +0000 X-Priority: 3 In-Reply-To: X-Mailer: Apple Mail (2.3445.104.14) X-CTCH-RefID: str=0001.0A782F23.5EEBC839.001F, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=A5MSwJeG c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=yPCof4ZbAAAA:8 a=B_gc3-US2GIWvbO2om4A:9 a=CjuIK1q_8ugA:10 Received-SPF: softfail client-ip=91.136.14.55; envelope-from=mattiase@acm.org; helo=mail266c50.megamailservers.eu X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/18 16:04:37 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252323 Archived-At: 18 juni 2020 kl. 21.35 skrev Drew Adams : > But if there are different eyes, screens, whatever, > would it make sense to use a defvar, or even a defcustom, > instead of a defconst? Why decide this definitively > at design time? Does it make sense to hard-code it? Well, it isn't really hard-coded in the sense that it cannot be changed = later on, or be turned into a defcustom; both perfectly possible. = However, I'd rather not get carried away and add yet another = customisable variable before we have more substantial evidence that it = would make sense to do so.