unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Bozhidar Batsov <bozhidar@batsov.com>
To: emacs-devel <emacs-devel@gnu.org>
Subject: [ruby-mode] Private/protected method definition layout in Ruby 2.1
Date: Wed, 15 Jan 2014 16:41:33 +0200	[thread overview]
Message-ID: <0E94BE5F9874463D9B4C2A039A3C24E9@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 887 bytes --]

Ruby 2.1 has made it possible to define private/protected/public methods on a per method basis (because a `def` now returns a symbol instead of nil). It means that now it’s possible to write code like this:

private def map(attribute, to:)
  @rules[attribute] = to
end


We currently don’t support such an indentation scheme, as `def` is always aligned with `end`:

private def map(attribute, to:)
              @rules[attribute] = to
            end


I’m not saying the first alignment is preferable, but it light of recent changes we did to accommodate similar alignment for `if/unless` it seems like a good idea to add a defcustom supporting the first style as well.

vim already added support for it (https://github.com/vim-ruby/vim-ruby/issues/190).

More on the topic can be read here http://www.sitepoint.com/look-ruby-2-1/.

--  
Cheers,
Bozhidar


[-- Attachment #2: Type: text/html, Size: 1794 bytes --]

             reply	other threads:[~2014-01-15 14:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-15 14:41 Bozhidar Batsov [this message]
2014-01-15 16:24 ` [ruby-mode] Private/protected method definition layout in Ruby 2.1 Stefan Monnier
2014-01-15 18:18   ` Dmitry Gutov
2014-01-15 18:51     ` Stefan Monnier
2014-01-16  5:47 ` Dmitry Gutov
2014-01-16 10:15   ` Bozhidar Batsov
2014-01-16 13:37     ` Dmitry Gutov
2014-01-16 14:26       ` Bozhidar Batsov
2014-01-16 18:40         ` Dmitry Gutov
2014-01-16 19:38           ` Bozhidar Batsov
2014-01-17  3:17             ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0E94BE5F9874463D9B4C2A039A3C24E9@gmail.com \
    --to=bozhidar@batsov.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).