From: "Mattias Engdegård" <mattiase@acm.org>
To: emacs-devel <emacs-devel@gnu.org>
Subject: Regexp error scan (March 26)
Date: Tue, 26 Mar 2019 18:38:59 +0100 [thread overview]
Message-ID: <0E648A80-8673-44DB-B481-981474AC3D7C@acm.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 364 bytes --]
This is the latest regexp error scan of Emacs source files, using relint 1.5 (in ELPA now, or when it updates), xr 1.9.
New checks has permitted it to discover more irregularities.
The log contains, at the end, checks found with an experimental version of xr that yielded too many false positives to be useful in general, but these errors seem to be genuine.
[-- Attachment #2: relint.log --]
[-- Type: application/octet-stream, Size: 13328 bytes --]
;; -*- compilation -*-
lisp/erc/erc.el:2526:16: Value from `regexp-quote' cannot be spliced into `[...]'
lisp/mail/footnote.el:366:3: In footnote-hebrew-numeric-regex: Duplicated `ת' inside character alternative (pos 23)
"[אבגדהוזחטיכלמנסעפצקרשתתקתרתשתתתתק']+"
.......................^
lisp/mail/footnote.el:366:3: In footnote-hebrew-numeric-regex: Duplicated `ק' inside character alternative (pos 24)
"[אבגדהוזחטיכלמנסעפצקרשתתקתרתשתתתתק']+"
........................^
lisp/mail/footnote.el:366:3: In footnote-hebrew-numeric-regex: Duplicated `ר' inside character alternative (pos 26)
"[אבגדהוזחטיכלמנסעפצקרשתתקתרתשתתתתק']+"
..........................^
lisp/mail/footnote.el:366:3: In footnote-hebrew-numeric-regex: Duplicated `ת' inside character alternative (pos 27)
"[אבגדהוזחטיכלמנסעפצקרשתתקתרתשתתתתק']+"
...........................^
lisp/mail/footnote.el:366:3: In footnote-hebrew-numeric-regex: Duplicated `ש' inside character alternative (pos 28)
"[אבגדהוזחטיכלמנסעפצקרשתתקתרתשתתתתק']+"
............................^
lisp/mail/footnote.el:366:3: In footnote-hebrew-numeric-regex: Duplicated `ת' inside character alternative (pos 30)
"[אבגדהוזחטיכלמנסעפצקרשתתקתרתשתתתתק']+"
..............................^
lisp/mail/footnote.el:366:3: In footnote-hebrew-numeric-regex: Duplicated `ת' inside character alternative (pos 32)
"[אבגדהוזחטיכלמנסעפצקרשתתקתרתשתתתתק']+"
................................^
lisp/mail/footnote.el:564:27: In call to looking-back: Repetition of repetition (pos 8)
"\\[[0-9]+*]"
.........^
lisp/mail/footnote.el:576:23: In call to looking-at: Repetition of repetition (pos 8)
"\\[[0-9]+*]"
.........^
lisp/mail/footnote.el:841:31: In call to looking-back: Repetition of repetition (pos 8)
"\\[[0-9]+*]"
.........^
lisp/progmodes/verilog-mode.el:2062:3: In verilog-directive-re: Duplicated alternative branch (pos 372)
"\\<\\(`__FILE__\\|`__LINE\\|`begin_keywords\\|`celldefine\\|`default_nettype\\|`define\\|`else\\|`elsif\\|`end_keywords\\|`endcelldefine\\|`endif\\|`ifdef\\|`ifndef\\|`include\\|`line\\|`nounconnected_drive\\|`pragma\\|`resetall\\|`timescale\\|`unconnected_drive\\|`undef\\|`undefineall\\|`case\\|`default\\|`endfor\\|`endprotect\\|`endswitch\\|`endwhile\\|`for\\|`format\\|`if\\|`let\\|`protect\\|`switch\\|`timescale\\|`time_scale\\|`while\\)\\>"
........................................................................................................................................................................................................................................................................................................................................................................................................................^
lisp/progmodes/verilog-mode.el:2412:3: In verilog-assignment-operator-re: Duplicated alternative branch (pos 84)
"\\(=\\|\\+=\\|-=\\|\\*=\\|/=\\|%=\\|&=\\||=\\|\\^=\\|<<=\\|>>=\\|<<<=\\|>>>=\\|<=\\|==\\|!=\\|===\\|!==\\|<=\\|>=\\|==\\?\\|!=\\?\\|<->\\|->\\|->>\\||->\\||=>\\|#-#\\|#=#\\|:=\\|:/\\)"
..........................................................................................................^
lisp/progmodes/verilog-mode.el:2430:3: In verilog-assignment-operation-re: Duplicated alternative branch (pos 94)
"\\(^.*?\\)\\B\\(=\\|\\+=\\|-=\\|\\*=\\|/=\\|%=\\|&=\\||=\\|\\^=\\|<<=\\|>>=\\|<<<=\\|>>>=\\|<=\\|==\\|!=\\|===\\|!==\\|<=\\|>=\\|==\\?\\|!=\\?\\|<->\\|->\\|->>\\||->\\||=>\\|#-#\\|#=#\\|:=\\|:/\\)\\B"
.......................................................................................................................^
lisp/progmodes/verilog-mode.el:2486:3: In verilog-auto-end-comment-lines-re: Duplicated alternative branch (pos 374)
"\\(\\<\\(`__FILE__\\|`__LINE\\|`begin_keywords\\|`celldefine\\|`default_nettype\\|`define\\|`else\\|`elsif\\|`end_keywords\\|`endcelldefine\\|`endif\\|`ifdef\\|`ifndef\\|`include\\|`line\\|`nounconnected_drive\\|`pragma\\|`resetall\\|`timescale\\|`unconnected_drive\\|`undef\\|`undefineall\\|`case\\|`default\\|`endfor\\|`endprotect\\|`endswitch\\|`endwhile\\|`for\\|`format\\|`if\\|`let\\|`protect\\|`switch\\|`timescale\\|`time_scale\\|`while\\)\\>\\)\\|\\(\\<\\(begin\\|else\\|end\\|endcase\\|endclass\\|endclocking\\|endgroup\\|endfunction\\|endmodule\\|endprogram\\|endprimitive\\|endinterface\\|endpackage\\|endsequence\\|endproperty\\|endspecify\\|endtable\\|endtask\\|join\\|join_any\\|join_none\\|module\\|macromodule\\|primitive\\|interface\\|package\\)\\>\\)"
...........................................................................................................................................................................................................................................................................................................................................................................................................................^
lisp/progmodes/verilog-mode.el:2946:3: In verilog-preprocessor-re: Escaped non-special character `/' (pos 423)
"\\(?:\\<\\(`__FILE__\\|`__LINE__\\|`celldefine\\|`else\\|`end_keywords\\|`endcelldefine\\|`endif\\|`nounconnected_drive\\|`resetall\\|`unconnected_drive\\|`undefineall\\)\\>\\)\\|\\(?:\\<\\(`elsif\\|`ifn?def\\|`undef\\|`default_nettype\\|`begin_keywords\\)\\>\\s-\\)\\|\\(?:\\<\\(`line\\)\\>\\s-+[0-9]+\\s-+\"[^\"]+\"\\s-+[012]\\)\\|\\(?:\\<\\(`include\\)\\>\\s-+\\(?:\"[^\"]+\"\\|<[^>]+>\\)\\)\\|\\(?:\\<\\(`pragma\\)\\>\\s-+.+$\\)\\|\\(?:\\<\\(`timescale\\)\\>\\s-+10\\{0,2\\}\\s-*[munpf]?s\\s-*\\/\\s-*10\\{0,2\\}\\s-*[munpf]?s\\)\\|\\(?:\\<\\(`define\\|`if\\)\\>\\s-+\\(?:.*?\\(?:\n.*\\)*?\\)\\(?:\n\\s-*\n\\|\\'\\)\\)\\|\\(?:\\<`\\w+\\>\\s-*(\\(?:.*?\\(?:\n.*\\)*?\\)\\(?:\n\\s-*\n\\|\\'\\)\\)"
.................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................^
lisp/progmodes/verilog-mode.el:5562:57: In call to looking-at: Duplicated alternative branch (pos 377)
"[ \t]*\\<\\(`__FILE__\\|`__LINE\\|`begin_keywords\\|`celldefine\\|`default_nettype\\|`define\\|`else\\|`elsif\\|`end_keywords\\|`endcelldefine\\|`endif\\|`ifdef\\|`ifndef\\|`include\\|`line\\|`nounconnected_drive\\|`pragma\\|`resetall\\|`timescale\\|`unconnected_drive\\|`undef\\|`undefineall\\|`case\\|`default\\|`endfor\\|`endprotect\\|`endswitch\\|`endwhile\\|`for\\|`format\\|`if\\|`let\\|`protect\\|`switch\\|`timescale\\|`time_scale\\|`while\\)\\>"
..............................................................................................................................................................................................................................................................................................................................................................................................................................^
lisp/progmodes/verilog-mode.el:6215:37: In call to looking-at: Duplicated alternative branch (pos 377)
"[ \t]*\\<\\(`__FILE__\\|`__LINE\\|`begin_keywords\\|`celldefine\\|`default_nettype\\|`define\\|`else\\|`elsif\\|`end_keywords\\|`endcelldefine\\|`endif\\|`ifdef\\|`ifndef\\|`include\\|`line\\|`nounconnected_drive\\|`pragma\\|`resetall\\|`timescale\\|`unconnected_drive\\|`undef\\|`undefineall\\|`case\\|`default\\|`endfor\\|`endprotect\\|`endswitch\\|`endwhile\\|`for\\|`format\\|`if\\|`let\\|`protect\\|`switch\\|`timescale\\|`time_scale\\|`while\\)\\>"
..............................................................................................................................................................................................................................................................................................................................................................................................................................^
lisp/progmodes/verilog-mode.el:6248:33: In call to looking-at: Duplicated alternative branch (pos 377)
"[ \t]*\\<\\(`__FILE__\\|`__LINE\\|`begin_keywords\\|`celldefine\\|`default_nettype\\|`define\\|`else\\|`elsif\\|`end_keywords\\|`endcelldefine\\|`endif\\|`ifdef\\|`ifndef\\|`include\\|`line\\|`nounconnected_drive\\|`pragma\\|`resetall\\|`timescale\\|`unconnected_drive\\|`undef\\|`undefineall\\|`case\\|`default\\|`endfor\\|`endprotect\\|`endswitch\\|`endwhile\\|`for\\|`format\\|`if\\|`let\\|`protect\\|`switch\\|`timescale\\|`time_scale\\|`while\\)\\>"
..............................................................................................................................................................................................................................................................................................................................................................................................................................^
lisp/progmodes/verilog-mode.el:6313:17: In call to looking-at: Duplicated alternative branch (pos 377)
"[ \t]*\\<\\(`__FILE__\\|`__LINE\\|`begin_keywords\\|`celldefine\\|`default_nettype\\|`define\\|`else\\|`elsif\\|`end_keywords\\|`endcelldefine\\|`endif\\|`ifdef\\|`ifndef\\|`include\\|`line\\|`nounconnected_drive\\|`pragma\\|`resetall\\|`timescale\\|`unconnected_drive\\|`undef\\|`undefineall\\|`case\\|`default\\|`endfor\\|`endprotect\\|`endswitch\\|`endwhile\\|`for\\|`format\\|`if\\|`let\\|`protect\\|`switch\\|`timescale\\|`time_scale\\|`while\\)\\>"
..............................................................................................................................................................................................................................................................................................................................................................................................................................^
lisp/textmodes/css-mode.el:952:32: In css-font-lock-keywords: Repetition of repetition (pos 27)
"^[ \t]*\\(:root\\)\\(?:[\n \t]*\\)*{"
..................................^
lisp/textmodes/css-mode.el:952:32: In css-font-lock-keywords: Escaped non-special character `:' (pos 518)
"^[ \t]*\\([^@/:{}() \t\n][^:{}()]*\\(?:\\(:\\(a\\(?:ctive\\|fter\\)\\|before\\|checked\\|d\\(?:efault\\|isabled\\)\\|e\\(?:mpty\\|nabled\\)\\|f\\(?:irst\\(?:-\\(?:child\\|l\\(?:etter\\|ine\\)\\|of-type\\)\\)?\\|ocus\\(?:-within\\)?\\)\\|hover\\|in\\(?:-range\\|determinate\\|valid\\)\\|l\\(?:a\\(?:ng\\|st-\\(?:child\\|of-type\\)\\)\\|eft\\|ink\\)\\|n\\(?:ot\\|th-\\(?:child\\|last-\\(?:child\\|of-type\\)\\|of-type\\)\\)\\|o\\(?:nly-\\(?:child\\|of-type\\)\\|ptional\\|ut-of-range\\)\\|r\\(?:e\\(?:ad-\\(?:only\\|write\\)\\|quired\\)\\|\\(?:igh\\|oo\\)t\\)\\|scope\\|target\\|v\\(?:\\(?:ali\\|isite\\)d\\)\\)\\|\\::\\(after\\|before\\|first-l\\(?:etter\\|ine\\)\\)\\)\\(?:([^)]+)\\)?[^:{}()\n]*\\)*\\)\\(?:\n[ \t]*\\)*{"
....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................^
lisp/textmodes/picture.el:428:41: Value from `regexp-quote' cannot be spliced into `[...]'
lisp/textmodes/picture.el:458:19: `regexp-quote' cannot be used for arguments to `skip-chars-backward'
lisp/textmodes/picture.el:463:30: Value from `regexp-quote' cannot be spliced into `[...]'
;; These were found using an experimental and unreleased version of xr.
lisp/vc/diff-mode.el:2215:19: In call to re-search-forward: Unintuitive range `+-<' (pos 3)
"\n[!+-<>]\\(-- [0-9]+\\(,[0-9]+\\)? ----\n\\( .*\n\\)*[+]\\)?"
....^
lisp/speedbar.el:2852:42: In call to re-search-forward: Unintuitive range `+-?' (pos 21)
"^\\([0-9]+\\):\\s-*[[<][+-?][]>] "
........................^
lisp/speedbar.el:2903:42: In call to re-search-forward: Unintuitive range `+-?' (pos 19)
"^\\([0-9]+\\):\\s-*\\[[+-?]\\] "
.......................^
lisp/woman.el:3514:26: In call to looking-at: Unintuitive range `+-/' (pos 1)
"[+-/*%]"
.^
lisp/net/webjump.el:345:39: In call to string-match: Two-character range `.-/' (pos 8)
"[a-zA-Z_.-/]"
........^
lisp/align.el:386:3: In align-rules-list (perl-assignment): Two-character range `*-+' (pos 6)
"[^=!^&*-+<>/| \t\n]\\(\\s-*\\)=[~>]?\\(\\s-*\\)\\([^>= \t\n]\\|$\\)"
......^
next reply other threads:[~2019-03-26 17:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 17:38 Mattias Engdegård [this message]
2019-03-27 2:10 ` Regexp error scan (March 26) Paul Eggert
2019-03-27 3:43 ` Basil L. Contovounesios
2019-03-27 9:14 ` Mattias Engdegård
2019-03-27 13:55 ` Andy Moreton
2019-03-27 14:36 ` Stefan Monnier
2019-03-27 14:41 ` Mattias Engdegård
2019-03-27 14:45 ` Stefan Monnier
2019-03-27 14:49 ` Noam Postavsky
2019-03-27 15:45 ` Mattias Engdegård
2019-03-27 15:48 ` Stefan Monnier
2019-03-27 18:50 ` Paul Eggert
2019-03-27 15:28 ` Damien Collard
2019-03-27 12:09 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0E648A80-8673-44DB-B481-981474AC3D7C@acm.org \
--to=mattiase@acm.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).