From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add support for parsing column numbers in Visual Studio messages Date: Sun, 26 Jul 2020 17:52:32 +0200 Message-ID: <0D8E28C4-DB62-4499-8364-4EEA91D8DB29@acm.org> References: Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.15\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13288"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: =?utf-8?Q?Daniel_Mart=C3=ADn?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jul 26 17:53:31 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jzixu-0003Li-Uh for ged-emacs-devel@m.gmane-mx.org; Sun, 26 Jul 2020 17:53:30 +0200 Original-Received: from localhost ([::1]:55656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jzixt-0005og-T4 for ged-emacs-devel@m.gmane-mx.org; Sun, 26 Jul 2020 11:53:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44328) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jzix8-0005DB-1U for emacs-devel@gnu.org; Sun, 26 Jul 2020 11:52:42 -0400 Original-Received: from mail152c50.megamailservers.eu ([91.136.10.162]:48434 helo=mail50c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jzix5-00068n-VJ for emacs-devel@gnu.org; Sun, 26 Jul 2020 11:52:41 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1595778755; bh=LTnS0KRIeShzVuxUgnLuO1zQ0tbc+G+OHPDQgvJEPYw=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=STfmK6WpJcoLsbeM9UKuddKF0ONJ3/qHdyrkVF+C0kD+KvXonMGZVptRQDtmty3LK hDO+3olagMcaE5fxhmx0sNi8kzvbkB+kbgT+e74M+90SFHiOBIRest6jRZ4FW1Jmui qRJX0EQ2h2dpcVku4GBGrKmmuRP5EZXKvdk7PH9Q= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-4e4ae655.032-75-73746f71.bbcust.telenor.se [85.230.74.78]) (authenticated bits=0) by mail50c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 06QFqXlb028632; Sun, 26 Jul 2020 15:52:35 +0000 In-Reply-To: X-Mailer: Apple Mail (2.3445.104.15) X-CTCH-RefID: str=0001.0A782F16.5F1DA6C3.0028:SCFSTAT68638221, ss=1, re=-4.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: -4.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=NoevjPVJ c=1 sm=1 tr=0 a=klNLuyVZdLUgl+K5Uafb2A==:117 a=klNLuyVZdLUgl+K5Uafb2A==:17 a=IkcTkHD0fZMA:10 a=M51BFTxLslgA:10 a=QpaiKtn9qpVSLtMtUggA:9 a=QEXdDO2ut3YA:10 Received-SPF: softfail client-ip=91.136.10.162; envelope-from=mattiase@acm.org; helo=mail50c50.megamailservers.eu X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/26 11:52:35 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665, URIBL_BLOCKED=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253262 Archived-At: 26 juli 2020 kl. 17.22 skrev Daniel Mart=C3=ADn : > The problem seems to happen because the regular expression for MSVC in = compile.el doesn't take into account column numbers. Attached is a = proposed patch to implement support for it. Thank you! This looks all right. Can you confirm that the column = numbering works like in GCC -- ie, the leftmost column is 1, not 0?