From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: Tree-sitter integration on feature/tree-sitter Date: Wed, 29 Jun 2022 08:35:47 -0700 Message-ID: <0B3A5C1B-94D4-4A77-A3A1-CE9AC15C8EBC@gmail.com> References: <874k04lp9x.fsf@gmail.com> <87wnd0pokm.fsf@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16958"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Theodor Thornhill , Stefan Monnier , Daniel Colascione , emacs-devel@gnu.org To: Yoav Marco Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 29 17:38:35 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o6Zlz-0004HR-M8 for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Jun 2022 17:38:35 +0200 Original-Received: from localhost ([::1]:41494 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o6Zly-0006jr-HF for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Jun 2022 11:38:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33286) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6ZjO-0003y7-KX for emacs-devel@gnu.org; Wed, 29 Jun 2022 11:35:54 -0400 Original-Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]:40899) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o6ZjM-0005RZ-ML; Wed, 29 Jun 2022 11:35:54 -0400 Original-Received: by mail-pl1-x633.google.com with SMTP id b2so7463111plx.7; Wed, 29 Jun 2022 08:35:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=sE9AwjFZjry+laPKeAvsiDbdoxNPDOXdpwx/S62rq+s=; b=hujMhwmBuankxs73+lLYXzcmCdCoPyYLenHRYBRn5uAVh+VDhps2Fwkr73nkJ06tlz jnaY3ZRcoUR+FX6hT23hx5Saf9Q3Fzpy9TUSyHyRFU+/YZB/V217z7Yts/lxEuzWt0K4 Iyujw8weISgXW03IahgjZTovngCxMcmeIChgFma1diW9XRgAGK2r5gCr/PaX6TXHg/4O b5mKjlOj4ZHOgSLE9iKipU4S/iJwFnBkHPjNT9v2YueIFOC+VF7m+vU9Ep8XmderwKuV Hxj/Tr/fnf7z4zRGci9B7FGgebCBMU1ugyn7eD/fkdnYA/qJBs2w/D35CKwLc1pGYz4z 05yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=sE9AwjFZjry+laPKeAvsiDbdoxNPDOXdpwx/S62rq+s=; b=niiu1EeHpq2SauXFY9X7Y+BP0c+3+/eD9gCwSow3RF7B2idOfpmhY4NxOJIOsoIUIn bDRT5+8sqKods9mdm00gYhbnK3qcYN3KgfAnyq5eH6SGQiA4GCT8gmfNjQn2S+oA/PnD /DPXV9c/2HsSLLLCSjmVhc4wfBEZ7/ajfwe3fyq6McSnaP338PsN/KH3GVTN0AGcvAMB OFrEWyGunZBdmcNx/fo+xJ/Y1HAItKEBju9xLAzjLtUBOFM8lwaALLPO34gpZiqzT+Ix 6ZtnfcHHuIeLGC6qIIOkk0SL6WAXLKUNW0qjN5G9JxjUIGg9WFH7CPgdODOaOfDVYId+ ud8A== X-Gm-Message-State: AJIora8VkWA2ywTuOPMdsXd15bWkG/EgakPWuM+Q0QgNFpGlyFtHFv+R jwc7Wjuu5AH20C9fNRVid4k= X-Google-Smtp-Source: AGRyM1tqZQi7znOl5f/Oc/28OJg2y8wot8dnS28jbQFssLxez/T2m1PhqBA90y1Ubu7BAojGCqLCgg== X-Received: by 2002:a17:902:b188:b0:16b:9dbd:319a with SMTP id s8-20020a170902b18800b0016b9dbd319amr4549275plr.9.1656516949674; Wed, 29 Jun 2022 08:35:49 -0700 (PDT) Original-Received: from smtpclient.apple (rrcs-98-153-7-54.west.biz.rr.com. [98.153.7.54]) by smtp.gmail.com with ESMTPSA id h28-20020a63121c000000b004088f213f68sm11399447pgl.56.2022.06.29.08.35.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Jun 2022 08:35:49 -0700 (PDT) In-Reply-To: <87wnd0pokm.fsf@gmail.com> X-Mailer: Apple Mail (2.3696.100.31) Received-SPF: pass client-ip=2607:f8b0:4864:20::633; envelope-from=casouri@gmail.com; helo=mail-pl1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291719 Archived-At: > On Jun 28, 2022, at 12:35 PM, Yoav Marco wrote: >=20 > Whoops, my mail turned out garbaled, sorry. >=20 > Corrected version: >=20 > Yuan Fu writes: >>>> Also I think it makes more sense if you just fork it rather than = making a PR. >>>=20 >>> Yeah, I don't really expect it to be merged. >>>=20 >>> My reason for the PR is for it to be more of a talking point about >>> collaboration between treesit and tree-sitter-langs. I used >>> elisp-tree-sitter before trying the feature/tree-sitter branch, and = I >>> really like the richness of its highlighting (which comes from the >>> highlights.scm files). >>=20 >> Do you already have the highlighting working for treesit? >=20 > I only checked a few, but yeah, and the syntax highlighting is very = pretty. Cool. >=20 >> If so, maybe you can packages it in a separate package and publish = it, >> it would be a nice demonstration of treesit features. >=20 > I'm not comfortable with doing that, the query patterns update > frequently upstream (though ubolonton has been busy lately) and all = I'm > doing is post-process them a little. >=20 > I could try to make a self-updating repo or something with CI - > https://github.com/meain/evil-textobj-tree-sitter for example pulls > highlights.scm changes from nvim's repo weeky. >=20 > Is that worth it? I thought people could just as easily use my PR > branch of tree-sitter-langs. That also takes care of fetching = grammars. That would be a lot of work. Using your PR repo is fine, I think. I can = just refer to your fork. Thanks, Yuan=