Re: emacs-29 1ef8b90ae06: Simplify imenu setup for {cmake, dockerfile}-ts-modes

[Yuan Fu <casouri@gmail.com>]

Hey sorry, I didn’t see this thread. I did forget to include the bug number, will make sure I do next time.

> On Jan 27, 2024, at 9:57 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>> From: Stefan Kangas <stefankangas@gmail.com>
>> Date: Sat, 27 Jan 2024 14:40:02 -0800
>> Cc: emacs-devel@gnu.org, dev@rjt.dev
>> 
>> Po Lu <luangruo@yahoo.com> writes:
>> 
>>> Yes, please.  Furthermore, if such bugfix cannot be described as
>>> anything but a simplification (with a correspondingly large diff), there
>>> should be another approach safer for the release branch.
>> 
>> We must not get overly rigid about that.  It takes extra work, and it
>> will not always be clear that it's worth the effort.  Often it is, but
>> sometimes it isn't.  We tend to decide on a case-by-case basis.
>> 
>> Furthermore, please keep in mind that Yuan is both the principal author
>> and maintainer of our treesitter support.  He's closer to the code than
>> anyone else, and is thus in the best position to make such judgement
>> calls.  I see no reason to second-guess him here, myself.
>> 
>> If there are any specific technical arguments for why this particular
>> change must not be installed on emacs-29, then let's hear them.  Neither
>> generalizations nor administrative arguments will cut it, I think.
> 
> My arguments for not objecting to this change on the release branch:
> 
> . the change only affects these two modes
> . the modes are new in Emacs 29, so their fixes should preferably be
>   in Emacs 29 as well

The fix comes together with the simplification, so you can’t simply pick it out and only apply the fix. It’ll be a rather wasteful use of time and more error-prone. All the code that the patch removed are copy-paste boilerplate, and the code that replaces them delegate most of the work to existing functions. So I don’t think it’ll destabilize emacs-29.

Yuan