From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Adrian Robert Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] Changes to emacs/src/xfaces.c,v Date: Fri, 1 Aug 2008 14:56:59 -0400 Message-ID: <0A183FF1-106B-431C-9110-DFF1912B771B@gmail.com> References: <48933E82.4000804@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v926) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1217617071 17824 80.91.229.12 (1 Aug 2008 18:57:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 1 Aug 2008 18:57:51 +0000 (UTC) Cc: Juanma Barranquero , Emacs Development To: "Lennart Borgman (gmail)" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 01 20:58:40 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KOzpg-0007oI-O3 for ged-emacs-devel@m.gmane.org; Fri, 01 Aug 2008 20:58:33 +0200 Original-Received: from localhost ([127.0.0.1]:58784 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KOzol-0002ys-3S for ged-emacs-devel@m.gmane.org; Fri, 01 Aug 2008 14:57:35 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KOzog-0002xp-Cu for emacs-devel@gnu.org; Fri, 01 Aug 2008 14:57:30 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KOzoe-0002x3-QE for emacs-devel@gnu.org; Fri, 01 Aug 2008 14:57:29 -0400 Original-Received: from [199.232.76.173] (port=37800 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KOzoe-0002x0-Mo for emacs-devel@gnu.org; Fri, 01 Aug 2008 14:57:28 -0400 Original-Received: from wr-out-0506.google.com ([64.233.184.232]:65518) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KOzoe-0007f4-5m for emacs-devel@gnu.org; Fri, 01 Aug 2008 14:57:28 -0400 Original-Received: by wr-out-0506.google.com with SMTP id c30so901473wra.14 for ; Fri, 01 Aug 2008 11:57:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:cc:message-id:from:to :in-reply-to:content-type:content-transfer-encoding:mime-version :subject:date:references:x-mailer; bh=59lKTInPs7GhG3478/BfQjC36dcu0euwOShZwp7j/7o=; b=Zfyoca0SzDWxrrIRBH9jPwXsj5TVERUOgt7C4d35I1ARovRdy952seU4JjUs575qim 48ZFt0fXER8a6UQNmqXuFbgyal5qP6pEh/6PlK3uepWJIi3CsGFKFcnIETX4lw96STru z9lLm4N/O2s4SyPvKntiYMChzgXMyYKO3QmEw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=cc:message-id:from:to:in-reply-to:content-type :content-transfer-encoding:mime-version:subject:date:references :x-mailer; b=McEFPTTL5qW6y1bnHwr9VXB4ittP4lAy+IHUzRVZPv3H2DaPH1RrS/T73X/J6RPb5J WXWgfutsgJgP0jrPgCGgclQYA5Mc+w3MLvzLFfZZOia6sL9XkV4ZryObhgfFr3nPGHwI gX56H/wE5D0ECdC+kmaIuuE114Tn4bQftMWNw= Original-Received: by 10.90.33.5 with SMTP id g5mr511904agg.113.1217617044493; Fri, 01 Aug 2008 11:57:24 -0700 (PDT) Original-Received: from ?10.0.1.200? ( [97.73.30.9]) by mx.google.com with ESMTPS id 20sm2890083agb.38.2008.08.01.11.57.13 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 01 Aug 2008 11:57:23 -0700 (PDT) In-Reply-To: <48933E82.4000804@gmail.com> X-Mailer: Apple Mail (2.926) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:101913 Archived-At: On Aug 1, 2008, at 12:49 PM, Lennart Borgman (gmail) wrote: > Adrian Robert wrote: >> On Aug 1, 2008, at 10:54 AM, Juanma Barranquero wrote: >>> On Fri, Aug 1, 2008 at 13:48, Adrian Robert >> > wrote: >>> >>>> + cmap = Fcons (Fcons (build_string (name), >>>> + make_number ((red << 16) | >>>> (green << 8) | blue)), >>>> + cmap); >>> >>> This is a change over the original function, and in fact it doesn't >>> work on Windows because of byte order issues. >>> Either the attached patch, or adding a new RGB_TO_EMACS_INT macro, >>> is needed. >> Thanks, in interest of heading off problems, implemented quickest >> fix for now, which is committing patch as-is. (Sorry about any >> disruption, I could not find any #def for RGB but assumed it was >> like what I put there.) If folks would prefer a macro we should >> find all the places it might be used and figure out the right file >> to put it in.. > > > Adrian, could you please explain what will happen when this code is > run on w32? I wasn't trying to change any code, just accidentally introduced a non- workalike for a platform-defined macro. Juanma's patch restores the previous version of the line I changed under Windows. Again, apologies for the temporary bug.