From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: [Emacs-diffs] master 51e7e46: Font-lock elisp macros/special forms dynamically Date: Sun, 15 Mar 2015 10:20:57 -0700 (PDT) Message-ID: <09b8ca7b-9906-44d5-b831-410879ecbccf@default> References: <20150315082509.21193.18465@vcs.savannah.gnu.org> <55054CE9.6010702@dancol.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1426440087 4339 80.91.229.3 (15 Mar 2015 17:21:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 15 Mar 2015 17:21:27 +0000 (UTC) To: Daniel Colascione , emacs-devel@gnu.org, Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 15 18:21:16 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YXCDz-0004OE-Tx for ged-emacs-devel@m.gmane.org; Sun, 15 Mar 2015 18:21:16 +0100 Original-Received: from localhost ([::1]:44087 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXCDz-0007RL-6R for ged-emacs-devel@m.gmane.org; Sun, 15 Mar 2015 13:21:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36091) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXCDw-0007Pr-DI for emacs-devel@gnu.org; Sun, 15 Mar 2015 13:21:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXCDt-0003Up-7I for emacs-devel@gnu.org; Sun, 15 Mar 2015 13:21:12 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:29909) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXCDt-0003Uh-0Z; Sun, 15 Mar 2015 13:21:09 -0400 Original-Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t2FHKvna025677 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 15 Mar 2015 17:20:58 GMT Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id t2FHKute008249 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 15 Mar 2015 17:20:57 GMT Original-Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by userv0121.oracle.com (8.13.8/8.13.8) with ESMTP id t2FHKu6N009909; Sun, 15 Mar 2015 17:20:56 GMT In-Reply-To: <55054CE9.6010702@dancol.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8.2 (807160) [OL 12.0.6691.5000 (x86)] X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 141.146.126.69 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183881 Archived-At: > Is it really a good idea to highlight *all* macros? Many are meant to be > used just like functions and have the same semantics. Instead of > updating a big macro regexp after load, there should be a `declare' > attribute that would let specific macros (and functions) opt into being > fontified specially. >=20 > As it is, I'm going to have to disable this functionality locally. +1 Just what is this additional highlighting really trying to accomplish? What problem is it trying to fix? Presumably this corresponds to bug #20096, whose sole motivation was said to be: "I like the addition of if-let and when-let in subr-x.el. However, they should also be highlighted as keywords if subr-x is loaded." To that "I like", the "fix" proposed by Stefan was: "change elisp-mode's font-lock rules so they check obarray for macros", and highlight them all. As Stefan put it: "That should kill several birds with a single (big) stone." A big stone, indeed. But what are the "several birds" that need to be killed, and why? No mention. >From two unhighlighted macros that one user wants highlighted, we've moved to highlighting all macros. No discussion of the why-do-this; discussion only of how-to-do-it. If you must introduce such exhuberent highlighting, perhaps you would consider throttling it via `font-lock-maximum-decoration'? (And maybe consider highlighting only those two "I like" macros?) Yes to Daniel's "let specific...opt into being fontified specially". http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D20096