Re: no empty (zero) string predicate in Elisp

Re: no empty (zero) string predicate in Elisp

[Nicolas Petton]

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]


Nicolas Petton writes:

> You can use `string-empty-p' from subr-x.el or `seq-empty-p' from
> seq.el (which works on all sequence data types).
>
> seq.el will be included in Emacs 25.1, but in the meantime you can
> install it from GNU Elpa.

BTW, would it be wise to obsolete `string-reverse' and `string-empty-p'
From subr-x in favor of `seq-reverse' and `seq-empty-p' which are much
more generic?

Nico
-- 
Nicolas Petton
http://nicolas-petton.fr

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]

Re: no empty (zero) string predicate in Elisp

[Bozhidar Batsov]

[-- Attachment #1: Type: text/plain, Size: 683 bytes --]

I'd advise against this, as my intuition would always be to search for
something starting with `string-` when dealing with strings.

On 16 May 2015 at 12:23, Nicolas Petton <nicolas@petton.fr> wrote:

>
> Nicolas Petton writes:
>
> > You can use `string-empty-p' from subr-x.el or `seq-empty-p' from
> > seq.el (which works on all sequence data types).
> >
> > seq.el will be included in Emacs 25.1, but in the meantime you can
> > install it from GNU Elpa.
>
> BTW, would it be wise to obsolete `string-reverse' and `string-empty-p'
> From subr-x in favor of `seq-reverse' and `seq-empty-p' which are much
> more generic?
>
> Nico
> --
> Nicolas Petton
> http://nicolas-petton.fr
>

[-- Attachment #2: Type: text/html, Size: 1185 bytes --]

Re: no empty (zero) string predicate in Elisp

[Bozhidar Batsov]

[-- Attachment #1: Type: text/plain, Size: 843 bytes --]

Btw, `string-reverse` was already obsoleted by `reverse`.

On 16 May 2015 at 16:22, Bozhidar Batsov <bozhidar@batsov.com> wrote:

> I'd advise against this, as my intuition would always be to search for
> something starting with `string-` when dealing with strings.
>
> On 16 May 2015 at 12:23, Nicolas Petton <nicolas@petton.fr> wrote:
>
>>
>> Nicolas Petton writes:
>>
>> > You can use `string-empty-p' from subr-x.el or `seq-empty-p' from
>> > seq.el (which works on all sequence data types).
>> >
>> > seq.el will be included in Emacs 25.1, but in the meantime you can
>> > install it from GNU Elpa.
>>
>> BTW, would it be wise to obsolete `string-reverse' and `string-empty-p'
>> From subr-x in favor of `seq-reverse' and `seq-empty-p' which are much
>> more generic?
>>
>> Nico
>> --
>> Nicolas Petton
>> http://nicolas-petton.fr
>>
>
>

[-- Attachment #2: Type: text/html, Size: 1644 bytes --]

Re: no empty (zero) string predicate in Elisp

[Bozhidar Batsov]

[-- Attachment #1: Type: text/plain, Size: 1051 bytes --]

And one more thing - `string-empty-p` uses string comparison (`string=`)
instead of length comparison.

On 16 May 2015 at 16:28, Bozhidar Batsov <bozhidar@batsov.com> wrote:

> Btw, `string-reverse` was already obsoleted by `reverse`.
>
> On 16 May 2015 at 16:22, Bozhidar Batsov <bozhidar@batsov.com> wrote:
>
>> I'd advise against this, as my intuition would always be to search for
>> something starting with `string-` when dealing with strings.
>>
>> On 16 May 2015 at 12:23, Nicolas Petton <nicolas@petton.fr> wrote:
>>
>>>
>>> Nicolas Petton writes:
>>>
>>> > You can use `string-empty-p' from subr-x.el or `seq-empty-p' from
>>> > seq.el (which works on all sequence data types).
>>> >
>>> > seq.el will be included in Emacs 25.1, but in the meantime you can
>>> > install it from GNU Elpa.
>>>
>>> BTW, would it be wise to obsolete `string-reverse' and `string-empty-p'
>>> From subr-x in favor of `seq-reverse' and `seq-empty-p' which are much
>>> more generic?
>>>
>>> Nico
>>> --
>>> Nicolas Petton
>>> http://nicolas-petton.fr
>>>
>>
>>
>

[-- Attachment #2: Type: text/html, Size: 2137 bytes --]

Re: no empty (zero) string predicate in Elisp

[Stefan Monnier]

> BTW, would it be wise to obsolete `string-reverse' and `string-empty-p'
> From subr-x in favor of `seq-reverse' and `seq-empty-p' which are much
> more generic?

string-reverse i already marked as obsolete.  As for string-empty-p, I'm
not sure, because it depends on whether you care about the fact that the
arg is a string (e.g. you care about the fact that (string-empty-p nil)
is nil rather than (seq-empty-p nil) being t).


        Stefan

Re: no empty (zero) string predicate in Elisp

[Eli Zaretskii]

> Date: Sat, 16 May 2015 16:36:18 +0300
> From: Bozhidar Batsov <bozhidar@batsov.com>
> Cc: help-gnu-emacs@gnu.org, Emanuel Berg <embe8573@student.uu.se>,
> 	emacs-devel <emacs-devel@gnu.org>
> 
> And one more thing - `string-empty-p` uses string comparison (`string=`)
> instead of length comparison. 

Are you saying that length comparison is better, or vice versa?

RE: no empty (zero) string predicate in Elisp

[Drew Adams]

C'mon guys, please don't cc both lists.  (This belongs
in emacs-devel, IMHO, but please pick one list.)

Re: no empty (zero) string predicate in Elisp

[Bozhidar Batsov]

[-- Attachment #1: Type: text/plain, Size: 522 bytes --]

On 16 May 2015 at 16:46, Eli Zaretskii <eliz@gnu.org> wrote:

> > Date: Sat, 16 May 2015 16:36:18 +0300
> > From: Bozhidar Batsov <bozhidar@batsov.com>
> > Cc: help-gnu-emacs@gnu.org, Emanuel Berg <embe8573@student.uu.se>,
> >       emacs-devel <emacs-devel@gnu.org>
> >
> > And one more thing - `string-empty-p` uses string comparison (`string=`)
> > instead of length comparison.
>
> Are you saying that length comparison is better, or vice versa?
>

I'm saying that they are different. I prefer the string= comparison.

[-- Attachment #2: Type: text/html, Size: 1097 bytes --]