From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Victor Orlikowski Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] v2: Fixes to allow erc-dcc-get-filter to work properly Date: Sun, 17 Feb 2019 18:57:16 +0000 Message-ID: <087AD903-C49F-4D5A-A136-2ED030F4C6E5@duke.edu> References: <3FCFBDED-9040-41B1-9686-30773CA6EC08.notmuch@neverland>, <837ee1o461.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="231210"; mail-complaints-to="usenet@blaine.gmane.org" Cc: "emacs-devel@gnu.org" To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 17 19:58:15 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gvRdi-000xna-DJ for ged-emacs-devel@m.gmane.org; Sun, 17 Feb 2019 19:58:10 +0100 Original-Received: from localhost ([127.0.0.1]:45348 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gvRdc-0005Zk-3A for ged-emacs-devel@m.gmane.org; Sun, 17 Feb 2019 13:58:04 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33997) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gvRcv-0005Zc-CM for emacs-devel@gnu.org; Sun, 17 Feb 2019 13:57:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gvRcu-0003TF-Gf for emacs-devel@gnu.org; Sun, 17 Feb 2019 13:57:21 -0500 Original-Received: from smtp-gw-09.oit.duke.edu ([152.3.189.235]:34322 helo=mail-gw-09.oit.duke.edu) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gvRct-0003SE-Ad; Sun, 17 Feb 2019 13:57:19 -0500 Original-Received: from smtpgw-07.oit.duke.edu (fitz-bigip-0102-ltm-a-mx-gw-floater.oit.duke.edu [10.136.241.66]) by mail-gw-09.oit.duke.edu (8.16.0.27/8.16.0.27) with ESMTPS id x1HIvITt025038 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 17 Feb 2019 13:57:18 -0500 Original-Received: from NAM05-CO1-obe.outbound.protection.outlook.com (mail-co1nam05lp2051.outbound.protection.outlook.com [104.47.48.51]) by smtpgw-07.oit.duke.edu (8.16.0.27/8.16.0.27) with ESMTPS id x1HIvHBw028151 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 17 Feb 2019 13:57:17 -0500 Original-Received: from BN6PR05MB3556.namprd05.prod.outlook.com (10.174.234.157) by BN6PR05MB3297.namprd05.prod.outlook.com (10.174.233.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.11; Sun, 17 Feb 2019 18:57:16 +0000 Original-Received: from BN6PR05MB3556.namprd05.prod.outlook.com ([fe80::4c98:382e:7a29:289e]) by BN6PR05MB3556.namprd05.prod.outlook.com ([fe80::4c98:382e:7a29:289e%4]) with mapi id 15.20.1643.008; Sun, 17 Feb 2019 18:57:16 +0000 Thread-Topic: [PATCH] v2: Fixes to allow erc-dcc-get-filter to work properly Thread-Index: AQHUwXTX35b9f6xJ206gmTnxBDkCfqXgi0t4gAPW/i4= In-Reply-To: <837ee1o461.fsf@gnu.org> Accept-Language: en-US Content-Language: en-US x-originating-ip: [50.111.87.13] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f8206886-7332-41c4-daad-08d69509bc10 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:BN6PR05MB3297; x-ms-traffictypediagnostic: BN6PR05MB3297: x-microsoft-exchange-diagnostics: 1; BN6PR05MB3297; 20:NmE34lz14couJ+Lm4UJzSks2A9kopgODQqu0BK1SRhMl0ilVhNrLWvFqCX1UCiXShESymH2jI1Gl2lnCu4xgfWrmh6GMSVs3L9y6S+6y7JZ7qfi4ooh6brZobvNd53WVRCRuh1KWRFmMopZLLERRGI74lI2caHfI8hrL8tQt868= x-microsoft-antispam-prvs: x-forefront-prvs: 0951AB0A30 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(136003)(366004)(376002)(396003)(39860400002)(346002)(199004)(189003)(54534003)(33656002)(88552002)(97736004)(2906002)(75432002)(256004)(14444005)(5024004)(6436002)(102836004)(6486002)(229853002)(6246003)(6512007)(68736007)(450100002)(4326008)(25786009)(53546011)(6506007)(3846002)(6116002)(66066001)(36756003)(71190400001)(71200400001)(316002)(786003)(83716004)(99286004)(86362001)(14454004)(53936002)(478600001)(76176011)(105586002)(106356001)(26005)(82746002)(7736002)(8936002)(6916009)(305945005)(186003)(446003)(11346002)(486006)(81166006)(81156014)(476003)(8676002)(5660300002)(2616005); DIR:OUT; SFP:1102; SCL:1; SRVR:BN6PR05MB3297; H:BN6PR05MB3556.namprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: duke.edu does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: jicHVOkpy/WUNp78bl+jyZIQ66+OQs8UvARW63HiDoJeSv9ytJFWRSrfKDcGQ7DP5Cetq+05/Dbgp9V1VIr6kCX7bw7dVDKgunbLWXhEjbFjHEjc1RIMXd2FBRsH7jL90s1r6frL34WeTpo6XjznTXsDcZGQk/UVgRLWFj9U/429tgPL+g05b3h4IsoayM/Y+bznApa5yH2KsVCwRYa6WGkInlng2qx2ojH1iBIrMa9+lXSapXztyh7vgMDUwhNNIHS/qBZ5u+rhZGAUfX20p4x9ocrVWGbQNEuCsk4SdW0J9t2Ns/KBXGlLSzPiXfTrEB1S6VJVlf06tMi12aOqWtCEFNTnxmdJxC8Hy4N/QBwjR5xur9RYkKtU5XxpHwegonYDE20NPhjqtaMqHwR6aN+iatjows4pvcPBAIbUsYY= X-OriginatorOrg: duke.edu X-MS-Exchange-CrossTenant-Network-Message-Id: f8206886-7332-41c4-daad-08d69509bc10 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2019 18:57:16.0588 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: cb72c54e-4a31-4d9e-b14a-1ea36dfac94c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR05MB3297 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-02-17_13:, , signatures=0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-02-17_13:, , signatures=0 X-Proofpoint-Spam-Reason: safe X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 152.3.189.235 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233430 Archived-At: Eli, My apologies for the belated reply, and for failing to properly follow the = contribution guidelines. I'll read them and make every effort to comply wit= h them, for any future patches I submit. My thanks for your suggested changes, willingness to work with me, and acce= ptance of this patch. Regarding my other patch (for properly backgrounding ERC's reconnection att= empts) - should I re-submit, with attention to complying with contribution = guidelines? Also - what do I need to do to have it further considered for acceptance? I= IRC, you had asked for a willing volunteer to review/test it, since you you= rself do not use ERC. Thanks again, Victor -- Victor J. Orlikowski <> vjo@(ee.|cs.)?duke.edu On Feb 15, 2019, at 3:19 AM, Eli Zaretskii wrote: >> From: Victor Orlikowski >> Date: Sun, 10 Feb 2019 19:14:26 +0000 >>=20 >> When using erc-dcc-get-filter with erc-dcc-verbose set to t, message >> errors prevent the DCC get from completing correctly. >>=20 >> The attached patch adds some additional error checking to >> erc-dcc-get-filter, and uses ethe function buffer-name in place of >> the variable buffer-file-name (which appears to be nil in this >> context, which thereby causes the message errors). >>=20 >>> From cd390337b8e819248568b900e6115dde8a19fde9 Mon Sep 17 00:00:00 2001 >> From: "Victor J. Orlikowski" >> Date: Sun, 10 Feb 2019 11:13:57 -0500 >> Subject: [PATCH] Perform additional validation in erc-dcc-get-filter, an= d use >> the function buffer-name rather than buffer-file-name (which is actually= nil >> in this context). >=20 > Thanks, I pushed this to the emacs-26 branch. >=20 > For the future, please note the following 2 gotchas: >=20 > . The title of your patch (in the Subject) was too long, and our > Git commit hooks rejected it. It should be a single line, not > ending in a period, and it should not exceed 79 characters > . You didn't provide ChangeLog-style entries for the changes you > made, which mention the modified function(s) and what was changed > in each one. >=20 > This is described in more detail in CONTRIBUTE, which I suggest to > read. >=20 > Thanks again for working on this.