From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Jean-Christophe Helary Newsgroups: gmane.emacs.devel Subject: Re: Trimming strings, /emacs/lisp/emacs-lisp/subr-x.el modification Date: Wed, 10 May 2017 00:33:47 +0900 Message-ID: <0843BD47-5297-4B55-B870-BBE3AEB59D23@gmail.com> References: <87vapij1l7.fsf@holos> <6870A2B6-F685-4955-9C0A-256601DB47BC@gmail.com> <51D5E92C-F125-4ADE-8C55-E3513C00ECDC@gmail.com> <8F6958D6-3E13-4C31-B1F8-AF10A8FC8FC6@gmail.com> <838tmafigi.fsf@gnu.org> <7C79DA34-96F2-4D9F-9E9C-01574AE00F12@gmail.com> <8360hefepp.fsf@gnu.org> <0E129E02-FA64-4664-825B-8854A66CA9C6@gmail.com> <3D0BA0E6-02E2-4E90-8A59-121065547E1C@gmail.com> <87ziepho0q.fsf@gnu.org> <83vapderm3.fsf@gnu.org> <87vapdhi9j.fsf@gnu.org> <83tw4xeorf.fsf@gnu.org> <83vapbctij.fsf@gnu.org> <87vapb9dd8.fsf@gnu.org> <877f1qutfq.fsf@drachen> <83wp9qawav.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1494344097 22840 195.159.176.226 (9 May 2017 15:34:57 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 9 May 2017 15:34:57 +0000 (UTC) Cc: Michael Heerdegen , Mark Oteiza , emacs-devel@gnu.org, =?utf-8?Q?Johan_Bockg=C3=A5rd?= , tino.calancha@gmail.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 09 17:34:48 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d879z-0005kd-FY for ged-emacs-devel@m.gmane.org; Tue, 09 May 2017 17:34:47 +0200 Original-Received: from localhost ([::1]:37788 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d87A3-0003Ym-8S for ged-emacs-devel@m.gmane.org; Tue, 09 May 2017 11:34:51 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33801) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d879G-0003W8-J0 for emacs-devel@gnu.org; Tue, 09 May 2017 11:34:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d879F-0002A4-Pi for emacs-devel@gnu.org; Tue, 09 May 2017 11:34:02 -0400 Original-Received: from mail-pg0-x243.google.com ([2607:f8b0:400e:c05::243]:35450) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d8796-000276-5i; Tue, 09 May 2017 11:33:52 -0400 Original-Received: by mail-pg0-x243.google.com with SMTP id i63so358348pgd.2; Tue, 09 May 2017 08:33:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=oT93VS5Y71Xhlci5EwKDdD0dL0JIA0JdeK9aYMdlzfc=; b=drpJcJ/1+E1T4OCIa1kdqQTflm5GrsDLfqtvbvG2o46XWVZt5t2XejmhC575Km3ckr CrtS8aTxWrXDmMfEnh9nlej4ahUgNZ51TS4qRHrD9kiBiG5P7q3JiCDGpmrse2+4MsDd OuHJIAMDyRmPNApFKm7XmBQuDeGYmxABzZ6s9O0EB8wgBsoJ7AqxAhqrc6rNnysljr3X OkuQHfrxv21OlcbUTb4pr+SbYAbHwzFAshln+oGyb+okrONMdFDr6jGUHlJ6YMyXG075 mBGR7eh1/l5pOJka+5GHCHO3klfOmL9k85+6TotSD/ZvuSCJ8WlGpix8D0Jymye0ivN4 5OQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=oT93VS5Y71Xhlci5EwKDdD0dL0JIA0JdeK9aYMdlzfc=; b=lynp11JZcO2jGZQFJIiDk9kOHcJT9XHsnD7dUl77NCo2eO7YNik5Iur/g4zMAXVRPX Pb4PHyVX7qtd52hSrx4sOC1bP4X04DM4HQnB/pbsfK0Tv7XAKkM5kMjoaFLCdWg63zbC 3Z/ZRs3h/SMddFdtMbJ9anQnkNRwQDW95OSN6EbJU3D0sYhJhibTpAjqk0RbPiYtjhIn BrT1gPyd4CFjMP6iDgH8FpbZrS9zjSNlPsfZhVNXRXZixo1Dob3T+XwBPjuUALdmhB+m 2u03nfNq/PY+mvIK463h2NUeaunf509LHLsojzY3538t61sTpYayf802QTfir9vmccA2 PtiQ== X-Gm-Message-State: AODbwcDVC8gub6l6TWMMovxcwlwKUgB0Bm9KWD35kRIRsk+byukkVfOK rzOCVU5/ZrbTRA== X-Received: by 10.99.95.88 with SMTP id t85mr863539pgb.50.1494344031218; Tue, 09 May 2017 08:33:51 -0700 (PDT) Original-Received: from [192.168.24.54] (pl25298.ag0304.nttpc.ne.jp. [133.232.153.210]) by smtp.gmail.com with ESMTPSA id n71sm601747pfg.46.2017.05.09.08.33.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 May 2017 08:33:50 -0700 (PDT) In-Reply-To: <83wp9qawav.fsf@gnu.org> X-Mailer: Apple Mail (2.3273) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214718 Archived-At: > On May 10, 2017, at 0:23, Eli Zaretskii wrote: >=20 >> From: Michael Heerdegen >> Cc: Johan Bockg=C3=A5rd , mvoteiza@udel.edu, >> Eli Zaretskii , tino.calancha@gmail.com, >> emacs-devel@gnu.org >> Date: Tue, 09 May 2017 14:05:13 +0200 >>=20 >> Jean-Christophe Helary writes: >>=20 >>>> (split-string "abc, ;def g,hi" nil nil ",\\|;") >>>> =3D> >>>> ("abc" "def" "g") ; BUG >>>=20 >>> Ok, and the way to get your result is: >>>=20 >>> (split-string "abc, ;def g,hi" nil nil "\\(,\\|;\\)") >>>=20 >>> which means that Emacs thinks it is the caller's duty to provide the >>> grouping construct, which also happens to be ugly, and non-intuitive >>> since ",\\|;" is an otherwise valid regexp... >>>=20 >>> So, how do we go about that? Do we report a bug? Or do we find a = good >>> reason for that to happen and modify the documentation for >>> split-string ? >>=20 >> I'm curious what could be reasons not to fix this (in the code). >> Allowing only a subset of possible regexps would be quite strange. >> Would there be any advantages? >=20 > How about if we proceed with the change in string-trim, and file a > separate bug against both it and split-string, for such regexps? > These seem to be largely unrelated issues, and it's a pity to block > Jean-Christophe's changes due to that. Ok, so we agree that we don't add \\( \\) to the regexp and that we = expect the caller to send a correct regexp as is the case for = split-string, is that correct ? (But I'm also glad the discussion that started with a trivial = modification to ns-win.el triggered all that *and* that I understood = what was at stake :-) Jean-Christophe=