From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: Comments to the new tree sitter implementation Date: Mon, 25 Apr 2022 11:52:53 -0700 Message-ID: <06C91D4F-3505-45B9-8340-BADE3EE665D1@gmail.com> References: <87y1zwq8sf.fsf@thornhill.no> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19934"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: Theodor Thornhill Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 25 20:54:25 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nj3qr-00054U-Fq for ged-emacs-devel@m.gmane-mx.org; Mon, 25 Apr 2022 20:54:25 +0200 Original-Received: from localhost ([::1]:38086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nj3qq-0006eY-Aw for ged-emacs-devel@m.gmane-mx.org; Mon, 25 Apr 2022 14:54:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45376) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nj3pT-0005xR-Oy for emacs-devel@gnu.org; Mon, 25 Apr 2022 14:52:59 -0400 Original-Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]:34461) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nj3pS-0005kC-3x for emacs-devel@gnu.org; Mon, 25 Apr 2022 14:52:59 -0400 Original-Received: by mail-pl1-x62c.google.com with SMTP id n8so28118663plh.1 for ; Mon, 25 Apr 2022 11:52:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=k9RcvyuNs8sPm9irD5rz6NUehn3yshWGIWef2IyVPyw=; b=VVqxFUq902xpbOm9tkPO8nuysNcKjm5X3S6OS6NNxzE21Wqa81po+aHX1QZi1N7NAJ H/xRijFnbZ0gXCnWzTiT19bhA+L0StnJRIhGtt3QHBjYxs9BBCeVsECnya/sRYAEkNIn cXpGOyrcD1tmgujFtDUGj6KMiURukWJvivXL88ILq4iN7uLNXz/QIiCcU+Ug9I0uDQIZ jNLWLOs1ylENuE/zwTuqxjTvMOswSa9tKCYIbT7WI2lsS6hs3jZ/k6AvZ+KGPrQy8TU1 NyroDHzSZF1lNqw5cWq0eimGl5XfvUqYPF7IGIK68z0kEX0YnMas+rmUxwEOb/OLNSX5 i0VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=k9RcvyuNs8sPm9irD5rz6NUehn3yshWGIWef2IyVPyw=; b=A7wWeiK8IJQeX0ru28c8af5HA9rrdUvtZnbJZOfRBXstNxhYmQBtRDsxLZP0UeiObg p/zcOg4UDesvsb/uQF4+o/hZJu5kFbwpMp0Of+gwjwY0L9q/3GbnOsUIRUYg6xChiwjA UrTh5MRs1IWA8G8jyGVf/9EdT1KjUt7UMhiH6cu2bFgRZ7SUUSRQAaqBGv7RpDb1uXqr juamK6ha7MmdyI471K+MzbkiQB1zMq3TjOkWJDcI4bOwdjoXWOM4QTXtA8hPuvrCdBwd cSwCy9H9yfdkyVRsOBpCWhIZoiS6jbMARmpXhqLUl4Kgfs8O3ign32tOorsGbhFPvvmM j1xg== X-Gm-Message-State: AOAM532Q5cFTBiYv4NbXS/PO0SWJ4ZYiHUVxcvq+TDlOf1q3k2EAUUPj IeTzTqYXZ+cVrR49O/gidvl30b//cgg= X-Google-Smtp-Source: ABdhPJxDjjwHJ7Ha8T9JGQmITdsydXCa6uoUNkVPCxyrL7MvPga7c+5cBOK7GZeOoVNbyeYIErFCtQ== X-Received: by 2002:a17:902:8487:b0:158:f82d:e39e with SMTP id c7-20020a170902848700b00158f82de39emr19479896plo.52.1650912776126; Mon, 25 Apr 2022 11:52:56 -0700 (PDT) Original-Received: from smtpclient.apple ([2600:1700:2ec7:8c90:41c3:d952:3fd6:24bb]) by smtp.gmail.com with ESMTPSA id p8-20020aa78608000000b005082c3cbfd2sm12048572pfn.218.2022.04.25.11.52.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Apr 2022 11:52:55 -0700 (PDT) In-Reply-To: <87y1zwq8sf.fsf@thornhill.no> X-Mailer: Apple Mail (2.3696.80.82.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::62c; envelope-from=casouri@gmail.com; helo=mail-pl1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288873 Archived-At: >=20 >=20 > Lastly I want to say that I'm really impressed by this, Yuan! Thank = you, > and I'm looking forward to getting it mainlined. >=20 > I'll also add the link to the typescript-mode I'm making atm, so that > the context of what I'm talking about may be a little clearer: >=20 > = https://github.com/emacs-typescript/typescript.el/blob/feature/tsx-support= /typescript-ts.el >=20 > All the best, > Theodor >=20 > Sorry that I can=E2=80=99t get back to you very soon. I=E2=80=99ve been = incredibly busy recently. I=E2=80=99ll find time to look at your points = and try to debug the problems you mention with typescript-ts.el.=20 Eli, I was trying to push my branch on savannah but (embarrassingly) = hasn=E2=80=99t succeed yet. I think if I create an account and add my = ssh key and clone by user-name@git.savannah.gnu.org:/srv/git/emacs.git, = I should be able to push a branch? I=E2=80=99m having some problem with = authenticating with the key, hopefully that can be sorted out soon. Once = I can push to my repo, how do I create a scratch branch under the main = Emacs repo? Yuan=