unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dmitry@gutov.dev>
To: Jim Porter <jporterbugs@gmail.com>, emacs-devel@gnu.org
Subject: Re: Improving 'pcase' documentation
Date: Mon, 20 Nov 2023 15:54:16 +0200	[thread overview]
Message-ID: <05bd1167-13b6-01e5-ac6e-22370daaf41d@gutov.dev> (raw)
In-Reply-To: <19a64b7a-cec0-ed8a-d413-096451cc7413@gmail.com>

On 19/11/2023 22:14, Jim Porter wrote:
> Does anyone have any particular feedback on these ideas, suggestions of 
> what would be the most beneficial, etc?

I don't have much to add at the moment, but the list sounds great.

Number 6 might be more difficult to do than the rest, since we currently 
don't have any support for context-local syntax (another example would 
be 'should' forms in ert tests) in completion/font-lock, and any such 
logic would have consider the level of quoting/unquoting, but ultimately 
it can be done.

 > (I also think it'd be nice to font-lock anything that looks like 
",SYMBOL", even outside of 'pcase', but maybe others would find that 
annoying.)

And that sounds like a part of more general feature where local 
variables would be highlighted with font-lock-variable-name-face and 
font-lock-variable-use-face. To determine that ,foo is a variable 
declaration (inside a pcase form or anywhere) and not just a reference, 
font-lock would have to do some macro-expansion. I wonder what would be 
the performance implications of such general approach.



  reply	other threads:[~2023-11-20 13:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-19 20:14 Improving 'pcase' documentation Jim Porter
2023-11-20 13:54 ` Dmitry Gutov [this message]
2023-11-21 16:30 ` Michael Heerdegen
2023-12-25 14:44 ` Stefan Kangas
2023-12-25 18:33   ` Stefan Monnier
2023-12-27  4:54   ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05bd1167-13b6-01e5-ac6e-22370daaf41d@gutov.dev \
    --to=dmitry@gutov.dev \
    --cc=emacs-devel@gnu.org \
    --cc=jporterbugs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).